Merge pull request #1002 from github/fixes/pr-details-metrics

Add missing metrics back in

Author: grokys

src/GitHub.App/ViewModels/PullRequestDetailViewModel.cs

@@ -286,6 +286,7 @@ public override void Initialize([AllowNull] ViewWithData data)
         /// <param name="files">The pull request's changed files.</param>
         public async Task Load(IPullRequestModel pullRequest)
         {
+            var firstLoad = (Model == null);
             Model = pullRequest;
             Title = Resources.PullRequestNavigationItemText + " #" + pullRequest.Number;
 
@@ -298,7 +299,6 @@ public async Task Load(IPullRequestModel pullRequest)
             ChangedFilesTree = CreateChangedFilesTree(pullRequest, changes).Children.ToList();
 
             var localBranches = await pullRequestsService.GetLocalBranches(repository, pullRequest).ToList();
-
             IsCheckedOut = localBranches.Contains(repository.CurrentBranch);
 
             if (IsCheckedOut)
@@ -363,6 +363,11 @@ public async Task Load(IPullRequestModel pullRequest)
 
             IsLoading = IsBusy = false;
 
+            if (firstLoad)
+            {
+                usageTracker.IncrementPullRequestOpened().Forget();
+            }
+
             if (!isInCheckout)
             {
                 pullRequestsService.RemoveUnusedRemotes(repository).Subscribe(_ => { });
@@ -480,7 +485,6 @@ IObservable<Unit> DoCheckout(object unused)
             return Observable.Defer(async () =>
             {
                 var localBranches = await pullRequestsService.GetLocalBranches(repository, Model).ToList();
-
                 if (localBranches.Count > 0)
                 {
                     return pullRequestsService.SwitchToBranch(repository, Model);

src/GitHub.Exports/Services/IUsageTracker.cs

@@ -19,6 +19,7 @@ public interface IUsageTracker
         Task IncrementPullRequestCheckOutCount(bool fork);
         Task IncrementPullRequestPullCount(bool fork);
         Task IncrementPullRequestPushCount(bool fork);
+        Task IncrementPullRequestOpened();
         Task IncrementWelcomeDocsClicks();
         Task IncrementWelcomeTrainingClicks();
         Task IncrementGitHubPaneHelpClicks();

src/GitHub.VisualStudio/Services/UsageTracker.cs

@@ -195,6 +195,13 @@ public async Task IncrementGitHubPaneHelpClicks()
             SaveUsage(usage);
         }
 
+        public async Task IncrementPullRequestOpened()
+        {
+            var usage = await LoadUsage();
+            ++usage.Model.NumberOfPullRequestsOpened;
+            SaveUsage(usage);
+        }
+
         async Task Initialize()
         {
             // The services needed by the usage tracker are loaded when they are first needed to
@@ -346,6 +353,9 @@ static void ClearCounters(UsageModel usage, bool weekly, bool monthly)
             usage.NumberOfForkPullRequestsCheckedOut = 0;
             usage.NumberOfForkPullRequestPulls = 0;
             usage.NumberOfForkPullRequestPushes = 0;
+            usage.NumberOfGitHubPaneHelpClicks = 0;
+            usage.NumberOfWelcomeTrainingClicks = 0;
+            usage.NumberOfWelcomeDocsClicks = 0;
 
             if (weekly)
                 usage.NumberOfStartupsWeek = 0;

src/GitHub.VisualStudio/Services/UsageTrackerDispatcher.cs

@@ -26,6 +26,7 @@ public UsageTrackerDispatcher([Import(typeof(SVsServiceProvider))] IServiceProvi
         public Task IncrementOpenInGitHubCount() => inner.IncrementOpenInGitHubCount();
         public Task IncrementPublishCount() => inner.IncrementPublishCount();
         public Task IncrementUpstreamPullRequestCount() => inner.IncrementUpstreamPullRequestCount();
+        public Task IncrementPullRequestOpened() => inner.IncrementPullRequestOpened();
         public Task IncrementPullRequestCheckOutCount(bool fork) => inner.IncrementPullRequestCheckOutCount(fork);
         public Task IncrementPullRequestPullCount(bool fork) => inner.IncrementPullRequestPullCount(fork);
         public Task IncrementPullRequestPushCount(bool fork) => inner.IncrementPullRequestPushCount(fork);