Make settings properties notification-aware

Also add supporting for generating complex properties like UIState

Author: shana

src/GitHub.Exports/Settings/generated/IPackageSettings.tt

@@ -22,11 +22,13 @@ namespace GitHub.Settings
         void Save();
 <#
 foreach (var j in json["settings"].Children()) {
+	var type = j["type"].ToString();
+	if (type == "object")
+		type = j["typename"].ToString();
 #>
-        <#= j["type"] #> <#= j["name"] #> { get; set; }
+        <#= type #> <#= j["name"] #> { get; set; }
 <#
 }
 #>
-		UIState UIState { get; }
     }
 }

src/GitHub.VisualStudio/Settings/PackageSettings.cs

@@ -5,12 +5,13 @@
 using Microsoft.VisualStudio.Shell.Settings;
 using SettingsStore = GitHub.Helpers.SettingsStore;
 using GitHub.Settings;
+using GitHub.Primitives;
 
 namespace GitHub.VisualStudio.Settings
 {
     [Export(typeof(IPackageSettings))]
     [PartCreationPolicy(CreationPolicy.Shared)]
-    public partial class PackageSettings : IPackageSettings
+    public partial class PackageSettings : NotificationAwareObject, IPackageSettings
     {
         readonly SettingsStore settingsStore;
 
@@ -20,15 +21,11 @@ public PackageSettings([Import(typeof(SVsServiceProvider))] IServiceProvider ser
             var sm = new ShellSettingsManager(serviceProvider);
             settingsStore = new SettingsStore(sm.GetWritableSettingsStore(SettingsScope.UserSettings), Info.ApplicationInfo.ApplicationSafeName);
             LoadSettings();
-            UIState = SimpleJson.DeserializeObject<UIState>((string)settingsStore.Read("UIState", "{}"));
         }
 
-        public UIState UIState { get; }
-
         public void Save()
         {
             SaveSettings();
-            settingsStore.Write("UIState", SimpleJson.SerializeObject(UIState));
         }
     }
 }

src/GitHub.VisualStudio/Settings/generated/PackageSettings.tt

@@ -16,16 +16,28 @@ var json = JObject.Parse(File.ReadAllText(file));
 */
 
 using GitHub.Settings;
+using GitHub.Primitives;
+using GitHub.VisualStudio.Helpers;
 
 namespace GitHub.VisualStudio.Settings {
 
-    public partial class PackageSettings : IPackageSettings
+    public partial class PackageSettings : NotificationAwareObject, IPackageSettings
     {
 
 <#
 foreach (var j in json["settings"].Children()) {
+    var type = j["type"].ToString();
+    if (type == "object")
+        type = j["typename"].ToString();
+    var field = Char.ToLower(j["name"].ToString()[0]) + j["name"].ToString().Substring(1);
 #>
-        public <#= j["type"] #> <#= j["name"] #> { get; set; }
+        <#= type #> <#= field #>;
+        public <#= type #> <#= j["name"] #>
+        {
+            get { return <#= field #>; }
+            set { <#= field #>  = value; this.RaisePropertyChange(); }
+        }
+
 <#
 }
 #>
@@ -34,9 +46,18 @@ foreach (var j in json["settings"].Children()) {
         {
 <#
 foreach (var j in json.Children().Children().Children()) {
+    if (j["type"].ToString() == "object")
+    {
+#>
+            <#= j["name"] #> = SimpleJson.DeserializeObject<<#= j["typename"] #>>((string)settingsStore.Read("<#= j["name"] #>", "{}"));
+<#
+    }
+    else
+    {
 #>
             <#= j["name"] #> = (<#= j["type"] #>)settingsStore.Read("<#= j["name"] #>", <#= j["default"] #>);
 <#
+    }
 }
 #>
         }
@@ -45,9 +66,18 @@ foreach (var j in json.Children().Children().Children()) {
         {
 <#
 foreach (var j in json.Children().Children().Children()) {
+    if (j["type"].ToString() == "object")
+    {
+#>
+            settingsStore.Write("<#= j["name"] #>", SimpleJson.SerializeObject(<#= j["name"] #>));
+<#
+    }
+    else
+    {
 #>
             settingsStore.Write("<#= j["name"] #>", <#= j["name"] #>);
 <#
+    }
 }
 #>
         }

src/common/settings.json

@@ -4,6 +4,12 @@
         "name": "CollectMetrics",
         "type": "bool",
         "default": 'true'
+    },
+    {
+        "name": "UIState",
+        "type": "object",
+		"typename": "UIState",
+        "default": 'null'
     }
     ]
 }