Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit c909f45

Browse files
authored
Merge pull request #1717 from jcansdale/fixes/1617-spell-checking
Enable spell checking where appropriate
2 parents 1d801fb + 2c7f51c commit c909f45

File tree

9 files changed

+14
-15
lines changed

9 files changed

+14
-15
lines changed

src/GitHub.InlineReviews/Views/CommentView.xaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,8 @@
154154
Text="{Binding Body, UpdateSourceTrigger=PropertyChanged}"
155155
TextWrapping="Wrap"
156156
VerticalAlignment="Center"
157-
GotFocus="ReplyPlaceholder_GotFocus">
157+
GotFocus="ReplyPlaceholder_GotFocus"
158+
SpellCheck.IsEnabled="True">
158159
<ui:PromptTextBox.Style>
159160
<Style TargetType="ui:PromptTextBox" BasedOn="{StaticResource RoundedPromptTextBox}">
160161
<Setter Property="Foreground" Value="{DynamicResource GitHubVsToolWindowText}" />

src/GitHub.UI/Assets/Controls.xaml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,6 @@
1919
Styles for standard windows controls
2020
-->
2121

22-
<ContextMenu x:Key="DefaultContextMenu">
23-
<MenuItem Header="Cut" Command="ApplicationCommands.Cut"/>
24-
<MenuItem Header="Copy" Command="ApplicationCommands.Copy"/>
25-
<MenuItem Header="Paste" Command="ApplicationCommands.Paste"/>
26-
</ContextMenu>
27-
<!--End ContextMenu-->
28-
2922
<!-- ProgressBar -->
3023
<Style x:Key="GitHubProgressBar" TargetType="{x:Type ui:GitHubProgressBar}">
3124
<Setter Property="Foreground" Value="#999999" />

src/GitHub.UI/Assets/Controls/FilterTextBox.xaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
<Setter Property="ScrollViewer.PanningMode" Value="VerticalFirst"/>
1515
<Setter Property="Stylus.IsFlicksEnabled" Value="False"/>
1616
<Setter Property="Padding" Value="3,3,18,3" />
17-
<Setter Property="ContextMenu" Value="{DynamicResource DefaultContextMenu}" />
1817
<Setter Property="Template">
1918
<Setter.Value>
2019
<ControlTemplate TargetType="{x:Type ui:FilterTextBox}">

src/GitHub.UI/Assets/TextBlocks.xaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
<Setter Property="BorderThickness" Value="1" />
1616
<Setter Property="ToolTipService.ShowDuration" Value="30000" />
1717
<Setter Property="ToolTipService.ShowOnDisabled" Value="True" />
18-
<Setter Property="ContextMenu" Value="{DynamicResource DefaultContextMenu}" />
1918
<Setter Property="Template">
2019
<Setter.Value>
2120
<ControlTemplate TargetType="{x:Type TextBox}">

src/GitHub.VisualStudio/Views/Dialog/GistCreationView.xaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@
7474
<ghfvs:PromptTextBox x:Name="fileNameTextBox" Grid.Column="1" Grid.Row="0" AutomationProperties.AutomationId="{x:Static ghfvs:AutomationIDs.GistFileNameTextBox}" />
7575

7676
<Label Grid.Column="0" Grid.Row="1" Target="{Binding ElementName=descriptionTextBox}" Content="{x:Static prop:Resources.Description}"/>
77-
<ghfvs:PromptTextBox x:Name="descriptionTextBox" Grid.Column="1" Grid.Row="1" AutomationProperties.AutomationId="{x:Static ghfvs:AutomationIDs.GistDescriptionTextBlock}"/>
77+
<ghfvs:PromptTextBox x:Name="descriptionTextBox" Grid.Column="1" Grid.Row="1" SpellCheck.IsEnabled="True" AutomationProperties.AutomationId="{x:Static ghfvs:AutomationIDs.GistDescriptionTextBlock}"/>
7878

7979
<StackPanel x:Name="accountStackPanel" Grid.Column="1" Grid.Row="2" Orientation="Horizontal">
8080
<Image

src/GitHub.VisualStudio/Views/Dialog/RepositoryCreationView.xaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,7 @@
111111
Grid.Column="1"
112112
MaxLength="{x:Static ghfvs:Constants.MaxRepositoryNameLength}"
113113
Text="{Binding RepositoryName, UpdateSourceTrigger=PropertyChanged}"
114+
SpellCheck.IsEnabled="True"
114115
AutomationProperties.AutomationId="{x:Static ghfvs:AutomationIDs.RepositoryNameTextBox}" />
115116

116117
<StackPanel Grid.Row="1" Grid.Column="1">
@@ -132,6 +133,7 @@
132133
Grid.Row="2"
133134
Grid.Column="1"
134135
Text="{Binding Description, UpdateSourceTrigger=PropertyChanged}"
136+
SpellCheck.IsEnabled="True"
135137
AutomationProperties.AutomationId="{x:Static ghfvs:AutomationIDs.RepositoryDescriptionTextBox}" />
136138

137139
<Label Grid.Row="3"

src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCreationView.xaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,8 @@
146146
Margin="10,5"
147147
Text="{Binding PRTitle, UpdateSourceTrigger=PropertyChanged}"
148148
PromptText="{x:Static prop:Resources.TitleRequired}"
149-
Style="{DynamicResource GitHubVsPromptTextBox}"
149+
Style="{DynamicResource GitHubVsPromptTextBox}"
150+
SpellCheck.IsEnabled="True"
150151
AutomationProperties.AutomationId="{x:Static ghfvs:AutomationIDs.PullRequestCreationTitleTextBox}"/>
151152

152153
<ghfvs:PromptTextBox Grid.Row="2"
@@ -158,6 +159,7 @@
158159
Style="{DynamicResource GitHubVsPromptTextBox}"
159160
VerticalScrollBarVisibility="Auto"
160161
TextWrapping="Wrap"
162+
SpellCheck.IsEnabled="True"
161163
AutomationProperties.AutomationId="{x:Static ghfvs:AutomationIDs.PullRequestCreationDescriptionTextBox}"/>
162164

163165
<ghfvs:ValidationMessage x:Name="titleValidationMessage"

src/GitHub.VisualStudio/Views/GitHubPane/PullRequestReviewAuthoringView.xaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,8 @@
4646
MinHeight="120"
4747
Padding="0 4"
4848
TextWrapping="Wrap"
49-
Text="{Binding Body}"/>
49+
Text="{Binding Body}"
50+
SpellCheck.IsEnabled="True"/>
5051

5152
<StackPanel Margin="0 4" Orientation="Horizontal">
5253
<ui:DropDownButton AutoCloseOnClick="True" Content="Submit review">

src/GitHub.VisualStudio/Views/TeamExplorer/RepositoryPublishView.xaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,8 @@
107107
Foreground="{DynamicResource GitHubVsWindowText}"
108108
MaxLength="{x:Static ghfvs:Constants.MaxRepositoryNameLength}"
109109
Text="{Binding RepositoryName}"
110-
PromptText="{x:Static prop:Resources.RepoNameText}"
110+
PromptText="{x:Static prop:Resources.RepoNameText}"
111+
SpellCheck.IsEnabled="True"
111112
AutomationProperties.AutomationId="{x:Static ghfvs:AutomationIDs.TeamExplorerPublishRepositoryNameTextBox}"
112113
VerticalContentAlignment="Center"/>
113114
</Grid>
@@ -121,7 +122,8 @@
121122
Foreground="{DynamicResource GitHubVsWindowText}"
122123
Text="{Binding Description}"
123124
TextWrapping="WrapWithOverflow"
124-
PromptText="{x:Static prop:Resources.DescriptionOptional}"
125+
PromptText="{x:Static prop:Resources.DescriptionOptional}"
126+
SpellCheck.IsEnabled="True"
125127
AutomationProperties.AutomationId="{x:Static ghfvs:AutomationIDs.TeamExplorerPublishRepositoryDescriptionTextBox}" />
126128
</Grid>
127129

0 commit comments

Comments
 (0)