Use ContentPresenter instead of ContentControl

This resolves the, "Logical tree depth exceeded while traversing the tree. This could indicate a cycle in the tree" exception.

Author: jcansdale

src/GitHub.VisualStudio/UI/GitHubPane.cs

@@ -5,7 +5,6 @@
 using System.Runtime.InteropServices;
 using System.Windows;
 using System.Windows.Controls;
-using GitHub.Helpers;
 using GitHub.Extensions;
 using GitHub.Factories;
 using GitHub.Services;
@@ -38,17 +37,17 @@ public class GitHubPane : ToolWindowPane, IServiceProviderAware
         bool initialized = false;
         IDisposable viewSubscription;
         IGitHubPaneViewModel viewModel;
-        ContentControl contentControl;
+        ContentPresenter contentPresenter;
 
         public FrameworkElement View
         {
-            get { return contentControl.Content as FrameworkElement; }
+            get { return contentPresenter.Content as FrameworkElement; }
             set
             {
                 viewSubscription?.Dispose();
                 viewSubscription = null;
 
-                contentControl.Content = value;
+                contentPresenter.Content = value;
 
                 viewSubscription = value.WhenAnyValue(x => x.DataContext)
                     .SelectMany(x =>
@@ -66,7 +65,7 @@ public FrameworkElement View
         public GitHubPane() : base(null)
         {
             Caption = "GitHub";
-            Content = contentControl = new ContentControl();
+            Content = contentPresenter = new ContentPresenter();
 
             BitmapImageMoniker = new Microsoft.VisualStudio.Imaging.Interop.ImageMoniker()
             {
@@ -95,12 +94,10 @@ public void Initialize(IServiceProvider serviceProvider)
 
         async Task InitializeAsync(IServiceProvider serviceProvider)
         {
-            // Allow MEF to refresh its cache on a background thread so it isn't counted against us.
+            // Allow MEF to initialize its cache asynchronously
             var asyncServiceProvider = (IAsyncServiceProvider)GetService(typeof(SAsyncServiceProvider));
             await asyncServiceProvider.GetServiceAsync(typeof(SComponentModel));
 
-            await ThreadingHelper.SwitchToMainThreadAsync();
-
             var provider = VisualStudio.Services.GitHubServiceProvider;
             var teServiceHolder = provider.GetService<ITeamExplorerServiceHolder>();
             teServiceHolder.ServiceProvider = serviceProvider;