Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit ca9ed5a

Browse files
committed
Moved usage model guid/date.
They should be in both the `Measures` and `Dimensions`.
1 parent da93fb7 commit ca9ed5a

File tree

2 files changed

+16
-8
lines changed

2 files changed

+16
-8
lines changed

src/GitHub.Exports/Models/UsageModel.cs

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,24 +4,30 @@ namespace GitHub.Models
44
{
55
public class UsageModel
66
{
7-
public Guid Guid { get; set; }
8-
public DateTimeOffset Date { get; set; }
97
public DimensionsModel Dimensions { get; set; }
108
public MeasuresModel Measures { get; set; }
119

1210
public static UsageModel Create(Guid guid)
1311
{
1412
return new UsageModel
1513
{
16-
Guid = guid,
17-
Date = DateTime.Now,
18-
Dimensions = new DimensionsModel(),
19-
Measures = new MeasuresModel(),
14+
Dimensions = new DimensionsModel
15+
{
16+
Guid = guid,
17+
Date = DateTime.Now,
18+
},
19+
Measures = new MeasuresModel
20+
{
21+
Guid = guid,
22+
Date = DateTime.Now,
23+
},
2024
};
2125
}
2226

2327
public class DimensionsModel
2428
{
29+
public Guid Guid { get; set; }
30+
public DateTimeOffset Date { get; set; }
2531
public string AppVersion { get; set; }
2632
public string VSVersion { get; set; }
2733
public string Lang { get; set; }
@@ -31,6 +37,8 @@ public class DimensionsModel
3137

3238
public class MeasuresModel
3339
{
40+
public Guid Guid { get; set; }
41+
public DateTimeOffset Date { get; set; }
3442
public int NumberOfStartups { get; set; }
3543
public int NumberOfUpstreamPullRequests { get; set; }
3644
public int NumberOfClones { get; set; }

src/GitHub.VisualStudio/Services/UsageTracker.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ async Task TimerTick()
9898

9999
for (var i = data.Reports.Count - 1; i >= 0; --i)
100100
{
101-
if (data.Reports[i].Date.Date != DateTimeOffset.Now.Date)
101+
if (data.Reports[i].Dimensions.Date.Date != DateTimeOffset.Now.Date)
102102
{
103103
try
104104
{
@@ -121,7 +121,7 @@ async Task TimerTick()
121121

122122
async Task<UsageModel> GetCurrentReport(UsageData data)
123123
{
124-
var current = data.Reports.FirstOrDefault(x => x.Date.Date == DateTimeOffset.Now.Date);
124+
var current = data.Reports.FirstOrDefault(x => x.Dimensions.Date.Date == DateTimeOffset.Now.Date);
125125

126126
if (current == null)
127127
{

0 commit comments

Comments
 (0)