Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit cb211bb

Browse files
committed
Simplify inotify code
Anything inheriting from `NotificationAwareObject` also needs functionality from `INotifyPropertySource`, so might as well put that in `NotificationAwareObject`
1 parent b69935d commit cb211bb

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

src/GitHub.Exports/Helpers/NotificationAwareObject.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
using System.ComponentModel;
2+
using GitHub.VisualStudio.Helpers;
23

34
namespace GitHub.Primitives
45
{
5-
public abstract class NotificationAwareObject : INotifyPropertyChanged
6+
public abstract class NotificationAwareObject : INotifyPropertyChanged, INotifyPropertySource
67
{
78
public event PropertyChangedEventHandler PropertyChanged;
89

src/GitHub.VisualStudio/Base/TeamExplorerItemBase.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
namespace GitHub.VisualStudio.Base
1313
{
14-
public class TeamExplorerItemBase : TeamExplorerGitRepoInfo, INotifyPropertySource
14+
public class TeamExplorerItemBase : TeamExplorerGitRepoInfo
1515
{
1616
readonly ISimpleApiClientFactory apiFactory;
1717
protected ITeamExplorerServiceHolder holder;

src/GitHub.VisualStudio/Base/TeamExplorerNavigationItemBase.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,12 @@
88
using GitHub.VisualStudio.Helpers;
99
using Microsoft.TeamFoundation.Controls;
1010
using Microsoft.VisualStudio.PlatformUI;
11-
using Microsoft.VisualStudio.TeamFoundation.Git.Extensibility;
1211
using NullGuard;
1312
using GitHub.Models;
1413

1514
namespace GitHub.VisualStudio.Base
1615
{
17-
public class TeamExplorerNavigationItemBase : TeamExplorerItemBase, ITeamExplorerNavigationItem2, INotifyPropertySource
16+
public class TeamExplorerNavigationItemBase : TeamExplorerItemBase, ITeamExplorerNavigationItem2
1817
{
1918
readonly Octicon octicon;
2019

src/GitHub.VisualStudio/Base/TeamExplorerSectionBase.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
namespace GitHub.VisualStudio.Base
1414
{
15-
public class TeamExplorerSectionBase : TeamExplorerItemBase, ITeamExplorerSection, INotifyPropertySource
15+
public class TeamExplorerSectionBase : TeamExplorerItemBase, ITeamExplorerSection
1616
{
1717
protected IConnectionManager connectionManager;
1818

0 commit comments

Comments
 (0)