Use JoinableTaskFactory from parent AsyncPackage

jcansdale · jcansdale · commit cb266083f4d8 · 2018-04-06T08:49:26.000+01:00
diff --git a/src/GitHub.VisualStudio/UI/GitHubPane.cs b/src/GitHub.VisualStudio/UI/GitHubPane.cs
@@ -80,7 +80,10 @@ public GitHubPane() : base(null)
 
         protected override void Initialize()
         {
-            viewModelTask = ThreadHelper.JoinableTaskFactory.RunAsync(InitializeAsync);
+            // Using JoinableTaskFactory from parent AsyncPackage. That way if VS shuts down before this
+            // work is done, we won't risk crashing due to arbitrary work going on in background threads.
+            var asyncPackage = (AsyncPackage)Package;
+            viewModelTask = asyncPackage.JoinableTaskFactory.RunAsync(InitializeAsync);
         }
 
         public Task<IGitHubPaneViewModel> GetViewModelAsync() => viewModelTask.JoinAsync();

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,10 @@ public GitHubPane() : base(null)`
`80`	`80`
`81`	`81`	`protected override void Initialize()`
`82`	`82`	`{`
`83`		`- viewModelTask = ThreadHelper.JoinableTaskFactory.RunAsync(InitializeAsync);`
	`83`	`+ // Using JoinableTaskFactory from parent AsyncPackage. That way if VS shuts down before this`
	`84`	`+ // work is done, we won't risk crashing due to arbitrary work going on in background threads.`
	`85`	`+ var asyncPackage = (AsyncPackage)Package;`
	`86`	`+ viewModelTask = asyncPackage.JoinableTaskFactory.RunAsync(InitializeAsync);`
`84`	`87`	`}`
`85`	`88`
`86`	`89`	`public Task<IGitHubPaneViewModel> GetViewModelAsync() => viewModelTask.JoinAsync();`