Rename HasNoRemoteOrigin to HasRemotesButNoOrigin

This is more explicit about what it actually checks.

Author: jcansdale

src/GitHub.App/ViewModels/GitHubPane/GitHubPaneViewModel.cs

@@ -413,7 +413,7 @@ async Task UpdateContent(LocalRepositoryModel repository)
             }
             else if (string.IsNullOrWhiteSpace(repository.CloneUrl))
             {
-                if (repository.HasNoRemoteOrigin)
+                if (repository.HasRemotesButNoOrigin)
                 {
                     log.Debug("No origin remote");
                     Content = noRemoteOrigin;

src/GitHub.Exports/Models/LocalRepositoryModel.cs

@@ -27,7 +27,7 @@ public string LocalPath
         /// <summary>
         /// True if repository has remotes but none are named "origin".
         /// </summary>
-        public bool HasNoRemoteOrigin
+        public bool HasRemotesButNoOrigin
         {
             get; set;
         }

src/GitHub.Exports/Services/GitService.cs

@@ -42,11 +42,11 @@ public LocalRepositoryModel CreateLocalRepositoryModel(string localPath)
             using (var repository = GetRepository(localPath))
             {
                 UriString cloneUrl = null;
-                bool noRemoteOrigin = false;
+                bool noOrigin = false;
                 if (repository != null)
                 {
                     cloneUrl = GetUri(repository);
-                    noRemoteOrigin = HasNoRemoteOrigin(repository);
+                    noOrigin = HasRemotesButNoOrigin(repository);
                 }
 
                 var name = cloneUrl?.RepositoryName ?? dir.Name;
@@ -55,7 +55,7 @@ public LocalRepositoryModel CreateLocalRepositoryModel(string localPath)
                 {
                     LocalPath = localPath,
                     CloneUrl = cloneUrl,
-                    HasNoRemoteOrigin = noRemoteOrigin,
+                    HasRemotesButNoOrigin = noOrigin,
                     Name = name,
                     Icon = Octicon.repo
                 };
@@ -137,7 +137,7 @@ public IRepository GetRepository(string path)
         /// </summary>
         /// <param name="repo">The target repository.</param>
         /// <returns>True if repository has remotes but none are called "origin".</returns>
-        public bool HasNoRemoteOrigin(IRepository repo)
+        public bool HasRemotesButNoOrigin(IRepository repo)
         {
             var remotes = repo.Network.Remotes;
             return remotes["origin"] == null && remotes.Any();

src/GitHub.InlineReviews/Services/PullRequestStatusBarManager.cs

@@ -86,7 +86,7 @@ public void StartShowingStatus()
 
         async Task RefreshCurrentSession(LocalRepositoryModel repository, IPullRequestSession session)
         {
-            if (repository.HasNoRemoteOrigin)
+            if (repository.HasRemotesButNoOrigin)
             {
                 NoRemoteOriginCallout();
             }

test/GitHub.Exports.UnitTests/GitServiceIntegrationTests.cs

@@ -38,7 +38,7 @@ public void No_Directory()
         [TestCase("origin", "https://github.com/github/VisualStudio", false)]
         [TestCase("not_origin", "https://github.com/github/VisualStudio", true)]
         [TestCase(null, null, false, Description = "Has no remotes")]
-        public void Check_HasNoRemoteOrigin(string remoteName, string remoteUrl, bool hasNoRemoteOrigin)
+        public void Check_HasRemotesButNoOrigin(string remoteName, string remoteUrl, bool noOrigin)
         {
             using (var temp = new TempRepository())
             {
@@ -51,7 +51,7 @@ public void Check_HasNoRemoteOrigin(string remoteName, string remoteUrl, bool ha
 
                 var model = target.CreateLocalRepositoryModel(path);
 
-                Assert.That(model.HasNoRemoteOrigin, Is.EqualTo(hasNoRemoteOrigin));
+                Assert.That(model.HasRemotesButNoOrigin, Is.EqualTo(noOrigin));
             }
         }