Fix errors where void return type

Author: Meaghan Lewis

test/UnitTests/GitHub.App/Services/PullRequestServiceTests.cs

@@ -291,7 +291,7 @@ public async Task ExtractBase_MergeBaseAvailable_UseMergeBaseSha()
         }
 
         [Test]
-        public async void MergeBaseNotAvailable_ThrowsNotFoundException()
+        public async Task MergeBaseNotAvailable_ThrowsNotFoundException()
         {
             var baseFileContent = "baseFileContent";
             var headFileContent = "headFileContent";
@@ -497,7 +497,7 @@ public void CreatePullRequestAllArgsMandatory()
     public class TheCheckoutMethod
     {
         [Test]
-        public async void ShouldCheckoutExistingBranch()
+        public async Task ShouldCheckoutExistingBranch()
         {
             var gitClient = MockGitClient();
             var service = new PullRequestService(
@@ -520,7 +520,7 @@ public async void ShouldCheckoutExistingBranch()
         }
 
         [Test]
-        public async void ShouldCheckoutLocalBranch()
+        public async Task ShouldCheckoutLocalBranch()
         {
             var gitClient = MockGitClient();
             var service = new PullRequestService(
@@ -547,7 +547,7 @@ public async void ShouldCheckoutLocalBranch()
         }
 
         [Test]
-        public async void ShouldCheckoutBranchFromFork()
+        public async Task ShouldCheckoutBranchFromFork()
         {
             var gitClient = MockGitClient();
             var service = new PullRequestService(
@@ -577,7 +577,7 @@ public async void ShouldCheckoutBranchFromFork()
         }
 
         [Test]
-        public async void ShouldUseUniquelyNamedRemoteForFork()
+        public async Task ShouldUseUniquelyNamedRemoteForFork()
         {
             var gitClient = MockGitClient();
             var gitService = MockGitService();

test/UnitTests/GitHub.App/ViewModels/Dialog/RepositoryCreationViewModelTests.cs

@@ -361,7 +361,7 @@ public void IsPopulatedByTheRepositoryHost()
     public class TheGitIgnoreTemplatesProperty : TestBaseClass
     {
         [Test]
-        public async void IsPopulatedByTheApiAndSortedWithRecommendedFirst()
+        public async Task IsPopulatedByTheApiAndSortedWithRecommendedFirst()
         {
             var gitIgnoreTemplates = new[]
             {
@@ -399,7 +399,7 @@ public async void IsPopulatedByTheApiAndSortedWithRecommendedFirst()
     public class TheLicensesProperty : TestBaseClass
     {
         [Test]
-        public async void IsPopulatedByTheModelService()
+        public async Task IsPopulatedByTheModelService()
         {
             var licenses = new[]
             {
@@ -439,7 +439,7 @@ public async void IsPopulatedByTheModelService()
     public class TheSelectedGitIgnoreProperty : TestBaseClass
     {
         [Test]
-        public async void DefaultsToVisualStudio()
+        public async Task DefaultsToVisualStudio()
         {
             var gitignores = new[]
             {

test/UnitTests/GitHub.Exports/LocalRepositoryModelTests.cs

@@ -67,7 +67,7 @@ static void SetupRepository(string sha)
     [TestCase(22, LinkType.Blame, true, "[email protected]/foo/bar", "123123", @"src\dir\ThisIsFile1.cs", -1, -1, "https://github.com/foo/bar/blame/123123/src/dir/ThisIsFile1.cs")]
     [TestCase(23, LinkType.Blame, true, "https://github.com/foo/bar", "123123", @"src\dir\file1.cs", -1, -1, "https://github.com/foo/bar/blame/123123/src/dir/file1.cs")]
     [TestCase(24, LinkType.Blame, false, "https://github.com/foo/bar", "123123", "", 1, 2, "https://github.com/foo/bar/commit/123123")]
-    public async void GenerateUrl(int testid, LinkType linkType, bool createRootedPath, string baseUrl, string sha, string path, int startLine, int endLine, string expected)
+    public async Task GenerateUrl(int testid, LinkType linkType, bool createRootedPath, string baseUrl, string sha, string path, int startLine, int endLine, string expected)
     {
         using (var temp = new TempDirectory())
         {