Implement posting PR comments.

Author: grokys

src/GitHub.App/SampleData/Documents/PullRequestPageViewModelDesigner.cs

@@ -84,6 +84,7 @@ Depends on #1993
             };
         }
 
+        public string Id { get; set; }
         public PullRequestState State { get; set; } = PullRequestState.Open;
         public IReadOnlyList<IViewModel> Timeline { get; }
         public string SourceBranchDisplayName { get; set; } = "feature/save-drafts";

src/GitHub.App/Services/IssueishService.cs

@@ -0,0 +1,61 @@
+using System;
+using System.Collections.Generic;
+using System.Threading.Tasks;
+using GitHub.Api;
+using GitHub.Models;
+using GitHub.Primitives;
+using Octokit.GraphQL;
+using Octokit.GraphQL.Model;
+using static Octokit.GraphQL.Variable;
+
+namespace GitHub.Services
+{
+    public abstract class IssueishService : IIssueishService
+    {
+        static ICompiledQuery<CommentModel> postComment;
+        readonly IGraphQLClientFactory graphqlFactory;
+
+        public IssueishService(IGraphQLClientFactory graphqlFactory)
+        {
+            this.graphqlFactory = graphqlFactory;
+        }
+
+        public async Task<CommentModel> PostComment(HostAddress address, string issueishId, string body)
+        {
+            var input = new AddCommentInput
+            {
+                Body = body,
+                SubjectId = new ID(issueishId),
+            };
+
+            if (postComment == null)
+            {
+                postComment = new Mutation()
+                    .AddComment(Var(nameof(input)))
+                    .CommentEdge
+                    .Node
+                    .Select(comment => new CommentModel
+                    {
+                        Author = new ActorModel
+                        {
+                            Login = comment.Author.Login,
+                            AvatarUrl = comment.Author.AvatarUrl(null),
+                        },
+                        Body = comment.Body,
+                        CreatedAt = comment.CreatedAt,
+                        DatabaseId = comment.DatabaseId.Value,
+                        Id = comment.Id.Value,
+                        Url = comment.Url,
+                    }).Compile();
+            }
+
+            var vars = new Dictionary<string, object>
+            {
+                { nameof(input), input },
+            };
+
+            var graphql = await graphqlFactory.CreateConnection(address).ConfigureAwait(false);
+            return await graphql.Run(postComment, vars).ConfigureAwait(false);
+        }
+    }
+}

src/GitHub.App/Services/PullRequestService.cs

@@ -32,7 +32,7 @@ namespace GitHub.Services
 {
     [Export(typeof(IPullRequestService))]
     [PartCreationPolicy(CreationPolicy.Shared)]
-    public class PullRequestService : IPullRequestService
+    public class PullRequestService : IssueishService, IPullRequestService
     {
         const string SettingCreatedByGHfVS = "created-by-ghfvs";
         const string SettingGHfVSPullRequest = "ghfvs-pr-owner-number";
@@ -66,6 +66,7 @@ public PullRequestService(
             IGraphQLClientFactory graphqlFactory,
             IOperatingSystem os,
             IUsageTracker usageTracker)
+            : base(graphqlFactory)
         {
             this.gitClient = gitClient;
             this.gitService = gitService;

src/GitHub.App/ViewModels/Documents/PullRequestPageViewModel.cs

@@ -6,7 +6,7 @@
 using GitHub.Extensions;
 using GitHub.Factories;
 using GitHub.Models;
-using GitHub.SampleData;
+using GitHub.Primitives;
 using GitHub.Services;
 using ReactiveUI;
 
@@ -23,6 +23,8 @@ public class PullRequestPageViewModel : PullRequestViewModelBase, IPullRequestPa
         readonly IPullRequestService service;
         readonly IPullRequestSessionManager sessionManager;
         readonly ITeamExplorerServices teServices;
+        ActorModel currentUserModel;
+        ReactiveList<IViewModel> timeline;
 
         /// <summary>
         /// Initializes a new instance of the <see cref="PullRequestPageViewModel"/> class.
@@ -52,7 +54,7 @@ public PullRequestPageViewModel(
         public IActorViewModel CurrentUser { get; private set; }
 
         /// <inheritdoc/>
-        public IReadOnlyList<IViewModel> Timeline { get; private set; }
+        public IReadOnlyList<IViewModel> Timeline => timeline;
 
         /// <inheritdoc/>
         public ReactiveCommand<string, Unit> ShowCommit { get; }
@@ -69,9 +71,10 @@ public async Task InitializeAsync(
         {
             await base.InitializeAsync(repository, localRepository, model).ConfigureAwait(true);
 
+            currentUserModel = currentUser;
             CurrentUser = new ActorViewModel(currentUser);
+            timeline = new ReactiveList<IViewModel>();
 
-            var timeline = new ReactiveList<IViewModel>();
             var commits = new List<CommitSummaryViewModel>();
 
             foreach (var i in model.Timeline)
@@ -88,11 +91,7 @@ public async Task InitializeAsync(
                         commits.Add(new CommitSummaryViewModel(commit));
                         break;
                     case CommentModel comment:
-                        {
-                            var vm = factory.CreateViewModel<IIssueishCommentViewModel>();
-                            await vm.InitializeAsync(this, currentUser, comment, null).ConfigureAwait(true);
-                            timeline.Add(vm);
-                        }
+                        await AddComment(comment).ConfigureAwait(true);
                         break;
                 }
             }
@@ -109,8 +108,15 @@ await placeholder.InitializeAsync(
                 null,
                 Resources.ClosePullRequest).ConfigureAwait(true);
             timeline.Add(placeholder);
+        }
 
-            Timeline = timeline;
+        /// <inheritdoc/>
+        public async Task PostComment(string body)
+        {
+            var address = HostAddress.Create(Repository.CloneUrl);
+            var comment = await service.PostComment(address, Id, body).ConfigureAwait(true);
+            await AddComment(comment).ConfigureAwait(true);
+            ClearPlaceholder();
         }
 
         Task ICommentThreadViewModel.DeleteComment(int pullRequestId, int commentId)
@@ -123,9 +129,41 @@ Task ICommentThreadViewModel.EditComment(string id, string body)
             throw new NotImplementedException();
         }
 
-        Task ICommentThreadViewModel.PostComment(string body)
+        async Task AddComment(CommentModel comment)
         {
-            throw new NotImplementedException();
+            var vm = factory.CreateViewModel<IIssueishCommentViewModel>();
+            await vm.InitializeAsync(this, currentUserModel, comment, null).ConfigureAwait(true);
+
+            if (GetPlaceholder() == null)
+            {
+                timeline.Add(vm);
+            }
+            else
+            {
+                timeline.Insert(timeline.Count - 1, vm);
+            }
+        }
+
+        void ClearPlaceholder()
+        {
+            var placeholder = GetPlaceholder();
+
+            if (placeholder != null)
+            {
+                placeholder.Body = null;
+            }
+        }
+
+        ICommentViewModel GetPlaceholder()
+        {
+            if (timeline.Count > 0 &&
+                timeline[timeline.Count - 1] is ICommentViewModel comment &&
+                comment.Id == null)
+            {
+                return comment;
+            }
+
+            return null;
         }
 
         async Task DoShowCommit(string oid)

src/GitHub.App/ViewModels/GitHubPane/PullRequestUserReviewsViewModel.cs

@@ -144,7 +144,6 @@ async Task Load(PullRequestDetailModel pullRequest)
 
             try
             {
-                await Task.Delay(0);
                 PullRequestTitle = pullRequest.Title;
 
                 var reviews = new List<IPullRequestReviewViewModel>();

src/GitHub.App/ViewModels/IssueishViewModel.cs

@@ -32,6 +32,9 @@ public IssueishViewModel()
         /// <inheritdoc/>
         public IRemoteRepositoryModel Repository { get; private set; }
 
+        /// <inheritdoc/>
+        public string Id { get; private set; }
+
         /// <inheritdoc/>
         public int Number { get; private set; }
 
@@ -71,6 +74,7 @@ protected Task InitializeAsync(
             IssueishDetailModel model)
         {
             Repository = repository;
+            Id = model.Id;
             Author = new ActorViewModel(model.Author);
             Body = model.Body;
             Number = model.Number;

src/GitHub.Exports.Reactive/Services/IIssueishService.cs

@@ -0,0 +1,25 @@
+using System;
+using System.Threading.Tasks;
+using GitHub.Models;
+using GitHub.Primitives;
+
+namespace GitHub.Services
+{
+    /// <summary>
+    /// Services for issues and pull requests.
+    /// </summary>
+    public interface IIssueishService
+    {
+        /// <summary>
+        /// Posts an issue or pull request comment.
+        /// </summary>
+        /// <param name="address">The address of the server.</param>
+        /// <param name="issueishId">The GraphQL ID of the issue or pull request.</param>
+        /// <param name="body">The comment body.</param>
+        /// <returns>The model for the comment that was added.</returns>
+        Task<CommentModel> PostComment(
+            HostAddress address,
+            string issueishId,
+            string body);
+    }
+}

src/GitHub.Exports.Reactive/Services/IPullRequestService.cs

@@ -9,7 +9,7 @@
 
 namespace GitHub.Services
 {
-    public interface IPullRequestService
+    public interface IPullRequestService : IIssueishService
     {
         /// <summary>
         /// Reads a page of pull request items.

src/GitHub.Exports.Reactive/ViewModels/IIssueishViewModel.cs

@@ -10,6 +10,11 @@ namespace GitHub.ViewModels
     /// </summary>
     public interface IIssueishViewModel : IViewModel
     {
+        /// <summary>
+        /// Gets the GraphQL ID for the issue or pull request.
+        /// </summary>
+        string Id { get; }
+
         /// <summary>
         /// Gets the issue or pull request author.
         /// </summary>

src/GitHub.InlineReviews/Services/PullRequestSession.cs

@@ -304,7 +304,6 @@ async Task AddComment(PullRequestReviewCommentModel comment)
 
         async Task UpdateFile(PullRequestSessionFile file)
         {
-            await Task.Delay(0);
             var mergeBaseSha = await GetMergeBase();
             file.BaseSha = PullRequest.BaseRefSha;
             file.CommitSha = file.IsTrackingHead ? PullRequest.HeadRefSha : file.CommitSha;