ReadParentOwnerLogin -> FindParent.

Make the method to find the parent repository return the repository name and owner. We don't actually use the `name` yet, and assume that forks have the same name as the parent repository. This is usually the case but not always. `UriString` doesn't support getting a new URL with a different name as well as owner so want to do that in a separate PR.

Author: grokys

src/GitHub.App/GitHub.App.csproj

@@ -194,6 +194,9 @@
       <HintPath>..\..\packages\Rx-XAML.2.2.5-custom\lib\net45\System.Reactive.Windows.Threading.dll</HintPath>
       <Private>True</Private>
     </Reference>
+    <Reference Include="System.ValueTuple, Version=4.0.3.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51, processorArchitecture=MSIL">
+      <HintPath>..\..\packages\System.ValueTuple.4.5.0\lib\net461\System.ValueTuple.dll</HintPath>
+    </Reference>
     <Reference Include="System.Web" />
     <Reference Include="System.Xaml" />
     <Reference Include="System.Xml.Linq" />

src/GitHub.App/Services/RepositoryService.cs

@@ -14,7 +14,7 @@ namespace GitHub.Services
     [PartCreationPolicy(CreationPolicy.Shared)]
     public class RepositoryService : IRepositoryService
     {
-        static ICompiledQuery<string> readParentOwnerLogin;
+        static ICompiledQuery<Tuple<string, string>> readParentOwnerLogin;
         readonly IGraphQLClientFactory graphqlFactory;
 
         [ImportingConstructor]
@@ -25,7 +25,7 @@ public RepositoryService(IGraphQLClientFactory graphqlFactory)
             this.graphqlFactory = graphqlFactory;
         }
 
-        public async Task<string> ReadParentOwnerLogin(HostAddress address, string owner, string name)
+        public async Task<(string owner, string name)?> FindParent(HostAddress address, string owner, string name)
         {
             Guard.ArgumentNotNull(address, nameof(address));
             Guard.ArgumentNotEmptyString(owner, nameof(owner));
@@ -35,7 +35,7 @@ public async Task<string> ReadParentOwnerLogin(HostAddress address, string owner
             {
                 readParentOwnerLogin = new Query()
                     .Repository(Var(nameof(owner)), Var(nameof(name)))
-                    .Select(r => r.Parent != null ? r.Parent.Owner.Login : null)
+                    .Select(r => r.Parent != null ? Tuple.Create(r.Parent.Owner.Login, r.Parent.Name) : null)
                     .Compile();
             }
 
@@ -46,7 +46,8 @@ public async Task<string> ReadParentOwnerLogin(HostAddress address, string owner
             };
 
             var graphql = await graphqlFactory.CreateConnection(address);
-            return await graphql.Run(readParentOwnerLogin, vars);
+            var result = await graphql.Run(readParentOwnerLogin, vars);
+            return result != null ? (result.Item1, result.Item2) : ((string, string)?)null;
         }
     }
 }

src/GitHub.App/ViewModels/GitHubPane/IssueListViewModelBase.cs

@@ -127,20 +127,21 @@ public async Task InitializeAsync(ILocalRepositoryModel repository, IConnection
             SelectedState = States.FirstOrDefault();
             AuthorFilter = new UserFilterViewModel(LoadAuthors);
 
-            var parentOwner = await repositoryService.ReadParentOwnerLogin(
+            var parent = await repositoryService.FindParent(
                 HostAddress.Create(repository.CloneUrl),
                 repository.Owner,
                 repository.Name);
 
-            if (parentOwner == null)
+            if (parent == null)
             {
                 RemoteRepository = repository;
             }
             else
             {
+                // TODO: Handle forks with different names.
                 RemoteRepository = new RepositoryModel(
                     repository.Name,
-                    UriString.ToUriString(repository.CloneUrl.ToRepositoryUrl(parentOwner)));
+                    UriString.ToUriString(repository.CloneUrl.ToRepositoryUrl(parent.Value.owner)));
 
                 Forks = new IRepositoryModel[]
                 {

src/GitHub.App/packages.config

@@ -33,4 +33,5 @@
   <package id="SerilogAnalyzer" version="0.12.0.0" targetFramework="net461" />
   <package id="SQLitePCL.raw_basic" version="0.7.3.0-vs2012" targetFramework="net45" />
   <package id="Stateless" version="2.5.56.0" targetFramework="net45" />
+  <package id="System.ValueTuple" version="4.5.0" targetFramework="net461" />
 </packages>

src/GitHub.Exports/GitHub.Exports.csproj

@@ -135,6 +135,9 @@
     <Reference Include="System.Management" />
     <Reference Include="System.Management.Instrumentation" />
     <Reference Include="System.Net.Http" />
+    <Reference Include="System.ValueTuple, Version=4.0.3.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51, processorArchitecture=MSIL">
+      <HintPath>..\..\packages\System.ValueTuple.4.5.0\lib\net461\System.ValueTuple.dll</HintPath>
+    </Reference>
     <Reference Include="System.Xaml" />
     <Reference Include="System.Xml.Linq" />
     <Reference Include="System.Data.DataSetExtensions" />

src/GitHub.Exports/Services/IRepositoryService.cs

@@ -6,9 +6,16 @@ namespace GitHub.Services
 {
     public interface IRepositoryService
     {
-        Task<string> ReadParentOwnerLogin(
-            HostAddress address,
-            string owner,
-            string name);
+        /// <summary>
+        /// Finds the parent repository of a fork, if any.
+        /// </summary>
+        /// <param name="address">The host address.</param>
+        /// <param name="owner">The repository owner.</param>
+        /// <param name="name">The repository name.</param>
+        /// <returns>
+        /// A tuple of the parent repository's owner and name if the repository is a fork,
+        /// otherwise null.
+        /// </returns>
+        Task<(string owner, string name)?> FindParent(HostAddress address, string owner, string name);
     }
 }

src/GitHub.Exports/packages.config

@@ -20,5 +20,6 @@
   <package id="Serilog" version="2.5.0" targetFramework="net461" />
   <package id="SerilogAnalyzer" version="0.12.0.0" targetFramework="net461" />
   <package id="SimpleJson" version="0.38.0" targetFramework="net461" />
+  <package id="System.ValueTuple" version="4.5.0" targetFramework="net461" />
   <package id="VSSDK.IDE.12" version="12.0.4" targetFramework="net461" />
 </packages>