Try to update UsageTracker on clone.

For some reason the UsageTracker isn't being found by MEF though.

Author: grokys

src/GitHub.App/Services/UsageTracker.cs

@@ -15,7 +15,7 @@
 using ReactiveUI;
 using Rothko;
 
-namespace GitHub.App.Services
+namespace GitHub.Services
 {
     using Guard = GitHub.Extensions.Guard;
 

src/GitHub.App/ViewModels/RepositoryCloneViewModel.cs

@@ -29,6 +29,7 @@ public class RepositoryCloneViewModel : BaseViewModel, IRepositoryCloneViewModel
         readonly IRepositoryCloneService cloneService;
         readonly IOperatingSystem operatingSystem;
         readonly INotificationService notificationService;
+        readonly IUsageTracker usageTracker;
         readonly IReactiveCommand<IReadOnlyList<IRepositoryModel>> loadRepositoriesCommand;
         readonly ReactiveCommand<object> browseForDirectoryCommand = ReactiveCommand.Create();
         readonly ObservableAsPropertyHelper<bool> isLoading;
@@ -42,20 +43,23 @@ public class RepositoryCloneViewModel : BaseViewModel, IRepositoryCloneViewModel
             IConnectionRepositoryHostMap connectionRepositoryHostMap,
             IRepositoryCloneService repositoryCloneService,
             IOperatingSystem operatingSystem,
-            INotificationService notificationService)
-            : this(connectionRepositoryHostMap.CurrentRepositoryHost, repositoryCloneService, operatingSystem, notificationService)
+            INotificationService notificationService,
+            IUsageTracker usageTracker)
+            : this(connectionRepositoryHostMap.CurrentRepositoryHost, repositoryCloneService, operatingSystem, notificationService, usageTracker)
         { }
 
         public RepositoryCloneViewModel(
             IRepositoryHost repositoryHost,
             IRepositoryCloneService cloneService,
             IOperatingSystem operatingSystem,
-            INotificationService notificationService)
+            INotificationService notificationService,
+            IUsageTracker usageTracker)
         {
             this.repositoryHost = repositoryHost;
             this.cloneService = cloneService;
             this.operatingSystem = operatingSystem;
             this.notificationService = notificationService;
+            this.usageTracker = usageTracker;
 
             Title = string.Format(CultureInfo.CurrentCulture, Resources.CloneTitle, repositoryHost.Title);
             Repositories = new ReactiveList<IRepositoryModel>();
@@ -126,8 +130,13 @@ IObservable<Unit> OnCloneRepository(object state)
                     notificationService.ShowError(Resources.RepositoryCloneFailedNoSelectedRepo);
                     return Observable.Return(Unit.Default);
                 }
+                
                 // The following is a noop if the directory already exists.
                 operatingSystem.Directory.CreateDirectory(BaseRepositoryPath);
+
+                // Are we OK doing this here or should we be doing it after the clone succeeds.
+                this.usageTracker.IncrementCloneCount();
+
                 return cloneService.CloneRepository(repository.CloneUrl, repository.Name, BaseRepositoryPath);
             })
             .SelectMany(_ => _)

src/UnitTests/GitHub.App/ViewModels/RepositoryCloneViewModelTests.cs

@@ -30,7 +30,8 @@ public async Task LoadsRepositories()
                 repositoryHost,
                 cloneService,
                 Substitute.For<IOperatingSystem>(),
-                Substitute.For<INotificationService>());
+                Substitute.For<INotificationService>(),
+                Substitute.For<IUsageTracker>());
 
             await vm.LoadRepositoriesCommand.ExecuteAsync();
 
@@ -51,7 +52,8 @@ public void StartsTrueBecomesFalseWhenCompleted()
                 repositoryHost,
                 cloneService,
                 Substitute.For<IOperatingSystem>(),
-                Substitute.For<INotificationService>());
+                Substitute.For<INotificationService>(),
+                Substitute.For<IUsageTracker>());
 
             Assert.False(vm.IsLoading);
 
@@ -80,7 +82,8 @@ public void IsFalseWhenLoadingReposFailsImmediately()
                 repositoryHost,
                 cloneService,
                 Substitute.For<IOperatingSystem>(),
-                Substitute.For<INotificationService>());
+                Substitute.For<INotificationService>(),
+                Substitute.For<IUsageTracker>());
 
             vm.LoadRepositoriesCommand.ExecuteAsync().Subscribe();
 
@@ -103,7 +106,8 @@ public void IsTrueInitially()
                 repositoryHost,
                 cloneService,
                 Substitute.For<IOperatingSystem>(),
-                Substitute.For<INotificationService>());
+                Substitute.For<INotificationService>(),
+                Substitute.For<IUsageTracker>());
 
             Assert.True(vm.NoRepositoriesFound);
         }
@@ -119,7 +123,8 @@ public void IsFalseWhenLoadingAndCompletedWithRepository()
                 repositoryHost,
                 cloneService,
                 Substitute.For<IOperatingSystem>(),
-                Substitute.For<INotificationService>());
+                Substitute.For<INotificationService>(),
+                Substitute.For<IUsageTracker>());
             vm.LoadRepositoriesCommand.ExecuteAsync().Subscribe();
 
             repoSubject.OnNext(new[] { Substitute.For<IRepositoryModel>() });
@@ -143,7 +148,8 @@ public void IsFalseWhenFailed()
                 repositoryHost,
                 cloneService,
                 Substitute.For<IOperatingSystem>(),
-                Substitute.For<INotificationService>());
+                Substitute.For<INotificationService>(),
+                Substitute.For<IUsageTracker>());
             vm.LoadRepositoriesCommand.ExecuteAsync().Subscribe();
 
             repoSubject.OnError(new InvalidOperationException());
@@ -162,7 +168,8 @@ public void IsTrueWhenLoadingCompleteNotFailedAndNoRepositories()
                 repositoryHost,
                 cloneService,
                 Substitute.For<IOperatingSystem>(),
-                Substitute.For<INotificationService>());
+                Substitute.For<INotificationService>(),
+                Substitute.For<IUsageTracker>());
             vm.LoadRepositoriesCommand.ExecuteAsync().Subscribe();
 
             repoSubject.OnCompleted();
@@ -184,7 +191,8 @@ public void IsTrueIfLoadingReposFails()
                 repositoryHost,
                 cloneService,
                 Substitute.For<IOperatingSystem>(),
-                Substitute.For<INotificationService>());
+                Substitute.For<INotificationService>(),
+                Substitute.For<IUsageTracker>());
             vm.LoadRepositoriesCommand.ExecuteAsync().Subscribe();
 
             Assert.False(vm.LoadingFailed);
@@ -207,7 +215,8 @@ public void IsEnabledWhenRepositorySelectedAndPathValid()
                 repositoryHost,
                 cloneService,
                 Substitute.For<IOperatingSystem>(),
-                Substitute.For<INotificationService>());
+                Substitute.For<INotificationService>(),
+                Substitute.For<IUsageTracker>());
             Assert.False(vm.CloneCommand.CanExecute(null));
 
             vm.BaseRepositoryPath = @"c:\fake\path";
@@ -225,7 +234,8 @@ public void IsNotEnabledWhenPathIsNotValid()
                 repositoryHost,
                 cloneService,
                 Substitute.For<IOperatingSystem>(),
-                Substitute.For<INotificationService>());
+                Substitute.For<INotificationService>(),
+                Substitute.For<IUsageTracker>());
             vm.BaseRepositoryPath = @"c:|fake\path";
             Assert.False(vm.CloneCommand.CanExecute(null));
 
@@ -246,7 +256,8 @@ public async Task DisplaysErrorMessageWhenExceptionOccurs()
                 repositoryHost,
                 cloneService,
                 Substitute.For<IOperatingSystem>(),
-                notificationService);
+                notificationService,
+                Substitute.For<IUsageTracker>());
             vm.BaseRepositoryPath = @"c:\fake";
             var repository = Substitute.For<IRepositoryModel>();
             repository.Name.Returns("octokit");
@@ -257,5 +268,24 @@ public async Task DisplaysErrorMessageWhenExceptionOccurs()
             notificationService.Received().ShowError(@"Failed to clone the repository 'octokit'
 Email [email protected] if you continue to have problems.");
         }
+
+        [Fact]
+        public async Task UpdatesMetricsWhenRepositoryCloned()
+        {
+            var repositoryHost = Substitute.For<IRepositoryHost>();
+            var cloneService = Substitute.For<IRepositoryCloneService>();
+            var usageTracker = Substitute.For<IUsageTracker>();
+            var vm = new RepositoryCloneViewModel(
+                repositoryHost,
+                cloneService,
+                Substitute.For<IOperatingSystem>(),
+                Substitute.For<INotificationService>(),
+                usageTracker);
+            
+            vm.SelectedRepository = Substitute.For<IRepositoryModel>();
+            await vm.CloneCommand.ExecuteAsync();
+
+            usageTracker.Received().IncrementCloneCount();
+        }
     }
 }