Code review changes:

* Remove InternalsVisibleTo, make PkgCmdIDList public for UnitTests to be able to use it.
* Remove explicit "private" access modifiers.
* Remove #regions.
* Follow lambda convention.
* Remove TODO comment that didn't totally make sense.

Author: OlsonAndrewD

src/GitHub.VisualStudio/PkgCmdID.cs

@@ -2,7 +2,7 @@
 // MUST match PkgCmdID.h
 namespace GitHub.VisualStudio
 {
-    static class PkgCmdIDList
+    public static class PkgCmdIDList
     {
         public const int addConnectionCommand = 0x110;
         public const int idGitHubToolbar = 0x1120;

src/GitHub.VisualStudio/Properties/AssemblyInfo.cs

@@ -1,8 +1,6 @@
 using System.Reflection;
-using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 
 [assembly: AssemblyTitle("GitHub.VisualStudio")]
 [assembly: AssemblyDescription("GitHub for Visual Studio VSPackage")]
 [assembly: Guid("fad77eaa-3fe1-4c4b-88dc-3753b6263cd7")]
-[assembly: InternalsVisibleTo("UnitTests")]

src/UnitTests/GitHub.VisualStudio/UI/Views/GitHubPaneViewModelTests.cs

@@ -19,27 +19,25 @@
 
 public class GitHubPaneViewModelTests : TestBaseClass
 {
-    private readonly IServiceProvider serviceProvider;
-    private readonly IUIController uiController;
-    private readonly FakeMenuCommandService menuCommandService;
-    private readonly GitHubPaneViewModel viewModel;
-    private UIViewType lastUiControllerJump;
+    readonly IServiceProvider serviceProvider;
+    readonly IUIController uiController;
+    readonly FakeMenuCommandService menuCommandService;
+    readonly GitHubPaneViewModel viewModel;
+    UIViewType lastUiControllerJump;
 
     public GitHubPaneViewModelTests()
     {
-        #region Start tests already logged in with an active repo.
-
         var repositoryHosts = Substitutes.RepositoryHosts;
         repositoryHosts.IsLoggedInToAnyHost.Returns(true);
 
         var teamExplorerServiceHolder = Substitute.For<ITeamExplorerServiceHolder>();
         var activeRepo = Substitute.For<ILocalRepositoryModel>();
         activeRepo.CloneUrl.Returns(new UriString("https://github.com/foo/foo"));
         teamExplorerServiceHolder
-            .When(_ => _.Subscribe(Arg.Any<object>(), Arg.Any<Action<ILocalRepositoryModel>>()))
-            .Do(_ =>
+            .When(x => x.Subscribe(Arg.Any<object>(), Arg.Any<Action<ILocalRepositoryModel>>()))
+            .Do(x =>
             {
-                var invokeAction = _.Arg<Action<ILocalRepositoryModel>>();
+                var invokeAction = x.Arg<Action<ILocalRepositoryModel>>();
                 invokeAction(activeRepo);
             });
 
@@ -56,26 +54,19 @@ public GitHubPaneViewModelTests()
         host.IsLoggedIn.Returns(true);
         repositoryHosts.LookupHost(connectionHostAddress).Returns(host);
 
-        #endregion
-
-        #region Wire up service/UI provider.
-
         serviceProvider = Substitutes.GetFullyMockedServiceProvider();
         menuCommandService = new FakeMenuCommandService();
         serviceProvider.GetService(typeof(IMenuCommandService)).Returns(menuCommandService);
 
-        // TODO: Maybe could avoid cast by making a new interface that inherits IServiceProvider and IUIProvider
         var uiProvider = serviceProvider as IUIProvider;
         uiProvider.TryGetService(typeof(IUIProvider)).Returns(serviceProvider);
 
-        #endregion
-
         uiController = Substitute.For<IUIController>();
         uiController.CurrentFlow.Returns(UIControllerFlow.PullRequests);
         uiController.SelectedFlow.Returns(UIControllerFlow.PullRequests);
         uiController
-            .When(_ => _.Jump(Arg.Any<ViewWithData>()))
-            .Do(_ => lastUiControllerJump = _.Arg<ViewWithData>().ViewType);
+            .When(x => x.Jump(Arg.Any<ViewWithData>()))
+            .Do(x => lastUiControllerJump = x.Arg<ViewWithData>().ViewType);
 
         var exportFactoryProvider = Substitutes.ExportFactoryProvider;
         uiProvider.TryGetService(typeof(IExportFactoryProvider)).Returns(exportFactoryProvider);
@@ -112,10 +103,10 @@ public void ListRefreshKeepsListVisible_DoesNotSwitchToPRCreation()
     private void RunSteps(IEnumerable<NavStep> steps)
     {
         var observableSteps = steps
-            .Select(_ => new LoadData
+            .Select(x => new LoadData
             {
-                Direction = _.Direction,
-                Data = new ViewWithData() { ViewType = _.ViewType },
+                Direction = x.Direction,
+                Data = new ViewWithData() { ViewType = x.ViewType },
                 View = Substitute.For<IView>()
             })
             .ToObservable();