Corrected logic for filterTextEnabled observable.

Author: Dan Walmsley

src/GitHub.App/ViewModels/RepositoryCloneViewModel.cs

@@ -75,13 +75,12 @@ public RepositoryCloneViewModel(
             repositories.Filter = FilterRepository;
             repositories.NewerComparer = OrderedComparer<IRemoteRepositoryModel>.OrderByDescending(x => x.UpdatedAt).Compare;
 
-            filterTextIsEnabled = this.WhenAny(x => x.IsLoading, x => x.LoadingFailed, 
-                (loading, loadingFailed) => !loadingFailed.Value)
-                .Select(x => x || repositories.UnfilteredCount > 0)
-                .ToProperty(this, x => x.FilterTextIsEnabled, initialValue: true);
+            filterTextIsEnabled = this.WhenAny(x => x.IsLoading,
+                (loading) => loading.Value || repositories.UnfilteredCount > 0 && !LoadingFailed)
+                .ToProperty(this, x => x.FilterTextIsEnabled);
 
-            this.WhenAny(x => x.FilterTextIsEnabled, x => x.IsLoading, x => x.LoadingFailed,
-                (any, loading, failed) => !loading.Value && !failed.Value && repositories.UnfilteredCount == 0)
+            this.WhenAny(x => x.IsLoading, x => x.LoadingFailed,
+                (loading, failed) => !loading.Value && !failed.Value && repositories.UnfilteredCount == 0)
                 .Subscribe(x => NoRepositoriesFound = x);
 
             this.WhenAny(x => x.FilterText, x => x.Value)