Merge pull request #2074 from github/donokuda/update-check-icon

WIP: Prefer text instead of icon in checks list

Author: StanleyGoldman

src/GitHub.VisualStudio.UI/Views/GitHubPane/PullRequestCheckView.xaml

@@ -24,12 +24,10 @@
 
     <Grid>
         <Grid.ColumnDefinitions>
-            <ColumnDefinition Width="Auto" SharedSizeGroup="ColumnZero" />
-            <ColumnDefinition Width="*" SharedSizeGroup="ColumnOne" />
-            <ColumnDefinition Width="Auto" SharedSizeGroup="ColumnTwo" />
+            <ColumnDefinition Width="Auto"/>
             <ColumnDefinition Width="*"/>
-            <ColumnDefinition Width="Auto" SharedSizeGroup="ColumnFour" />
-            <ColumnDefinition MinWidth="50" Width="Auto" SharedSizeGroup="ColumnFive" />
+            <ColumnDefinition Width="Auto"/>
+            <ColumnDefinition Width="Auto"/>
         </Grid.ColumnDefinitions>
 
         <Grid.RowDefinitions>
@@ -40,22 +38,19 @@
         <ghfvs:OcticonImage Grid.Column="0" Margin="0 0 4 0" Icon="x" Foreground="#cb2431" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Failure}}"/>
         <ghfvs:OcticonImage Grid.Column="0" Margin="0 0 4 0" Icon="primitive_dot" Foreground="#f1c647" Visibility="{Binding Status, Converter={ghfvs:EqualsToVisibilityConverter Pending}}"/>
 
-	<!--
-        <Image Grid.Column="1" Source="{Binding AvatarUrl}" Height="16" Width="16" />
-        -->
-
-        <Label Grid.Column="2" Foreground="{DynamicResource VsBrush.WindowText}" Content="{Binding Title}"/>
-        <!--
-            <Label Grid.Column="3" HorizontalAlignment="Right" Content="{Binding Description}" ToolTip="{Binding Description}" />
-        -->
-        <Label Grid.Column="3" HorizontalAlignment="Right">
-            <ghfvs:OcticonButton Command="{Binding Path=DataContext.ShowAnnotations, RelativeSource={RelativeSource Mode=FindAncestor,AncestorType={x:Type local:PullRequestDetailView}}}"
-                                 CommandParameter="{Binding}"
-                                 Visibility="{Binding HasAnnotations, Converter={ghfvs:BooleanToVisibilityConverter}}"
-                                 Margin="0 0 0 0" Icon="file_code" Foreground="Black" />
+        <Label Grid.Column="1" Foreground="{DynamicResource VsBrush.WindowText}">
+            <TextBlock TextTrimming="CharacterEllipsis" Text="{Binding Title}" />
         </Label>
-        <Label Grid.Column="4" HorizontalAlignment="Right"
-               Visibility="{Binding DetailsUrl, Converter={ghfvs:NullToVisibilityConverter}}">
+
+        <Label Grid.Column="2" HorizontalContentAlignment="Stretch" Visibility="{Binding HasAnnotations, Converter={ghfvs:BooleanToVisibilityConverter}}">
+            <Hyperlink ToolTip="View checks"
+                           Command="{Binding Path=DataContext.ShowAnnotations, RelativeSource={RelativeSource Mode=FindAncestor,AncestorType={x:Type local:PullRequestDetailView}}}"
+                           CommandParameter="{Binding}">
+                Checks
+            </Hyperlink>
+        </Label>
+        
+        <Label Grid.Column="3" HorizontalContentAlignment="Stretch" Visibility="{Binding DetailsUrl, Converter={ghfvs:NullToVisibilityConverter}}">
             <Hyperlink ToolTip="{Binding DetailsUrl}"  Command="{Binding OpenDetailsUrl}">Details</Hyperlink>
         </Label>
     </Grid>

src/GitHub.VisualStudio.UI/Views/GitHubPane/PullRequestDetailView.xaml

@@ -252,7 +252,7 @@
                     <ItemsControl ItemsSource="{Binding Checks}" Margin="0 4 12 4">
                         <ItemsControl.ItemsPanel>
                             <ItemsPanelTemplate>
-                                <StackPanel Grid.IsSharedSizeScope="True" />
+                                <StackPanel Orientation="Vertical" HorizontalAlignment="Stretch"/>
                             </ItemsPanelTemplate>
                         </ItemsControl.ItemsPanel>
                     </ItemsControl>