Add tests for url generation

Author: shana

src/UnitTests/GitHub.Extensions/SimpleRepositoryModelExtensionTests.cs

@@ -0,0 +1,59 @@
+using System;
+using GitHub.Extensions;
+using GitHub.Models;
+using GitHub.VisualStudio;
+using LibGit2Sharp;
+using NSubstitute;
+using UnitTests;
+using Xunit;
+using GitHub.Primitives;
+using System.Linq;
+
+public class SimpleRepositoryModelExtensionTests : TempFileBaseClass
+{
+    void SetupRepository(string sha)
+    {
+        var provider = Substitutes.ServiceProvider;
+        Services.PackageServiceProvider = provider;
+        var gitservice = provider.GetGitService();
+        var repo = Substitute.For<IRepository>();
+        gitservice.GetRepo(Args.String).Returns(repo);
+        if (!String.IsNullOrEmpty(sha))
+        {
+            var commit = Substitute.For<Commit>();
+            commit.Sha.Returns(sha);
+            repo.Commits.Returns(new FakeCommitLog { commit });
+        }
+    }
+
+    [Theory]
+    [InlineData(false, "https://github.com/foo/bar", "123123", @"src\dir\file1.cs", -1, -1, "https://github.com/foo/bar/blob/123123/src/dir/file1.cs")]
+    [InlineData(false, "https://github.com/foo/bar", "123123", @"src\dir\file1.cs", 1, -1, "https://github.com/foo/bar/blob/123123/src/dir/file1.cs#L1")]
+    [InlineData(false, "https://github.com/foo/bar", "123123", @"src\dir\file1.cs", 1, 2, "https://github.com/foo/bar/blob/123123/src/dir/file1.cs#L1-L2")]
+    [InlineData(false, "https://github.com/foo/bar", "123123", @"src\dir\file1.cs", -1, 2, "https://github.com/foo/bar/blob/123123/src/dir/file1.cs")]
+    [InlineData(false, "https://github.com/foo/bar", "123123", "", 1, 2, "https://github.com/foo/bar/commit/123123")]
+    [InlineData(false, "https://github.com/foo/bar", "", @"src\dir\file1.cs", -1, 2, "https://github.com/foo/bar")]
+    [InlineData(false, "https://github.com/foo/bar", null, null, -1, -1, "https://github.com/foo/bar")]
+    [InlineData(false, null, "123123", @"src\dir\file1.cs", 1, 2, null)]
+    [InlineData(true,  "https://github.com/foo/bar", "123123", @"src\dir\file1.cs", -1, -1, "https://github.com/foo/bar/blob/123123/src/dir/file1.cs")]
+    [InlineData(true, "https://github.com/foo/bar", "123123", @"src\dir\file1.cs", 1, -1, "https://github.com/foo/bar/blob/123123/src/dir/file1.cs#L1")]
+    [InlineData(true, "https://github.com/foo/bar", "123123", @"src\dir\file1.cs", 1, 2, "https://github.com/foo/bar/blob/123123/src/dir/file1.cs#L1-L2")]
+    [InlineData(true, "https://github.com/foo/bar", "123123", @"src\dir\file1.cs", -1, 2, "https://github.com/foo/bar/blob/123123/src/dir/file1.cs")]
+    [InlineData(true, "https://github.com/foo/bar", "", @"src\dir\file1.cs", -1, 2, "https://github.com/foo/bar")]
+    [InlineData(true, null, "123123", @"src\dir\file1.cs", 1, 2, null)]
+    public void GenerateUrl(bool createRootedPath, string baseUrl, string sha, string path, int startLine, int endLine, string expected)
+    {
+        SetupRepository(sha);
+
+        var basePath = Directory.CreateSubdirectory("generate-url-test1");
+        if (createRootedPath && path != null)
+            path = System.IO.Path.Combine(basePath.FullName, path);
+        ISimpleRepositoryModel model = null;
+        if (!String.IsNullOrEmpty(baseUrl))
+            model = new SimpleRepositoryModel("bar", new UriString(baseUrl), basePath.FullName);
+        else
+            model = new SimpleRepositoryModel(basePath.FullName);
+        var result = model.GenerateUrl(path, startLine, endLine);
+        Assert.Equal(expected, result?.ToString());
+    }
+}

src/UnitTests/TestDoubles/FakeCommitLog.cs

@@ -1,7 +1,8 @@
-using System.Collections.Generic;
+using System;
+using System.Collections.Generic;
 using LibGit2Sharp;
 
-public class FakeCommitLog :  List<Commit>, ICommitLog
+public class FakeCommitLog :  List<Commit>, IQueryableCommitLog
 {
     public CommitSortStrategies SortedBy
     {
@@ -10,4 +11,29 @@ public CommitSortStrategies SortedBy
             return CommitSortStrategies.Topological;
         }
     }
+
+    public Commit FindMergeBase(IEnumerable<Commit> commits, MergeBaseFindingStrategy strategy)
+    {
+        throw new NotImplementedException();
+    }
+
+    public Commit FindMergeBase(Commit first, Commit second)
+    {
+        throw new NotImplementedException();
+    }
+
+    public IEnumerable<LogEntry> QueryBy(string path)
+    {
+        throw new NotImplementedException();
+    }
+
+    public ICommitLog QueryBy(CommitFilter filter)
+    {
+        throw new NotImplementedException();
+    }
+
+    public IEnumerable<LogEntry> QueryBy(string path, FollowFilter filter)
+    {
+        throw new NotImplementedException();
+    }
 }

src/UnitTests/UnitTests.csproj

@@ -155,6 +155,7 @@
     <Compile Include="GitHub.Exports.Reactive\Caches\AccountCacheItemTests.cs" />
     <Compile Include="GitHub.Exports\GitServiceTests.cs" />
     <Compile Include="GitHub.Exports\VSServicesTests.cs" />
+    <Compile Include="GitHub.Extensions\SimpleRepositoryModelExtensionTests.cs" />
     <Compile Include="GitHub.Extensions\UriExtensionTests.cs" />
     <Compile Include="GitHub.Primitives\UriStringTests.cs" />
     <Compile Include="GitHub.UI\TwoFactorInputTests.cs" />