Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit dba7be9

Browse files
authored
Merge pull request #2331 from github/fixes/2324-clone-follow-dialog-guidelines
Follow dialog style guidelines for Clone/Open
2 parents a661e7d + 7cc8267 commit dba7be9

File tree

4 files changed

+12
-14
lines changed

4 files changed

+12
-14
lines changed

src/GitHub.Resources/Resources.Designer.cs

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/GitHub.Resources/Resources.resx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -499,7 +499,7 @@ https://git-scm.com/download/win</value>
499499
<value>Private Repository</value>
500500
</data>
501501
<data name="localPathText" xml:space="preserve">
502-
<value>Local path</value>
502+
<value>Local path:</value>
503503
</data>
504504
<data name="licenseListText" xml:space="preserve">
505505
<value>License</value>
@@ -878,4 +878,4 @@ https://git-scm.com/download/win</value>
878878
<data name="RepositorySelectContributedRepositories" xml:space="preserve">
879879
<value>Contributed to repositories</value>
880880
</data>
881-
</root>
881+
</root>

src/GitHub.VisualStudio.UI/Views/Dialog/Clone/RepositoryCloneView.xaml

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
xmlns:vs="clr-namespace:Microsoft.VisualStudio.PlatformUI;assembly=Microsoft.VisualStudio.Shell.14.0"
1010
Background="{DynamicResource {x:Static vs:EnvironmentColors.ToolWindowBackgroundBrushKey}}"
1111
Foreground="{DynamicResource {x:Static vs:EnvironmentColors.ToolWindowTextBrushKey}}"
12+
Margin="12,12"
1213
mc:Ignorable="d" d:DesignHeight="414" d:DesignWidth="440">
1314
<d:DesignData.DataContext>
1415
<ghfvs:RepositoryCloneViewModelDesigner/>
@@ -19,34 +20,31 @@
1920
</Control.Resources>
2021

2122
<DockPanel>
22-
<StackPanel Orientation="Horizontal" DockPanel.Dock="Bottom" HorizontalAlignment="Center">
23+
<StackPanel Orientation="Horizontal" DockPanel.Dock="Bottom" HorizontalAlignment="Right" Margin="0,18,0,0">
2324
<Button
24-
Margin="12"
2525
HorizontalAlignment="Center"
2626
IsDefault="True"
2727
Command="{Binding Clone}"
2828
Content="Clone"
2929
AutomationProperties.AutomationId="{x:Static ghfvs:AutomationIDs.CloneRepositoryButton}"/>
3030

3131
<Button
32-
Margin="12"
32+
Margin="6,0,0,0"
3333
HorizontalAlignment="Center"
3434
IsDefault="True"
3535
Command="{Binding Open}"
3636
Content="Open"
3737
AutomationProperties.AutomationId="{x:Static ghfvs:AutomationIDs.OpenRepositoryButton}"/>
3838
</StackPanel>
3939

40-
<DockPanel DockPanel.Dock="Bottom"
41-
Margin="16">
42-
<Label DockPanel.Dock="Left" Content="{x:Static ghfvs:Resources.localPathText}"/>
40+
<DockPanel DockPanel.Dock="Bottom" Margin="0,9,0,0">
41+
<Label DockPanel.Dock="Left" Content="{x:Static ghfvs:Resources.localPathText}" />
4342
<Button DockPanel.Dock="Right"
4443
Command="{Binding Browse}"
45-
Style="{DynamicResource GitHubLinkButton}"
4644
VerticalContentAlignment="Center">
47-
Browse
45+
Browse...
4846
</Button>
49-
<TextBox Text="{Binding Path, UpdateSourceTrigger=PropertyChanged}"
47+
<TextBox Text="{Binding Path, UpdateSourceTrigger=PropertyChanged}" Margin="6,0"
5048
VerticalContentAlignment="Center" />
5149
</DockPanel>
5250

src/GitHub.VisualStudio.UI/Views/Dialog/Clone/SelectPageView.xaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
<DockPanel>
1717
<ghfvs:PromptTextBox DockPanel.Dock="Top"
18-
Margin="0,4"
18+
Margin="0,9"
1919
PromptText="Search or enter a URL"
2020
Text="{Binding Filter, UpdateSourceTrigger=PropertyChanged, Delay=300}"/>
2121

0 commit comments

Comments
 (0)