Lazily initialize when we're on a GitHub repo

Initialize when an active repository appears in IVSGitExt.

Author: jcansdale

src/GitHub.InlineReviews/Services/PullRequestStatusBarManager.cs

@@ -11,8 +11,10 @@
 using GitHub.VisualStudio;
 using GitHub.Models;
 using GitHub.Logging;
+using GitHub.Helpers;
 using GitHub.Extensions;
 using Serilog;
+using Task = System.Threading.Tasks.Task;
 
 namespace GitHub.InlineReviews.Services
 {
@@ -22,29 +24,54 @@ public class PullRequestStatusBarManager : IPullRequestStatusBarManager
         static readonly ILogger log = LogManager.ForContext<PullRequestStatusBarManager>();
         const string StatusBarPartName = "PART_SccStatusBarHost";
 
-        readonly IGitHubServiceProvider serviceProvider;
+        readonly IVSGitExt gitExt;
         readonly Window mainWindow;
-        readonly IPullRequestSessionManager pullRequestSessionManager;
+        readonly Lazy<IPullRequestSessionManager> pullRequestSessionManager;
         readonly IUsageTracker usageTracker;
+        readonly IGitHubServiceProvider serviceProvider;
+
+        bool initialized;
 
         [ImportingConstructor]
-        public PullRequestStatusBarManager(IGitHubServiceProvider serviceProvider, IPullRequestSessionManager pullRequestSessionManager, IUsageTracker usageTracker)
-            : this()
+        public PullRequestStatusBarManager(IVSGitExt gitExt, Lazy<IPullRequestSessionManager> pullRequestSessionManager,
+            IUsageTracker usageTracker, IGitHubServiceProvider serviceProvider)
         {
-            this.serviceProvider = serviceProvider;
+            this.gitExt = gitExt;
             this.pullRequestSessionManager = pullRequestSessionManager;
             this.usageTracker = usageTracker;
+            this.serviceProvider = serviceProvider;
+            mainWindow = Application.Current.MainWindow;
         }
 
-        public PullRequestStatusBarManager()
+        public void Initialize()
         {
-            mainWindow = Application.Current.MainWindow;
+            TryInitialize();
+            gitExt.ActiveRepositoriesChanged += TryInitialize;
         }
 
-        public void Initialize()
+        void TryInitialize()
+        {
+            if (!initialized && gitExt.ActiveRepositories.Count > 0)
+            {
+                initialized = true;
+                InitializeAsync().Forget();
+                gitExt.ActiveRepositoriesChanged -= TryInitialize;
+            }
+        }
+
+        async Task InitializeAsync()
         {
-            RefreshCurrentSession();
-            pullRequestSessionManager.PropertyChanged += PullRequestSessionManager_PropertyChanged;
+            try
+            {
+                await ThreadingHelper.SwitchToMainThreadAsync(); // Switch from VSGitExt to Main thread
+
+                RefreshCurrentSession();
+                pullRequestSessionManager.Value.PropertyChanged += PullRequestSessionManager_PropertyChanged;
+            }
+            catch (Exception e)
+            {
+                log.Error(e, "Error initializing");
+            }
         }
 
         void PullRequestSessionManager_PropertyChanged(object sender, PropertyChangedEventArgs e)
@@ -57,7 +84,7 @@ void PullRequestSessionManager_PropertyChanged(object sender, PropertyChangedEve
 
         void RefreshCurrentSession()
         {
-            var pullRequest = pullRequestSessionManager.CurrentSession?.PullRequest;
+            var pullRequest = pullRequestSessionManager.Value.CurrentSession?.PullRequest;
             var viewModel = pullRequest != null ? CreatePullRequestStatusViewModel(pullRequest) : null;
             ShowStatus(viewModel);
         }