Show Create a GitHub Gist if user not logged in

If user isn't logged in to either GitHub or GitHub Enterprise, allow
them to login as part of the create a Gist workflow.

Author: jcansdale

src/GitHub.App/Services/DialogService.cs

@@ -54,8 +54,16 @@ public async Task<string> ShowReCloneDialog(IRepositoryModel repository)
         public async Task ShowCreateGist(IConnection connection)
         {
             var viewModel = factory.CreateViewModel<IGistCreationViewModel>();
-            await viewModel.InitializeAsync(connection);
-            await showDialog.Show(viewModel);
+
+            if (connection != null)
+            {
+                await viewModel.InitializeAsync(connection);
+                await showDialog.Show(viewModel);
+            }
+            else
+            {
+                await showDialog.ShowWithFirstConnection(viewModel);
+            }
         }
 
         public async Task ShowCreateRepositoryDialog(IConnection connection)

src/GitHub.Exports/Services/IDialogService.cs

@@ -40,7 +40,8 @@ public interface IDialogService
         /// Shows the Create Gist dialog.
         /// </summary>
         /// <param name="connection">
-        /// The connection to use. May not be null.
+        /// The connection to use. If null, the first connection will be used, or the user promted
+        /// to log in if there are no connections.
         /// </param>
         Task ShowCreateGist(IConnection connection);
 

src/GitHub.VisualStudio/Commands/CreateGistCommand.cs

@@ -6,6 +6,7 @@
 using GitHub.Commands;
 using GitHub.Logging;
 using GitHub.Services;
+using GitHub.Extensions;
 using GitHub.Services.Vssdk.Commands;
 
 namespace GitHub.VisualStudio.Commands
@@ -21,7 +22,8 @@ protected CreateGistCommand(
             Lazy<IDialogService> dialogService,
             Lazy<ISelectedTextProvider> selectedTextProvider,
             Lazy<IConnectionManager> connectionManager)
-            : base(CommandSet, CommandId, dialogService, selectedTextProvider, connectionManager, true)
+            : base(CommandSet, CommandId, dialogService, selectedTextProvider, connectionManager, true,
+                  isNotLoggedInDefault: true)
         {
         }
 
@@ -68,6 +70,7 @@ protected CreateGistEnterpriseCommand(
     public abstract class CreateGistCommandBase : VsCommand
     {
         readonly bool isGitHubDotCom;
+        readonly bool isNotLoggedInDefault;
         readonly Lazy<IDialogService> dialogService;
         readonly Lazy<ISelectedTextProvider> selectedTextProvider;
         readonly Lazy<IConnectionManager> connectionManager;
@@ -77,13 +80,15 @@ protected CreateGistCommandBase(
             Lazy<IDialogService> dialogService,
             Lazy<ISelectedTextProvider> selectedTextProvider,
             Lazy<IConnectionManager> connectionManager,
-            bool isGitHubDotCom)
+            bool isGitHubDotCom,
+            bool isNotLoggedInDefault = false)
             : base(commandSet, commandId)
         {
-            this.isGitHubDotCom = isGitHubDotCom;
             this.dialogService = dialogService;
             this.selectedTextProvider = selectedTextProvider;
             this.connectionManager = connectionManager;
+            this.isGitHubDotCom = isGitHubDotCom;
+            this.isNotLoggedInDefault = isNotLoggedInDefault;
         }
 
         ISelectedTextProvider SelectedTextProvider => selectedTextProvider.Value;
@@ -100,7 +105,8 @@ public override async Task Execute()
         protected override void QueryStatus()
         {
             Log.Assert(SelectedTextProvider != null, "Could not get an instance of ISelectedTextProvider");
-            Visible = !string.IsNullOrWhiteSpace(SelectedTextProvider?.GetSelectedText()) && HasConnection();
+            Visible = !string.IsNullOrWhiteSpace(SelectedTextProvider?.GetSelectedText()) &&
+                (HasConnection() || isNotLoggedInDefault && IsLoggedIn() == false);
         }
 
         bool HasConnection()
@@ -114,5 +120,16 @@ async Task<IConnection> FindConnectionAsync()
             var connections = await connectionManager.Value.GetLoadedConnections();
             return connections.FirstOrDefault(x => x.IsLoggedIn && x.HostAddress.IsGitHubDotCom() == isGitHubDotCom);
         }
+
+        bool? IsLoggedIn()
+        {
+            var task = connectionManager.Value.IsLoggedIn();
+            if (task.IsCompleted)
+            {
+                return task.Result;
+            }
+
+            return null;
+        }
     }
 }