Remove obsolete metrics and tests

Author: jcansdale

src/GitHub.App/ViewModels/Dialog/Clone/RepositoryCloneViewModel.cs

@@ -26,7 +26,6 @@ public class RepositoryCloneViewModel : ViewModelBase, IRepositoryCloneViewModel
         readonly IConnectionManager connectionManager;
         readonly IRepositoryCloneService service;
         readonly IGitService gitService;
-        readonly IUsageService usageService;
         readonly IUsageTracker usageTracker;
         readonly IReadOnlyList<IRepositoryCloneTabViewModel> tabs;
         string path;
@@ -41,7 +40,6 @@ public RepositoryCloneViewModel(
             IConnectionManager connectionManager,
             IRepositoryCloneService service,
             IGitService gitService,
-            IUsageService usageService,
             IUsageTracker usageTracker,
             IRepositorySelectViewModel gitHubTab,
             IRepositorySelectViewModel enterpriseTab)
@@ -50,7 +48,6 @@ public RepositoryCloneViewModel(
             this.connectionManager = connectionManager;
             this.service = service;
             this.gitService = gitService;
-            this.usageService = usageService;
             this.usageTracker = usageTracker;
 
             GitHubTab = gitHubTab;
@@ -155,19 +152,6 @@ public async Task InitializeAsync(IConnection connection)
             }
 
             this.WhenAnyValue(x => x.SelectedTabIndex).Subscribe(x => tabs[x].Activate().Forget());
-
-            switch (SelectedTabIndex)
-            {
-                case 0:
-                    usageTracker.IncrementCounter(model => model.NumberOfCloneViewGitHubTab).Forget();
-                    break;
-                case 1:
-                    usageTracker.IncrementCounter(model => model.NumberOfCloneViewEnterpriseTab).Forget();
-                    break;
-                case 2:
-                    usageTracker.IncrementCounter(model => model.NumberOfCloneViewUrlTab).Forget();
-                    break;
-            }
         }
 
         void BrowseForDirectory()

src/GitHub.Exports/Models/UsageModel.cs

@@ -90,9 +90,6 @@ public class MeasuresModel
             public int ExecuteToggleInlineCommentMarginCommand { get; set; }
             public int NumberOfPullRequestFileMarginToggleInlineCommentMargin { get; set; }
             public int NumberOfPullRequestFileMarginViewChanges { get; set; }
-            public int NumberOfCloneViewGitHubTab { get; set; }
-            public int NumberOfCloneViewEnterpriseTab { get; set; }
-            public int NumberOfCloneViewUrlTab { get; set; }
             public int NumberOfGitHubClones { get; set; }
             public int NumberOfEnterpriseClones { get; set; }
             public int NumberOfGitHubOpens { get; set; }

test/GitHub.App.UnitTests/ViewModels/Dialog/Clone/RepositoryCloneViewModelTests.cs

@@ -2,8 +2,6 @@
 using System.ComponentModel;
 using System.Globalization;
 using System.IO;
-using System.Linq.Expressions;
-using System.Reactive.Linq;
 using System.Threading.Tasks;
 using GitHub.Extensions;
 using GitHub.Models;
@@ -72,44 +70,6 @@ public async Task GitHubPage_Is_Initialized()
             target.EnterpriseTab.DidNotReceiveWithAnyArgs().Initialize(null);
         }
 
-        [TestCase("https://github.com", null, false, 0)]
-        [TestCase("https://enterprise.com", null, false, 1)]
-        [TestCase("https://github.com", null, true, 0, Description = "Show URL tab for GitHub connections")]
-        [TestCase("https://enterprise.com", null, true, 1, Description = "Show URL tab for Enterprise connections")]
-        [TestCase("https://github.com", "https://github.com/github/visualstudio", false, 0)]
-        [TestCase("https://enterprise.com", "https://enterprise.com/owner/repo", false, 1)]
-        public async Task Default_SelectedTabIndex_For_Group(string address, string clipboardUrl, bool isGroupA, int expectTabIndex)
-        {
-            var cm = CreateConnectionManager(address);
-            var connection = cm.Connections[0];
-            var usageService = CreateUsageService(isGroupA);
-            var target = CreateTarget(connectionManager: cm, usageService: usageService);
-
-            await target.InitializeAsync(connection);
-
-            Assert.That(target.SelectedTabIndex, Is.EqualTo(expectTabIndex));
-        }
-
-        [TestCase("https://github.com", false, 1, nameof(UsageModel.MeasuresModel.NumberOfCloneViewGitHubTab))]
-        [TestCase("https://enterprise.com", false, 1, nameof(UsageModel.MeasuresModel.NumberOfCloneViewEnterpriseTab))]
-        [TestCase("https://github.com", true, 1, nameof(UsageModel.MeasuresModel.NumberOfCloneViewGitHubTab))]
-        [TestCase("https://enterprise.com", true, 1, nameof(UsageModel.MeasuresModel.NumberOfCloneViewEnterpriseTab))]
-        public async Task IncrementCounter_Showing_Default_Tab(string address, bool isGroupA, int numberOfCalls, string counterName)
-        {
-            var cm = CreateConnectionManager(address);
-            var connection = cm.Connections[0];
-            var usageService = CreateUsageService(isGroupA);
-            var usageTracker = Substitute.For<IUsageTracker>();
-            var target = CreateTarget(connectionManager: cm, usageService: usageService, usageTracker: usageTracker);
-            usageTracker.IncrementCounter(null).ReturnsForAnyArgs(Task.CompletedTask);
-
-            await target.InitializeAsync(connection).ConfigureAwait(false);
-
-            await usageTracker.Received(numberOfCalls).IncrementCounter(
-                Arg.Is<Expression<Func<UsageModel.MeasuresModel, int>>>(x =>
-                    ((MemberExpression)x.Body).Member.Name == counterName));
-        }
-
         [Test]
         public async Task EnterprisePage_Is_Initialized()
         {
@@ -435,7 +395,6 @@ static RepositoryCloneViewModel CreateTarget(
             IOperatingSystem os = null,
             IConnectionManager connectionManager = null,
             IRepositoryCloneService service = null,
-            IUsageService usageService = null,
             IUsageTracker usageTracker = null,
             IRepositorySelectViewModel gitHubTab = null,
             IRepositorySelectViewModel enterpriseTab = null,
@@ -445,7 +404,6 @@ static RepositoryCloneViewModel CreateTarget(
             os = os ?? Substitute.For<IOperatingSystem>();
             connectionManager = connectionManager ?? CreateConnectionManager("https://github.com");
             service = service ?? CreateRepositoryCloneService(defaultClonePath);
-            usageService = usageService ?? CreateUsageService();
             usageTracker = usageTracker ?? Substitute.For<IUsageTracker>();
             gitHubTab = gitHubTab ?? CreateSelectViewModel();
             enterpriseTab = enterpriseTab ?? CreateSelectViewModel();
@@ -456,7 +414,6 @@ static RepositoryCloneViewModel CreateTarget(
                 connectionManager,
                 service,
                 gitService,
-                usageService,
                 usageTracker,
                 gitHubTab,
                 enterpriseTab);
@@ -477,16 +434,6 @@ private static IGitService CreateGitService(bool repositoryExists, UriString rem
             return gitService;
         }
 
-        static IUsageService CreateUsageService(bool isGroupA = false)
-        {
-            var usageService = Substitute.For<IUsageService>();
-            var guidBytes = new byte[16];
-            guidBytes[guidBytes.Length - 1] = (byte)(isGroupA ? 0 : 1);
-            var userGuid = new Guid(guidBytes);
-            usageService.GetUserGuid().Returns(userGuid);
-            return usageService;
-        }
-
         static RepositoryModel CreateRepositoryModel(string repo = "owner/repo")
         {
             var split = repo.Split('/');