Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit de78234

Browse files
committed
Replace mark_github with placeholder circle
Loading `mark_github` via `GitHub.UI;component/SharedDictionary.xaml` is taking a noticeable amount of time and causing multiple assemblies to load. Changed to placeholder shape in the hope that we can replace this with an inline XAML GitHub logo.
1 parent bbbe930 commit de78234

File tree

1 file changed

+17
-14
lines changed

1 file changed

+17
-14
lines changed
Lines changed: 17 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,20 @@
1-
<Viewbox xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
2-
Width="1024" Height="1024">
1+
<Viewbox
2+
xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
3+
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
4+
xmlns:PresentationOptions="http://schemas.microsoft.com/winfx/2006/xaml/presentation/options"
5+
Width="1024" Height="1024">
6+
7+
<Viewbox.Resources>
8+
<ResourceDictionary>
9+
<Color x:Key="GitHubContextMenuIconColor">#424242</Color>
10+
<SolidColorBrush x:Key="GitHubContextMenuIconBrush" Color="{StaticResource GitHubContextMenuIconColor}" PresentationOptions:Freeze="true" />
11+
</ResourceDictionary>
12+
</Viewbox.Resources>
13+
314
<Border BorderBrush="Transparent" BorderThickness="1">
4-
<ghfvs:OcticonImage xmlns:ghfvs="https://github.com/github/VisualStudio"
5-
Foreground="{DynamicResource GitHubContextMenuIconBrush}"
6-
Icon="mark_github">
7-
<ghfvs:OcticonImage.Resources>
8-
<ResourceDictionary>
9-
<ResourceDictionary.MergedDictionaries>
10-
<ghfvs:SharedDictionaryManager Source="pack://application:,,,/GitHub.VisualStudio.UI;component/SharedDictionary.xaml" />
11-
<ghfvs:SharedDictionaryManager Source="pack://application:,,,/GitHub.UI;component/SharedDictionary.xaml" />
12-
</ResourceDictionary.MergedDictionaries>
13-
</ResourceDictionary>
14-
</ghfvs:OcticonImage.Resources>
15-
</ghfvs:OcticonImage>
15+
<StackPanel>
16+
<!-- TODO: Can we replace this with an inline GitHub logo? -->
17+
<Ellipse Fill="{StaticResource GitHubContextMenuIconBrush}" Height="100" Width="100"/>
18+
</StackPanel>
1619
</Border>
1720
</Viewbox>

0 commit comments

Comments
 (0)