Remove interfaces from Remote/RepositoryModel

RepositoryModel and RemoteRepositoryModel are now pure models without
interfaces.

Author: jcansdale

src/GitHub.App/SampleData/Dialog/Clone/SelectPageViewModelDesigner.cs

@@ -38,7 +38,7 @@ public SelectPageViewModelDesigner()
         public IReadOnlyList<IRepositoryItemViewModel> Items { get; }
         public ICollectionView ItemsView { get; }
         public IRepositoryItemViewModel SelectedItem { get; set; }
-        public IRepositoryModel Repository { get; }
+        public RepositoryModel Repository { get; }
 
         public void Initialize(IConnection connection)
         {

src/GitHub.App/SampleData/ForkRepositoryExecuteViewModelDesigner.cs

@@ -35,9 +35,9 @@ public ForkRepositoryExecuteViewModelDesigner()
 
         public string Title => null;
 
-        public IRepositoryModel SourceRepository { get; set; }
+        public RepositoryModel SourceRepository { get; set; }
 
-        public IRepositoryModel DestinationRepository { get; set; }
+        public RepositoryModel DestinationRepository { get; set; }
 
         public IAccount DestinationAccount { get; }
 

src/GitHub.App/SampleData/ForkRepositorySelectViewModelDesigner.cs

@@ -33,15 +33,15 @@ public ForkRepositorySelectViewModelDesigner()
 
         public IObservable<object> Done => null;
 
-        public IReadOnlyList<IRemoteRepositoryModel> ExistingForks { get; set; }
+        public IReadOnlyList<RemoteRepositoryModel> ExistingForks { get; set; }
 
         public bool IsLoading { get; set; }
 
         public string Title => null;
 
         public ReactiveCommand<IAccount, Unit> SelectedAccount => null;
 
-        public ReactiveCommand<IRemoteRepositoryModel, Unit> SwitchOrigin => null;
+        public ReactiveCommand<RemoteRepositoryModel, Unit> SwitchOrigin => null;
 
         public Task InitializeAsync(LocalRepositoryModel repository, IConnection connection)
         {

src/GitHub.App/SampleData/ForkRepositorySwitchViewModelDesigner.cs

@@ -29,9 +29,9 @@ public ForkRepositorySwitchViewModelDesigner()
 
         public IObservable<object> Done => null;
 
-        public IRepositoryModel SourceRepository { get; }
+        public RepositoryModel SourceRepository { get; }
 
-        public IRepositoryModel DestinationRepository { get; }
+        public RepositoryModel DestinationRepository { get; }
 
         public ReactiveCommand<Unit, Unit> SwitchFork => null;
 
@@ -41,7 +41,7 @@ public ForkRepositorySwitchViewModelDesigner()
 
         public bool UpdateOrigin { get; set; } = true;
 
-        public void Initialize(LocalRepositoryModel sourceRepository, IRemoteRepositoryModel remoteRepository)
+        public void Initialize(LocalRepositoryModel sourceRepository, RemoteRepositoryModel remoteRepository)
         {
         }
     }

src/GitHub.App/SampleData/PullRequestListViewModelDesigner.cs

@@ -55,8 +55,8 @@ public PullRequestListViewModelDesigner()
         public ICollectionView ItemsView { get; }
         public LocalRepositoryModel LocalRepository { get; set; }
         public IssueListMessage Message { get; set; }
-        public IRepositoryModel RemoteRepository { get; set; }
-        public IReadOnlyList<IRepositoryModel> Forks { get; }
+        public RepositoryModel RemoteRepository { get; set; }
+        public IReadOnlyList<RepositoryModel> Forks { get; }
         public string SearchQuery { get; set; }
         public string SelectedState { get; set; }
         public string StateCaption { get; set; }

src/GitHub.App/SampleData/RemoteRepositoryModelDesigner.cs

@@ -6,7 +6,7 @@
 namespace GitHub.SampleData
 {
     [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Design", "CA1036:OverrideMethodsOnComparableTypes")]
-    public class RemoteRepositoryModelDesigner : IRemoteRepositoryModel
+    public class RemoteRepositoryModelDesigner : RemoteRepositoryModel
     {
         public UriString CloneUrl { get; set; }
         public DateTimeOffset CreatedAt { get; set; }
@@ -17,20 +17,20 @@ public class RemoteRepositoryModelDesigner : IRemoteRepositoryModel
         public string Name { get; set; }
         public string Owner { get; set; }
         public IAccount OwnerAccount { get; set; }
-        public IRemoteRepositoryModel Parent { get; set; }
+        public RemoteRepositoryModel Parent { get; set; }
         public DateTimeOffset UpdatedAt { get; set; }
 
-        public int CompareTo(IRemoteRepositoryModel other)
+        public int CompareTo(RemoteRepositoryModel other)
         {
             return 0;
         }
 
-        public void CopyFrom(IRemoteRepositoryModel other)
+        public void CopyFrom(RemoteRepositoryModel other)
         {
         }
 
         [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Design", "CA1065:DoNotRaiseExceptionsInUnexpectedLocations")]
-        public bool Equals(IRemoteRepositoryModel other)
+        public bool Equals(RemoteRepositoryModel other)
         {
             return false;
         }

src/GitHub.App/SampleData/RepositoryRecloneViewModelDesigner.cs

@@ -17,7 +17,7 @@ public class RepositoryRecloneViewModelDesigner : ViewModelBase, IRepositoryRecl
         public ReactivePropertyValidator<string> BaseRepositoryPathValidator { get; }
         public ICommand BrowseForDirectory { get; }
         public ReactiveCommand<Unit, Unit> CloneCommand { get; }
-        public IRepositoryModel SelectedRepository { get; set; }
+        public RepositoryModel SelectedRepository { get; set; }
         public IObservable<object> Done { get; }
 
         public Task InitializeAsync(IConnection connection) => Task.CompletedTask;

src/GitHub.App/SampleData/SampleViewModels.cs

@@ -254,7 +254,7 @@ public IConnection SelectedConnection
     [ExcludeFromCodeCoverage]
     public static class RepositoryModelDesigner
     {
-        public static IRemoteRepositoryModel Create(string name = null, string owner = null)
+        public static RemoteRepositoryModel Create(string name = null, string owner = null)
         {
             name = name ?? "octocat";
             owner = owner ?? "github";

src/GitHub.App/Services/DialogService.cs

@@ -52,7 +52,7 @@ public async Task<CloneDialogResult> ShowCloneDialog(IConnection connection, str
             }
         }
 
-        public async Task<string> ShowReCloneDialog(IRepositoryModel repository)
+        public async Task<string> ShowReCloneDialog(RepositoryModel repository)
         {
             Guard.ArgumentNotNull(repository, nameof(repository));
 

src/GitHub.App/Services/ModelService.cs

@@ -104,7 +104,7 @@ public IObservable<IReadOnlyList<IAccount>> GetAccounts()
             .ToReadOnlyList(Create);
         }
 
-        public IObservable<IRemoteRepositoryModel> GetForks(IRepositoryModel repository)
+        public IObservable<RemoteRepositoryModel> GetForks(RepositoryModel repository)
         {
             return ApiClient.GetForks(repository.Owner, repository.Name)
                 .Select(x => new RemoteRepositoryModel(x));
@@ -156,7 +156,7 @@ IObservable<IEnumerable<AccountCacheItem>> GetUserOrganizations()
                  });
         }
 
-        public IObservable<IReadOnlyList<IRemoteRepositoryModel>> GetRepositories()
+        public IObservable<IReadOnlyList<RemoteRepositoryModel>> GetRepositories()
         {
             return GetUserRepositories(RepositoryType.Owner)
                 .TakeLast(1)
@@ -175,7 +175,7 @@ IObservable<AccountCacheItem> GetUserFromCache()
         /// <param name="repo"></param>
         /// <param name="collection"></param>
         /// <returns></returns>
-        public ITrackingCollection<IPullRequestModel> GetPullRequests(IRepositoryModel repo,
+        public ITrackingCollection<IPullRequestModel> GetPullRequests(RepositoryModel repo,
             ITrackingCollection<IPullRequestModel> collection)
         {
             // Since the api to list pull requests returns all the data for each pr, cache each pr in its own entry
@@ -215,7 +215,7 @@ public IObservable<IPullRequestModel> GetPullRequest(string owner, string name,
             throw new NotImplementedException();
         }
 
-        public IObservable<IRemoteRepositoryModel> GetRepository(string owner, string repo)
+        public IObservable<RemoteRepositoryModel> GetRepository(string owner, string repo)
         {
             var keyobs = GetUserFromCache()
                 .Select(user => string.Format(CultureInfo.InvariantCulture, "{0}|{1}|{2}/{3}", CacheIndex.RepoPrefix, user.Login, owner, repo));
@@ -228,7 +228,7 @@ public IObservable<IRemoteRepositoryModel> GetRepository(string owner, string re
                     .Select(Create)));
         }
 
-        public ITrackingCollection<IRemoteRepositoryModel> GetRepositories(ITrackingCollection<IRemoteRepositoryModel> collection)
+        public ITrackingCollection<RemoteRepositoryModel> GetRepositories(ITrackingCollection<RemoteRepositoryModel> collection)
         {
             var keyobs = GetUserFromCache()
                 .Select(user => string.Format(CultureInfo.InvariantCulture, "{0}|{1}", CacheIndex.RepoPrefix, user.Login));
@@ -256,7 +256,7 @@ public ITrackingCollection<IRemoteRepositoryModel> GetRepositories(ITrackingColl
             return collection;
         }
 
-        public IObservable<IPullRequestModel> CreatePullRequest(LocalRepositoryModel sourceRepository, IRepositoryModel targetRepository,
+        public IObservable<IPullRequestModel> CreatePullRequest(LocalRepositoryModel sourceRepository, RepositoryModel targetRepository,
             BranchModel sourceBranch, BranchModel targetBranch,
             string title, string body)
         {
@@ -286,7 +286,7 @@ public IObservable<Unit> InvalidateAll()
             return hostCache.InvalidateAll().ContinueAfter(() => hostCache.Vacuum());
         }
 
-        public IObservable<string> GetFileContents(IRepositoryModel repo, string commitSha, string path, string fileSha)
+        public IObservable<string> GetFileContents(RepositoryModel repo, string commitSha, string path, string fileSha)
         {
             return Observable.Defer(() => Task.Run(async () =>
             {
@@ -305,22 +305,22 @@ public IObservable<string> GetFileContents(IRepositoryModel repo, string commitS
             }));
         }
 
-        IObservable<IReadOnlyList<IRemoteRepositoryModel>> GetUserRepositories(RepositoryType repositoryType)
+        IObservable<IReadOnlyList<RemoteRepositoryModel>> GetUserRepositories(RepositoryType repositoryType)
         {
             return Observable.Defer(() => GetUserFromCache().SelectMany(user =>
                 hostCache.GetAndRefreshObject(string.Format(CultureInfo.InvariantCulture, "{0}|{1}:repos", user.Login, repositoryType),
                     () => GetUserRepositoriesFromApi(repositoryType),
                         TimeSpan.FromMinutes(2),
                         TimeSpan.FromDays(7)))
                 .ToReadOnlyList(Create))
-                .Catch<IReadOnlyList<IRemoteRepositoryModel>, KeyNotFoundException>(
+                .Catch<IReadOnlyList<RemoteRepositoryModel>, KeyNotFoundException>(
                     // This could in theory happen if we try to call this before the user is logged in.
                     e =>
                     {
                         log.Error(e,
                             "Retrieving {RepositoryType} user repositories failed because user is not stored in the cache",
                             repositoryType);
-                        return Observable.Return(Array.Empty<IRemoteRepositoryModel>());
+                        return Observable.Return(Array.Empty<RemoteRepositoryModel>());
                     });
         }
 
@@ -333,14 +333,14 @@ IObservable<IEnumerable<RepositoryCacheItem>> GetUserRepositoriesFromApi(Reposit
                 .Catch<IEnumerable<RepositoryCacheItem>, Exception>(_ => Observable.Return(Enumerable.Empty<RepositoryCacheItem>()));
         }
 
-        IObservable<IReadOnlyList<IRemoteRepositoryModel>> GetAllRepositoriesForAllOrganizations()
+        IObservable<IReadOnlyList<RemoteRepositoryModel>> GetAllRepositoriesForAllOrganizations()
         {
             return GetUserOrganizations()
                 .SelectMany(org => org.ToObservable())
                 .SelectMany(org => GetOrganizationRepositories(org.Login).TakeLast(1));
         }
 
-        IObservable<IReadOnlyList<IRemoteRepositoryModel>> GetOrganizationRepositories(string organization)
+        IObservable<IReadOnlyList<RemoteRepositoryModel>> GetOrganizationRepositories(string organization)
         {
             return Observable.Defer(() => GetUserFromCache().SelectMany(user =>
                 hostCache.GetAndRefreshObject(string.Format(CultureInfo.InvariantCulture, "{0}|{1}|repos", user.Login, organization),
@@ -349,17 +349,17 @@ IObservable<IReadOnlyList<IRemoteRepositoryModel>> GetOrganizationRepositories(s
                         TimeSpan.FromMinutes(2),
                         TimeSpan.FromDays(7)))
                 .ToReadOnlyList(Create))
-                .Catch<IReadOnlyList<IRemoteRepositoryModel>, KeyNotFoundException>(
+                .Catch<IReadOnlyList<RemoteRepositoryModel>, KeyNotFoundException>(
                     // This could in theory happen if we try to call this before the user is logged in.
                     e =>
                     {
                         log.Error(e, "Retrieveing {Organization} org repositories failed because user is not stored in the cache",
                             organization);
-                        return Observable.Return(Array.Empty<IRemoteRepositoryModel>());
+                        return Observable.Return(Array.Empty<RemoteRepositoryModel>());
                     });
         }
 
-        public IObservable<BranchModel> GetBranches(IRepositoryModel repo)
+        public IObservable<BranchModel> GetBranches(RepositoryModel repo)
         {
             var keyobs = GetUserFromCache()
                 .Select(user => string.Format(CultureInfo.InvariantCulture, "{0}|{1}|branch", user.Login, repo.Name));
@@ -403,7 +403,7 @@ IAccount Create(string login, string avatarUrl)
                 avatarProvider.GetAvatar(avatarUrl));
         }
 
-        IRemoteRepositoryModel Create(RepositoryCacheItem item)
+        RemoteRepositoryModel Create(RepositoryCacheItem item)
         {
             return new RemoteRepositoryModel(
                 item.Id,