Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit e55e47a

Browse files
Removing designer usage
1 parent 48f180d commit e55e47a

File tree

3 files changed

+7
-32
lines changed

3 files changed

+7
-32
lines changed

src/GitHub.App/SampleData/PullRequestCheckViewModelDesigner.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
using System;
2-
using System.ComponentModel;
32
using System.Windows.Media.Imaging;
3+
using GitHub.ViewModels;
4+
using GitHub.ViewModels.GitHubPane;
45
using ReactiveUI;
56

6-
namespace GitHub.ViewModels.GitHubPane
7+
namespace GitHub.App.SampleData
78
{
89
public sealed class PullRequestCheckViewModelDesigner : ViewModelBase, IPullRequestCheckViewModel
910
{

src/GitHub.App/SampleData/PullRequestDetailViewModelDesigner.cs

Lines changed: 2 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
using System.Diagnostics.CodeAnalysis;
99
using System.Reactive;
1010
using System.Threading.Tasks;
11+
using GitHub.App.SampleData;
1112

1213
namespace GitHub.SampleData
1314
{
@@ -95,35 +96,7 @@ public PullRequestDetailViewModelDesigner()
9596

9697
Files = new PullRequestFilesViewModelDesigner();
9798

98-
var defaultAvatar = "pack://application:,,,/GitHub.App;component/Images/default_user_avatar.png";
99-
100-
Checks = new[]
101-
{
102-
new PullRequestCheckViewModelDesigner
103-
{
104-
Title = "continuous-integration/appveyor/branch",
105-
Description = "AppVeyor build succeeded",
106-
Status = PullRequestCheckStatus.Success,
107-
AvatarUrl = defaultAvatar,
108-
Avatar = AvatarProvider.CreateBitmapImage(defaultAvatar),
109-
},
110-
new PullRequestCheckViewModelDesigner
111-
{
112-
Title = "continuous-integration/appveyor/pr",
113-
Description = "AppVeyor building",
114-
Status = PullRequestCheckStatus.Pending,
115-
AvatarUrl = defaultAvatar,
116-
Avatar = AvatarProvider.CreateBitmapImage(defaultAvatar),
117-
},
118-
new PullRequestCheckViewModelDesigner
119-
{
120-
Title = "continuous-integration/appveyor/other",
121-
Description = "AppVeyor build failed",
122-
Status = PullRequestCheckStatus.Failure,
123-
AvatarUrl = defaultAvatar,
124-
Avatar = AvatarProvider.CreateBitmapImage(defaultAvatar),
125-
},
126-
};
99+
Checks = new PullRequestCheckViewModelDesigner[0];
127100
}
128101

129102
public PullRequestDetailModel Model { get; }

src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,11 @@
1313
xmlns:cache="clr-namespace:GitHub.UI.Helpers;assembly=GitHub.UI"
1414
xmlns:sampleData="clr-namespace:GitHub.SampleData;assembly=GitHub.App"
1515
xmlns:prop="clr-namespace:GitHub.VisualStudio.UI;assembly=GitHub.VisualStudio.UI"
16+
xmlns:sampleData1="clr-namespace:GitHub.App.SampleData;assembly=GitHub.App"
1617
mc:Ignorable="d" d:DesignWidth="600">
1718

1819
<d:DesignData.DataContext>
19-
<ghfvs:PullRequestCheckViewModelDesigner />
20+
<sampleData1:PullRequestCheckViewModelDesigner />
2021
</d:DesignData.DataContext>
2122

2223
<Control.Resources>

0 commit comments

Comments
 (0)