Merge pull request #2087 from github/fixes/embed-interop-assemblies

Check we don't reference DesignTime assemblies

Author: StanleyGoldman

src/GitHub.VisualStudio.UI/GitHub.VisualStudio.UI.csproj

@@ -24,5 +24,6 @@
   <ItemGroup>
     <PackageReference Include="Markdig.Signed" version="0.13.0" />
     <PackageReference Include="Markdig.Wpf.Signed" version="0.2.1" />
+    <PackageReference Include="Microsoft.VisualStudio.SDK.EmbedInteropTypes" Version="15.0.27" />
   </ItemGroup>
 </Project>

test/GitHub.VisualStudio.UnitTests/GitHubAssemblyTests.cs

@@ -0,0 +1,22 @@
+using System.IO;
+using System.Reflection;
+using NUnit.Framework;
+
+public class GitHubAssemblyTests
+{
+    [Theory]
+    public void GitHub_Assembly_Should_Not_Reference_DesignTime_Assembly(string assemblyFile)
+    {
+        var asm = Assembly.LoadFrom(assemblyFile);
+        foreach (var referencedAssembly in asm.GetReferencedAssemblies())
+        {
+            Assert.That(referencedAssembly.Name, Does.Not.EndWith(".DesignTime"),
+                "DesignTime assemblies should be embedded not referenced");
+        }
+    }
+
+    [DatapointSource]
+    string[] GitHubAssemblies => Directory.GetFiles(AssemblyDirectory, "GitHub.*.dll");
+
+    string AssemblyDirectory => Path.GetDirectoryName(GetType().Assembly.Location);
+}