Allow request changes with only file comments.

Also fix unit test for `no body/>0 file comments` case - it wasn't correct before as it was assigning a body.

Author: grokys

src/GitHub.App/ViewModels/GitHubPane/PullRequestReviewAuthoringViewModel.cs

@@ -57,15 +57,18 @@ public PullRequestReviewAuthoringViewModel(
                 .ToProperty(this, x => x.CanApproveRequestChanges);
 
             Files = files;
+
+            var hasBodyOrComments = this.WhenAnyValue(
+                x => x.Body,
+                x => x.FileComments.Count,
+                (body, comments) => !string.IsNullOrWhiteSpace(body) || comments > 0);
+
             Approve = ReactiveCommand.CreateAsyncTask(_ => DoSubmit(Octokit.PullRequestReviewEvent.Approve));
             Comment = ReactiveCommand.CreateAsyncTask(
-                this.WhenAnyValue(
-                    x => x.Body,
-                    x => x.FileComments.Count,
-                    (body, comments) => !string.IsNullOrWhiteSpace(body) || comments > 0),
+                hasBodyOrComments,
                 _ => DoSubmit(Octokit.PullRequestReviewEvent.Comment));
             RequestChanges = ReactiveCommand.CreateAsyncTask(
-                this.WhenAnyValue(x => x.Body, body => !string.IsNullOrWhiteSpace(body)),
+                hasBodyOrComments,
                 _ => DoSubmit(Octokit.PullRequestReviewEvent.RequestChanges));
             Cancel = ReactiveCommand.CreateAsyncTask(DoCancel);
         }

test/UnitTests/GitHub.App/ViewModels/GitHubPane/PullRequestReviewAuthoringViewModelTests.cs

@@ -257,17 +257,15 @@ public async Task Comment_Is_Enabled_When_Has_Body()
         [Test]
         public async Task Comment_Is_Enabled_When_Has_File_Comments()
         {
-            var comment = CreateReviewComment(12);
             var review = CreateReview(12, "grokys", body: "", state: PullRequestReviewState.Pending);
-            var model = CreatePullRequest(
-                authorLogin: "shana",
-                reviews: new[] { review },
-                reviewComments: new[] { comment });
-            var session = CreateSession();
+            var model = CreatePullRequest("shana", review);
+            var session = CreateSession(
+                "grokys",
+                CreateSessionFile(
+                    CreateInlineCommentThread(CreateReviewComment(12))));
 
             var target = CreateTarget(model, session);
             await Initialize(target);
-            target.Body = "Review body";
 
             Assert.IsTrue(target.Comment.CanExecute(null));
         }
@@ -292,19 +290,14 @@ public async Task Comment_Calls_Session_PostReview_And_Closes()
         }
 
         [Test]
-        public async Task RequestChanges_Is_Disabled_When_Has_Empty_Body()
+        public async Task RequestChanges_Is_Disabled_When_Has_Empty_Body_And_No_File_RequestChangess()
         {
-            var comment = CreateReviewComment(12);
             var review = CreateReview(12, "grokys", body: "", state: PullRequestReviewState.Pending);
-            var model = CreatePullRequest(
-                authorLogin: "shana",
-                reviews: new[] { review },
-                reviewComments: new[] { comment });
+            var model = CreatePullRequest("shana", review);
             var session = CreateSession();
 
             var target = CreateTarget(model, session);
             await Initialize(target);
-            target.Body = "";
 
             Assert.IsFalse(target.RequestChanges.CanExecute(null));
         }
@@ -318,7 +311,23 @@ public async Task RequestChanges_Is_Enabled_When_Has_Body()
 
             var target = CreateTarget(model, session);
             await Initialize(target);
-            target.Body = "Request Changes";
+            target.Body = "Review body";
+
+            Assert.IsTrue(target.RequestChanges.CanExecute(null));
+        }
+
+        [Test]
+        public async Task RequestChanges_Is_Enabled_When_Has_File_Comments()
+        {
+            var review = CreateReview(12, "grokys", body: "", state: PullRequestReviewState.Pending);
+            var model = CreatePullRequest("shana", review);
+            var session = CreateSession(
+                "grokys",
+                CreateSessionFile(
+                    CreateInlineCommentThread(CreateReviewComment(12))));
+
+            var target = CreateTarget(model, session);
+            await Initialize(target);
 
             Assert.IsTrue(target.RequestChanges.CanExecute(null));
         }