Merge pull request #2191 from github/fixes/2190-system-net-http-4-0

Ensure we only reference System.Net.Http v4.0.0.0

Author: jcansdale

submodules/octokit.graphql.net

@@ -21,6 +21,7 @@
   <ItemGroup>
     <PackageReference Include="Codecov" Version="1.1.0" />
     <PackageReference Include="Madskristensen.VisualStudio.SDK" Version="14.3.75-pre" />
+    <PackageReference Include="NCrunch.Framework" Version="3.17.0" />
     <PackageReference Include="NSubstitute" Version="2.0.3" />
     <PackageReference Include="NUnit" version="3.9.0" />
     <PackageReference Include="OpenCover" Version="4.6.519" />

test/GitHub.VisualStudio.UnitTests/GitHub.VisualStudio.UnitTests.csproj

@@ -1,5 +1,8 @@
-using System.IO;
+using System;
+using System.IO;
+using System.Linq;
 using System.Reflection;
+using NCrunch.Framework;
 using NUnit.Framework;
 
 public class GitHubAssemblyTests
@@ -15,8 +18,34 @@ public void GitHub_Assembly_Should_Not_Reference_DesignTime_Assembly(string asse
         }
     }
 
+    [Theory]
+    public void GitHub_Assembly_Should_Not_Reference_System_Net_Http_Above_4_0(string assemblyFile)
+    {
+        var asm = Assembly.LoadFrom(assemblyFile);
+        foreach (var referencedAssembly in asm.GetReferencedAssemblies())
+        {
+            if (referencedAssembly.Name == "System.Net.Http")
+            {
+                Assert.That(referencedAssembly.Version, Is.EqualTo(new Version("4.0.0.0")));
+            }
+        }
+    }
+
     [DatapointSource]
-    string[] GitHubAssemblies => Directory.GetFiles(AssemblyDirectory, "GitHub.*.dll");
+    string[] GetGitHubAssemblies()
+    {
+        var prefix = "GitHub.";
+        if (NCrunchEnvironment.NCrunchIsResident())
+        {
+            return NCrunchEnvironment.GetAllAssemblyLocations()
+                .Where(p => Path.GetFileName(p).StartsWith(prefix, StringComparison.OrdinalIgnoreCase))
+                .ToArray();
+        }
+        else
+        {
+            var dir = Path.GetDirectoryName(GetType().Assembly.Location);
+            return Directory.GetFiles(dir, $"{prefix}*.dll");
+        }
+    }
 
-    string AssemblyDirectory => Path.GetDirectoryName(GetType().Assembly.Location);
 }