Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit e99e294

Browse files
shanashana
committed
Fix ruleset location
1 parent 8e82e4a commit e99e294

File tree

10 files changed

+95
-23
lines changed

10 files changed

+95
-23
lines changed

‎src/GitHub.Api/GitHub.Api.csproj‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
<ErrorReport>prompt</ErrorReport>
2323
<WarningLevel>4</WarningLevel>
2424
<RunCodeAnalysis>true</RunCodeAnalysis>
25-
<CodeAnalysisRuleSet>..\..\script\GitHubVS.ruleset</CodeAnalysisRuleSet>
25+
<CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>
2626
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
2727
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
2828
</PropertyGroup>
@@ -36,7 +36,7 @@
3636
<RunCodeAnalysis>true</RunCodeAnalysis>
3737
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
3838
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
39-
<CodeAnalysisRuleSet>..\..\script\GitHubVS.ruleset</CodeAnalysisRuleSet>
39+
<CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>
4040
</PropertyGroup>
4141
<PropertyGroup Condition="$(Buildtype) == 'Internal'">
4242
<AssemblyOriginatorKeyFile>..\..\script\Key.snk</AssemblyOriginatorKeyFile>

‎src/GitHub.App/GitHub.App.csproj‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
</NuGetPackageImportStamp>
1717
<WarningLevel>4</WarningLevel>
1818
<RunCodeAnalysis>true</RunCodeAnalysis>
19-
<CodeAnalysisRuleSet>..\..\script\GitHubVS.ruleset</CodeAnalysisRuleSet>
19+
<CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>
2020
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
2121
<BuildType Condition="Exists('..\..\script\ApiClientConfiguration.cs')">Internal</BuildType>
2222
</PropertyGroup>
@@ -29,7 +29,7 @@
2929
<ErrorReport>prompt</ErrorReport>
3030
<WarningLevel>4</WarningLevel>
3131
<RunCodeAnalysis>true</RunCodeAnalysis>
32-
<CodeAnalysisRuleSet>..\..\script\GitHubVS.ruleset</CodeAnalysisRuleSet>
32+
<CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>
3333
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
3434
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
3535
</PropertyGroup>
@@ -43,7 +43,7 @@
4343
<RunCodeAnalysis>true</RunCodeAnalysis>
4444
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
4545
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
46-
<CodeAnalysisRuleSet>..\..\script\GitHubVS.ruleset</CodeAnalysisRuleSet>
46+
<CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>
4747
</PropertyGroup>
4848
<PropertyGroup Condition="$(Buildtype) == 'Internal'">
4949
<AssemblyOriginatorKeyFile>..\..\script\Key.snk</AssemblyOriginatorKeyFile>

‎src/GitHub.Exports.Reactive/GitHub.Exports.Reactive.csproj‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
<ErrorReport>prompt</ErrorReport>
2323
<WarningLevel>4</WarningLevel>
2424
<RunCodeAnalysis>true</RunCodeAnalysis>
25-
<CodeAnalysisRuleSet>..\..\script\GitHubVS.ruleset</CodeAnalysisRuleSet>
25+
<CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>
2626
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
2727
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
2828
</PropertyGroup>
@@ -36,7 +36,7 @@
3636
<RunCodeAnalysis>true</RunCodeAnalysis>
3737
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
3838
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
39-
<CodeAnalysisRuleSet>..\..\script\GitHubVS.ruleset</CodeAnalysisRuleSet>
39+
<CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>
4040
</PropertyGroup>
4141
<PropertyGroup Condition="$(Buildtype) == 'Internal'">
4242
<AssemblyOriginatorKeyFile>..\..\script\Key.snk</AssemblyOriginatorKeyFile>

‎src/GitHub.Exports/GitHub.Exports.csproj‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
<ErrorReport>prompt</ErrorReport>
2323
<WarningLevel>4</WarningLevel>
2424
<RunCodeAnalysis>true</RunCodeAnalysis>
25-
<CodeAnalysisRuleSet>..\..\script\GitHubVS.ruleset</CodeAnalysisRuleSet>
25+
<CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>
2626
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
2727
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
2828
</PropertyGroup>
@@ -36,7 +36,7 @@
3636
<RunCodeAnalysis>true</RunCodeAnalysis>
3737
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
3838
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
39-
<CodeAnalysisRuleSet>..\..\script\GitHubVS.ruleset</CodeAnalysisRuleSet>
39+
<CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>
4040
</PropertyGroup>
4141
<PropertyGroup Condition="$(Buildtype) == 'Internal'">
4242
<AssemblyOriginatorKeyFile>..\..\script\Key.snk</AssemblyOriginatorKeyFile>

‎src/GitHub.Extensions.Reactive/GitHub.Extensions.Reactive.csproj‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<NuGetPackageImportStamp>83c06b42</NuGetPackageImportStamp>
1515
<WarningLevel>4</WarningLevel>
1616
<RunCodeAnalysis>true</RunCodeAnalysis>
17-
<CodeAnalysisRuleSet>..\..\script\GitHubVS.ruleset</CodeAnalysisRuleSet>
17+
<CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>
1818
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
1919
<BuildType Condition="Exists('..\..\script\ApiClientConfiguration.cs')">Internal</BuildType>
2020
</PropertyGroup>
@@ -27,7 +27,7 @@
2727
<ErrorReport>prompt</ErrorReport>
2828
<WarningLevel>4</WarningLevel>
2929
<RunCodeAnalysis>true</RunCodeAnalysis>
30-
<CodeAnalysisRuleSet>..\..\script\GitHubVS.ruleset</CodeAnalysisRuleSet>
30+
<CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>
3131
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
3232
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
3333
</PropertyGroup>
@@ -41,7 +41,7 @@
4141
<RunCodeAnalysis>true</RunCodeAnalysis>
4242
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
4343
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
44-
<CodeAnalysisRuleSet>..\..\script\GitHubVS.ruleset</CodeAnalysisRuleSet>
44+
<CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>
4545
</PropertyGroup>
4646
<PropertyGroup Condition="$(Buildtype) == 'Internal'">
4747
<AssemblyOriginatorKeyFile>..\..\script\Key.snk</AssemblyOriginatorKeyFile>

‎src/GitHub.Extensions/GitHub.Extensions.csproj‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<NuGetPackageImportStamp>ae382bf5</NuGetPackageImportStamp>
1515
<WarningLevel>4</WarningLevel>
1616
<RunCodeAnalysis>true</RunCodeAnalysis>
17-
<CodeAnalysisRuleSet>..\..\script\GitHubVS.ruleset</CodeAnalysisRuleSet>
17+
<CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>
1818
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
1919
<BuildType Condition="Exists('..\..\script\ApiClientConfiguration.cs')">Internal</BuildType>
2020
</PropertyGroup>
@@ -27,7 +27,7 @@
2727
<ErrorReport>prompt</ErrorReport>
2828
<WarningLevel>4</WarningLevel>
2929
<RunCodeAnalysis>true</RunCodeAnalysis>
30-
<CodeAnalysisRuleSet>..\..\script\GitHubVS.ruleset</CodeAnalysisRuleSet>
30+
<CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>
3131
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
3232
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
3333
</PropertyGroup>
@@ -41,7 +41,7 @@
4141
<RunCodeAnalysis>true</RunCodeAnalysis>
4242
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
4343
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
44-
<CodeAnalysisRuleSet>..\..\script\GitHubVS.ruleset</CodeAnalysisRuleSet>
44+
<CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>
4545
</PropertyGroup>
4646
<PropertyGroup Condition="$(Buildtype) == 'Internal'">
4747
<AssemblyOriginatorKeyFile>..\..\script\Key.snk</AssemblyOriginatorKeyFile>

‎src/GitHub.UI.Reactive/GitHub.UI.Reactive.csproj‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<NuGetPackageImportStamp>0264ca35</NuGetPackageImportStamp>
1616
<WarningLevel>4</WarningLevel>
1717
<RunCodeAnalysis>true</RunCodeAnalysis>
18-
<CodeAnalysisRuleSet>..\..\script\GitHubVS.ruleset</CodeAnalysisRuleSet>
18+
<CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>
1919
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
2020
<BuildType Condition="Exists('..\..\script\ApiClientConfiguration.cs')">Internal</BuildType>
2121
</PropertyGroup>
@@ -28,7 +28,7 @@
2828
<ErrorReport>prompt</ErrorReport>
2929
<WarningLevel>4</WarningLevel>
3030
<RunCodeAnalysis>false</RunCodeAnalysis>
31-
<CodeAnalysisRuleSet>..\..\script\GitHubVS.ruleset</CodeAnalysisRuleSet>
31+
<CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>
3232
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
3333
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
3434
</PropertyGroup>
@@ -42,7 +42,7 @@
4242
<RunCodeAnalysis>false</RunCodeAnalysis>
4343
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
4444
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
45-
<CodeAnalysisRuleSet>..\..\script\GitHubVS.ruleset</CodeAnalysisRuleSet>
45+
<CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>
4646
</PropertyGroup>
4747
<PropertyGroup Condition="$(Buildtype) == 'Internal'">
4848
<AssemblyOriginatorKeyFile>..\..\script\Key.snk</AssemblyOriginatorKeyFile>

‎src/GitHub.UI/GitHub.UI.csproj‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
<ErrorReport>prompt</ErrorReport>
2525
<WarningLevel>4</WarningLevel>
2626
<RunCodeAnalysis>false</RunCodeAnalysis>
27-
<CodeAnalysisRuleSet>..\..\script\GitHubVS.ruleset</CodeAnalysisRuleSet>
27+
<CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>
2828
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
2929
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
3030
</PropertyGroup>
@@ -38,7 +38,7 @@
3838
<RunCodeAnalysis>false</RunCodeAnalysis>
3939
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
4040
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
41-
<CodeAnalysisRuleSet>..\..\script\GitHubVS.ruleset</CodeAnalysisRuleSet>
41+
<CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>
4242
</PropertyGroup>
4343
<PropertyGroup Condition="$(Buildtype) == 'Internal'">
4444
<AssemblyOriginatorKeyFile>..\..\script\Key.snk</AssemblyOriginatorKeyFile>

‎src/GitHub.VisualStudio/GitHub.VisualStudio.csproj‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
<ErrorReport>prompt</ErrorReport>
3636
<WarningLevel>4</WarningLevel>
3737
<RunCodeAnalysis>true</RunCodeAnalysis>
38-
<CodeAnalysisRuleSet>..\..\script\GitHubVS.ruleset</CodeAnalysisRuleSet>
38+
<CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>
3939
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
4040
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
4141
<OutputPath>..\..\build\$(Configuration)\</OutputPath>
@@ -52,7 +52,7 @@
5252
<RunCodeAnalysis>false</RunCodeAnalysis>
5353
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
5454
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
55-
<CodeAnalysisRuleSet>..\..\script\GitHubVS.ruleset</CodeAnalysisRuleSet>
55+
<CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>
5656
<OutputPath>..\..\build\$(Configuration)\</OutputPath>
5757
<IncludeDebugSymbolsInVSIXContainer>true</IncludeDebugSymbolsInVSIXContainer>
5858
</PropertyGroup>
@@ -65,7 +65,7 @@
6565
<RunCodeAnalysis>false</RunCodeAnalysis>
6666
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
6767
<CodeAnalysisIgnoreGeneratedCode>true</CodeAnalysisIgnoreGeneratedCode>
68-
<CodeAnalysisRuleSet>..\..\script\GitHubVS.ruleset</CodeAnalysisRuleSet>
68+
<CodeAnalysisRuleSet>..\common\GitHubVS.ruleset</CodeAnalysisRuleSet>
6969
<OutputPath>..\..\build\Release\</OutputPath>
7070
<DeployExtension>False</DeployExtension>
7171
</PropertyGroup>

‎src/common/GitHubVS.ruleset‎

Lines changed: 72 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,72 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<RuleSet Name="GitHub" Description="This ruleset only includes the rules we care about. I'll be adding new ones as we fix our codebase." ToolsVersion="11.0">
3+
<IncludeAll Action="Error" />
4+
<Rules AnalyzerId="Microsoft.Analyzers.ManagedCodeAnalysis" RuleNamespace="Microsoft.Rules.Managed">
5+
<Rule Id="CA1002" Action="None" />
6+
<Rule Id="CA1006" Action="None" />
7+
<Rule Id="CA1014" Action="None" />
8+
<Rule Id="CA1017" Action="None" />
9+
<Rule Id="CA1020" Action="None" />
10+
<Rule Id="CA1021" Action="None" />
11+
<Rule Id="CA1024" Action="None" />
12+
<Rule Id="CA1026" Action="None" />
13+
<Rule Id="CA1030" Action="None" />
14+
<Rule Id="CA1031" Action="None" />
15+
<Rule Id="CA1033" Action="None" />
16+
<Rule Id="CA1034" Action="None" />
17+
<Rule Id="CA1045" Action="None" />
18+
<Rule Id="CA1051" Action="None" />
19+
<Rule Id="CA1054" Action="None" />
20+
<Rule Id="CA1055" Action="None" />
21+
<Rule Id="CA1056" Action="None" />
22+
<Rule Id="CA1062" Action="None" />
23+
<Rule Id="CA1063" Action="None" />
24+
<Rule Id="CA1303" Action="None" />
25+
<Rule Id="CA1401" Action="None" />
26+
<Rule Id="CA1402" Action="None" />
27+
<Rule Id="CA1403" Action="None" />
28+
<Rule Id="CA1405" Action="None" />
29+
<Rule Id="CA1406" Action="None" />
30+
<Rule Id="CA1407" Action="None" />
31+
<Rule Id="CA1408" Action="None" />
32+
<Rule Id="CA1409" Action="None" />
33+
<Rule Id="CA1410" Action="None" />
34+
<Rule Id="CA1411" Action="None" />
35+
<Rule Id="CA1412" Action="None" />
36+
<Rule Id="CA1413" Action="None" />
37+
<Rule Id="CA1501" Action="None" />
38+
<Rule Id="CA1502" Action="None" />
39+
<Rule Id="CA1506" Action="None" />
40+
<Rule Id="CA1702" Action="None" />
41+
<Rule Id="CA1704" Action="None" />
42+
<Rule Id="CA1707" Action="None" />
43+
<Rule Id="CA1708" Action="None" />
44+
<Rule Id="CA1709" Action="None" />
45+
<Rule Id="CA1710" Action="None" />
46+
<Rule Id="CA1711" Action="None" />
47+
<Rule Id="CA1712" Action="None" />
48+
<Rule Id="CA1713" Action="None" />
49+
<Rule Id="CA1714" Action="None" />
50+
<Rule Id="CA1715" Action="None" />
51+
<Rule Id="CA1716" Action="None" />
52+
<Rule Id="CA1717" Action="None" />
53+
<Rule Id="CA1719" Action="None" />
54+
<Rule Id="CA1720" Action="None" />
55+
<Rule Id="CA1721" Action="None" />
56+
<Rule Id="CA1722" Action="None" />
57+
<Rule Id="CA1724" Action="None" />
58+
<Rule Id="CA1725" Action="None" />
59+
<Rule Id="CA1726" Action="None" />
60+
<Rule Id="CA1810" Action="None" />
61+
<Rule Id="CA1811" Action="None" />
62+
<Rule Id="CA2000" Action="None" />
63+
<Rule Id="CA2118" Action="None" />
64+
<Rule Id="CA2122" Action="None" />
65+
<Rule Id="CA2200" Action="None" />
66+
<Rule Id="CA2204" Action="None" />
67+
<Rule Id="CA2210" Action="None" />
68+
<Rule Id="CA2211" Action="None" />
69+
<Rule Id="CA2213" Action="None" />
70+
<Rule Id="CA2227" Action="None" />
71+
</Rules>
72+
</RuleSet>

0 commit comments

Comments
 (0)