Pass IPackageSettings to UsageTracker ctor.

`UsageTracker` was querying `IPackageSettings` in its initialization and this was causing an occasional race condition between `AsyncPackage.AddService` and `GetService`.  Instead pass the `IPackageSettings` to the `UsageTracker` constructor.

Author: grokys

src/GitHub.VisualStudio/GitHubPackage.cs

@@ -254,7 +254,8 @@ async Task<object> CreateService(IAsyncServiceContainer container, CancellationT
             {
                 var usageService = await GetServiceAsync(typeof(IUsageService)) as IUsageService;
                 var serviceProvider = await GetServiceAsync(typeof(IGitHubServiceProvider)) as IGitHubServiceProvider;
-                return new UsageTracker(serviceProvider, usageService);
+                var settings = await GetServiceAsync(typeof(IPackageSettings)) as IPackageSettings;
+                return new UsageTracker(serviceProvider, usageService, settings);
             }
             else if (serviceType == typeof(IVSGitExt))
             {

src/GitHub.VisualStudio/Services/UsageTracker.cs

@@ -28,14 +28,15 @@ public sealed class UsageTracker : IUsageTracker, IDisposable
         IDisposable timer;
         bool firstTick = true;
 
-        [ImportingConstructor]
         public UsageTracker(
             IGitHubServiceProvider gitHubServiceProvider,
-            IUsageService service)
+            IUsageService service,
+            IPackageSettings settings)
         {
             this.gitHubServiceProvider = gitHubServiceProvider;
             this.service = service;
-            timer = StartTimer();            
+            this.userSettings = settings;
+            timer = StartTimer();
         }
 
         public void Dispose()
@@ -71,7 +72,6 @@ async Task Initialize()
 
                 client = gitHubServiceProvider.TryGetService<IMetricsService>();
                 connectionManager = gitHubServiceProvider.GetService<IConnectionManager>();
-                userSettings = gitHubServiceProvider.GetService<IPackageSettings>();
                 vsservices = gitHubServiceProvider.GetService<IVSServices>();
                 initialized = true;
             }