Trying to get the dispose pattern right.

Author: grokys

src/GitHub.UI.Reactive/Controls/ViewBase.cs

@@ -105,6 +105,7 @@ public class ViewBase<TInterface, TImplementor> : ViewBase, IView, IViewFor<TInt
             "ViewModel", typeof(TInterface), typeof(TImplementor), new PropertyMetadata(null));
 
         IDisposable subscriptions;
+        bool disposed;
 
         /// <summary>
         /// Initializes a new instance of the <see cref="ViewBase{TInterface, TImplementor}"/> class.
@@ -213,10 +214,15 @@ public void Dispose()
         /// </summary>
         protected virtual void Dispose(bool disposing)
         {
-            if (disposing)
+            if (!disposed)
             {
-                subscriptions?.Dispose();
-                subscriptions = null;
+                if (disposing)
+                {
+                    subscriptions?.Dispose();
+                    subscriptions = null;
+                }
+
+                disposed = true;
             }
         }
     }

src/GitHub.VisualStudio/UI/Views/PullRequestListView.xaml.cs

@@ -62,12 +62,14 @@ protected override void Dispose(bool disposing)
         {
             base.Dispose(disposing);
 
-            if (disposed) return;
-
-            if (disposing)
+            if (!disposed)
             {
-                open.Dispose();
-                create.Dispose();
+                if (disposing)
+                {
+                    open.Dispose();
+                    create.Dispose();
+                }
+
                 disposed = true;
             }
         }