Revert "Hiding the checks section if there are no checks to display"

This reverts commit f3635e9.

Author: StanleyGoldman

src/GitHub.App/SampleData/PullRequestDetailViewModelDesigner.cs

@@ -98,7 +98,6 @@ public PullRequestDetailViewModelDesigner()
             Files = new PullRequestFilesViewModelDesigner();
 
             Checks = Array.Empty<PullRequestCheckViewModelDesigner>();
-            HasChecks = false;
         }
 
         public PullRequestDetailModel Model { get; }
@@ -130,7 +129,6 @@ public PullRequestDetailViewModelDesigner()
         public ReactiveCommand<IPullRequestCheckViewModel, Unit> ShowAnnotations { get; }
 
         public IReadOnlyList<IPullRequestCheckViewModel> Checks { get; }
-        public bool HasChecks { get; }
 
         public Task InitializeAsync(LocalRepositoryModel localRepository, IConnection connection, string owner, string repo, int number) => Task.CompletedTask;
 

src/GitHub.App/ViewModels/GitHubPane/PullRequestDetailViewModel.cs

@@ -58,7 +58,6 @@ public sealed class PullRequestDetailViewModel : PanePageViewModelBase, IPullReq
         Uri webUrl;
         IDisposable sessionSubscription;
         IReadOnlyList<IPullRequestCheckViewModel> checks;
-        bool hasChecks;
 
         /// <summary>
         /// Initializes a new instance of the <see cref="PullRequestDetailViewModel"/> class.
@@ -283,13 +282,6 @@ public IReadOnlyList<IPullRequestCheckViewModel> Checks
             private set { this.RaiseAndSetIfChanged(ref checks, value); }
         }
 
-        /// <inheritdoc/>
-        public bool HasChecks
-        {
-            get { return hasChecks; }
-            private set { this.RaiseAndSetIfChanged(ref hasChecks, value); }
-        }
-
         /// <inheritdoc/>
         public async Task InitializeAsync(
             LocalRepositoryModel localRepository,
@@ -359,7 +351,6 @@ public async Task Load(PullRequestDetailModel pullRequest)
                 Reviews = PullRequestReviewSummaryViewModel.BuildByUser(Session.User, pullRequest).ToList();
 
                 Checks = PullRequestCheckViewModel.Build(viewViewModelFactory, pullRequest)?.ToList();
-                HasChecks = Checks?.Any() ?? false;
 
                 await Files.InitializeAsync(Session);
 

src/GitHub.Exports.Reactive/ViewModels/GitHubPane/IPullRequestDetailViewModel.cs

@@ -191,11 +191,6 @@ public interface IPullRequestDetailViewModel : IPanePageViewModel, IOpenInBrowse
         /// </summary>
         IReadOnlyList<IPullRequestCheckViewModel> Checks { get; }
 
-        /// <summary>
-        /// Flag that indicates if there are checks or statuses to display.
-        /// </summary>
-        bool HasChecks { get; }
-
         /// <summary>
         /// Initializes the view model.
         /// </summary>

src/GitHub.VisualStudio.UI/Views/GitHubPane/PullRequestDetailView.xaml

@@ -248,8 +248,7 @@
                                       HeaderText="Checks"
                                       IsExpanded="True"
                                       Margin="0 8 0 0"
-                                      ghfvs:ScrollingVerticalStackPanel.IsFixed="true"
-                                      Visibility="{Binding HasChecks, Converter={ghfvs:BooleanToVisibilityConverter}}">
+                                      ghfvs:ScrollingVerticalStackPanel.IsFixed="true">
                     <ItemsControl ItemsSource="{Binding Checks}" Margin="0 4 12 4">
                         <ItemsControl.ItemsPanel>
                             <ItemsPanelTemplate>