Let PR # appear on status bar before solution has loaded

ThreadingHelper.SwitchToMainThreadAsync() only returns when a solution has loaded.
Use Application.Current.Dispatcher.Invoke instead of ThreadingHelper.SwitchToMainThreadAsync.

Author: jcansdale

src/GitHub.InlineReviews/PullRequestStatusBarPackage.cs

@@ -1,7 +1,7 @@
 using System;
+using System.Windows;
 using System.Threading;
 using System.Runtime.InteropServices;
-using GitHub.Helpers;
 using GitHub.Services;
 using GitHub.VisualStudio;
 using GitHub.InlineReviews.Services;
@@ -23,9 +23,12 @@ protected override async Task InitializeAsync(CancellationToken cancellationToke
             var usageTracker = (IUsageTracker)await GetServiceAsync(typeof(IUsageTracker));
             var serviceProvider = (IGitHubServiceProvider)await GetServiceAsync(typeof(IGitHubServiceProvider));
 
-            await ThreadingHelper.SwitchToMainThreadAsync();
-            var gitExt = serviceProvider.GetService<IVSGitExt>();
-            new PullRequestStatusBarManager(gitExt, usageTracker, serviceProvider);
+            // NOTE: ThreadingHelper.SwitchToMainThreadAsync() doesn't return until a solution is loaded. Using Dispatcher.Invoke instead.
+            Application.Current.Dispatcher.Invoke(() =>
+            {
+                var gitExt = serviceProvider.GetService<IVSGitExt>();
+                new PullRequestStatusBarManager(gitExt, usageTracker, serviceProvider);
+            });
         }
     }
 }

src/GitHub.InlineReviews/Services/PullRequestStatusBarManager.cs

@@ -11,10 +11,8 @@
 using GitHub.VisualStudio;
 using GitHub.Models;
 using GitHub.Logging;
-using GitHub.Helpers;
 using GitHub.Extensions;
 using Serilog;
-using Task = System.Threading.Tasks.Task;
 
 namespace GitHub.InlineReviews.Services
 {
@@ -44,17 +42,15 @@ void OnActiveRepositoriesChanged()
         {
             if (gitExt.ActiveRepositories.Count > 0)
             {
-                StartShowingStatus().Forget();
                 gitExt.ActiveRepositoriesChanged -= OnActiveRepositoriesChanged;
+                Application.Current.Dispatcher.Invoke(() => StartShowingStatus());
             }
         }
 
-        async Task StartShowingStatus()
+        void StartShowingStatus()
         {
             try
             {
-                await ThreadingHelper.SwitchToMainThreadAsync(); // Switch from VSGitExt to Main thread
-
                 // Create just in time on Main thread.
                 pullRequestSessionManager = serviceProvider.GetService<IPullRequestSessionManager>();