Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit f13d354

Browse files
Attempting to control the comment ability
1 parent fe6c09d commit f13d354

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

src/GitHub.InlineReviews/ViewModels/InlineCommentPeekViewModel.cs

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ public sealed class InlineCommentPeekViewModel : ReactiveObject, IDisposable
4040
ITrackingPoint triggerPoint;
4141
string relativePath;
4242
DiffSide side;
43+
bool availableForComment;
4344

4445
/// <summary>
4546
/// Initializes a new instance of the <see cref="InlineCommentPeekViewModel"/> class.
@@ -87,6 +88,12 @@ public InlineCommentPeekViewModel(IInlineCommentPeekService peekService,
8788
Observable.Return(previousCommentCommand.Enabled));
8889
}
8990

91+
public bool AvailableForComment
92+
{
93+
get { return availableForComment; }
94+
private set { this.RaiseAndSetIfChanged(ref availableForComment, value); }
95+
}
96+
9097
/// <summary>
9198
/// Gets the annotations displayed.
9299
/// </summary>
@@ -186,6 +193,11 @@ async Task UpdateThread()
186193
var lineAndLeftBuffer = peekService.GetLineNumber(peekSession, triggerPoint);
187194
var lineNumber = lineAndLeftBuffer.Item1;
188195
var leftBuffer = lineAndLeftBuffer.Item2;
196+
197+
AvailableForComment =
198+
file.Diff.Any(chunk => chunk.Lines
199+
.Any(line => line.NewLineNumber == lineNumber));
200+
189201
var thread = file.InlineCommentThreads?.FirstOrDefault(x =>
190202
x.LineNumber == lineNumber &&
191203
((leftBuffer && x.DiffLineType == DiffChangeType.Delete) || (!leftBuffer && x.DiffLineType != DiffChangeType.Delete)));

src/GitHub.InlineReviews/Views/InlineCommentPeekView.xaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,9 @@
113113
</ItemsControl.ItemTemplate>
114114
</ItemsControl>
115115

116-
<ghfvs:CommentThreadView x:Name="threadView" DataContext="{Binding Thread}"/>
116+
<ghfvs:CommentThreadView x:Name="threadView"
117+
Visibility="{Binding AvailableForComment, Converter={ghfvs:BooleanToVisibilityConverter}}"
118+
DataContext="{Binding Thread}"/>
117119
</StackPanel>
118120
</ScrollViewer>
119121
</DockPanel>

0 commit comments

Comments
 (0)