Merge pull request #2471 from github/fixes/update-octokit-graphql

jcansdale · web-flow · commit f3f8dee8f3a4 · 2020-03-11T19:35:46.000Z
Update GraphQL schema and add CheckConclusionState.(Skipped / Stale)
diff --git a/src/GitHub.App/Services/FromGraphQlExtensions.cs b/src/GitHub.App/Services/FromGraphQlExtensions.cs
@@ -29,6 +29,10 @@ public static class FromGraphQlExtensions
                     return CheckConclusionState.Success;
                 case Octokit.GraphQL.Model.CheckConclusionState.Neutral:
                     return CheckConclusionState.Neutral;
+                case Octokit.GraphQL.Model.CheckConclusionState.Skipped:
+                    return CheckConclusionState.Skipped;
+                case Octokit.GraphQL.Model.CheckConclusionState.Stale:
+                    return CheckConclusionState.Stale;
                 default:
                     throw new ArgumentOutOfRangeException(nameof(value), value, null);
             }
diff --git a/src/GitHub.App/Services/MentionsAutoCompleteSource.cs b/src/GitHub.App/Services/MentionsAutoCompleteSource.cs
@@ -54,7 +54,7 @@ public IObservable<AutoCompleteSuggestion> GetSuggestions()
             {
                 query = new Query().Repository(owner: Var(nameof(owner)), name: Var(nameof(name)))
                 .Select(repository =>
-                    repository.MentionableUsers(null, null, null, null)
+                    repository.MentionableUsers(null, null, null, null, null)
                         .AllPages()
                         .Select(sourceItem => 
                             new SuggestionItem(sourceItem.Login, 
diff --git a/src/GitHub.Exports/Models/CheckConclusionState.cs b/src/GitHub.Exports/Models/CheckConclusionState.cs
@@ -8,5 +8,7 @@ public enum CheckConclusionState
         Failure,
         Success,
         Neutral,
+        Skipped,
+        Stale
     }
 }
diff --git a/src/GitHub.InlineReviews/Services/PullRequestSessionService.cs b/src/GitHub.InlineReviews/Services/PullRequestSessionService.cs
@@ -347,7 +347,7 @@ async Task<PullRequestDetailModel> ReadPullRequestDetailWithResolved(HostAddress
                         }).ToList(),
                         Threads = pr.ReviewThreads(null, null, null, null).AllPages().Select(thread => new PullRequestReviewThreadModel
                         {
-                            Comments = thread.Comments(null, null, null, null).AllPages().Select(comment => new CommentAdapter
+                            Comments = thread.Comments(null, null, null, null, null).AllPages().Select(comment => new CommentAdapter
                             {
                                 Id = comment.Id.Value,
                                 PullRequestId = comment.PullRequest.Number,
diff --git a/submodules/octokit.graphql.net b/submodules/octokit.graphql.net
@@ -1 +1 @@
-Subproject commit ff20b6e9de3d016112de8787ec8ade080214db2b
+Subproject commit b38412dc816e034e155f8f89c14da65e04f659ad

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ public IObservable<AutoCompleteSuggestion> GetSuggestions()`
`54`	`54`	`{`
`55`	`55`	`query = new Query().Repository(owner: Var(nameof(owner)), name: Var(nameof(name)))`
`56`	`56`	`.Select(repository =>`
`57`		`- repository.MentionableUsers(null, null, null, null)`
	`57`	`+ repository.MentionableUsers(null, null, null, null, null)`
`58`	`58`	`.AllPages()`
`59`	`59`	`.Select(sourceItem =>`
`60`	`60`	`new SuggestionItem(sourceItem.Login,`
Original file line number	Diff line number	Diff line change
`@@ -8,5 +8,7 @@ public enum CheckConclusionState`
`8`	`8`	`Failure,`
`9`	`9`	`Success,`
`10`	`10`	`Neutral,`
	`11`	`+ Skipped,`
	`12`	`+ Stale`
`11`	`13`	`}`
`12`	`14`	`}`
Original file line number	Diff line number	Diff line change
`@@ -347,7 +347,7 @@ async Task<PullRequestDetailModel> ReadPullRequestDetailWithResolved(HostAddress`
`347`	`347`	`}).ToList(),`
`348`	`348`	`Threads = pr.ReviewThreads(null, null, null, null).AllPages().Select(thread => new PullRequestReviewThreadModel`
`349`	`349`	`{`
`350`		`- Comments = thread.Comments(null, null, null, null).AllPages().Select(comment => new CommentAdapter`
	`350`	`+ Comments = thread.Comments(null, null, null, null, null).AllPages().Select(comment => new CommentAdapter`
`351`	`351`	`{`
`352`	`352`	`Id = comment.Id.Value,`
`353`	`353`	`PullRequestId = comment.PullRequest.Number,`