Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit f5f8ef6

Browse files
committed
Move base Initialize call to the end.
Instead of calling RepoChanged.
1 parent d9acb7e commit f5f8ef6

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

src/GitHub.VisualStudio/UI/Views/GitHubPaneViewModel.cs

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -55,28 +55,26 @@ public GitHubPaneViewModel(ISimpleApiClientFactory apiFactory, ITeamExplorerServ
5555

5656
public override void Initialize(IServiceProvider serviceProvider)
5757
{
58-
base.Initialize(serviceProvider);
59-
60-
ServiceProvider.AddCommandHandler(GuidList.guidGitHubToolbarCmdSet, PkgCmdIDList.pullRequestCommand,
58+
serviceProvider.AddCommandHandler(GuidList.guidGitHubToolbarCmdSet, PkgCmdIDList.pullRequestCommand,
6159
(s, e) => Reload(new ViewWithData(UIControllerFlow.PullRequests) { ViewType = UIViewType.PRList }).Forget());
6260

63-
back = ServiceProvider.AddCommandHandler(GuidList.guidGitHubToolbarCmdSet, PkgCmdIDList.backCommand,
61+
back = serviceProvider.AddCommandHandler(GuidList.guidGitHubToolbarCmdSet, PkgCmdIDList.backCommand,
6462
() => !disabled && currentNavItem > 0,
6563
() => {
6664
DisableButtons();
6765
Reload(navStack[--currentNavItem], true).Forget();
6866
},
6967
true);
7068

71-
forward = ServiceProvider.AddCommandHandler(GuidList.guidGitHubToolbarCmdSet, PkgCmdIDList.forwardCommand,
69+
forward = serviceProvider.AddCommandHandler(GuidList.guidGitHubToolbarCmdSet, PkgCmdIDList.forwardCommand,
7270
() => !disabled && currentNavItem < navStack.Count - 1,
7371
() => {
7472
DisableButtons();
7573
Reload(navStack[++currentNavItem], true).Forget();
7674
},
7775
true);
7876

79-
refresh = ServiceProvider.AddCommandHandler(GuidList.guidGitHubToolbarCmdSet, PkgCmdIDList.refreshCommand,
77+
refresh = serviceProvider.AddCommandHandler(GuidList.guidGitHubToolbarCmdSet, PkgCmdIDList.refreshCommand,
8078
() => !disabled && navStack.Count > 0,
8179
() => {
8280
DisableButtons();
@@ -86,9 +84,7 @@ public override void Initialize(IServiceProvider serviceProvider)
8684

8785
initialized = true;
8886

89-
// The base Initialized call will have called RepoChanged(true) but at that point
90-
// initialized will have been false, so call it again now.
91-
RepoChanged(true);
87+
base.Initialize(serviceProvider);
9288
}
9389

9490
public void Initialize([AllowNull] ViewWithData data)

0 commit comments

Comments
 (0)