Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit f7b34b6

Browse files
committed
No need to suppress finalize for sealed classes
Since these classes are sealed and do not have finalizers, they will never be put in the finalizer queue so there's no need for this call.
1 parent 172696c commit f7b34b6

File tree

3 files changed

+0
-3
lines changed

3 files changed

+0
-3
lines changed

src/GitHub.App/Caches/ImageCache.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,6 @@ void Dispose(bool disposing)
239239
public void Dispose()
240240
{
241241
Dispose(true);
242-
GC.SuppressFinalize(this);
243242
}
244243

245244
class UriComparer : IEqualityComparer<Uri>

src/GitHub.App/Caches/LoginCache.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@ void Dispose(bool disposing)
7878
public void Dispose()
7979
{
8080
Dispose(true);
81-
GC.SuppressFinalize(this);
8281
}
8382
}
8483
}

src/GitHub.App/SampleData/SampleViewModels.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,6 @@ public string Title
300300

301301
public void Dispose()
302302
{
303-
GC.SuppressFinalize(this);
304303
}
305304

306305
public IObservable<AuthenticationResult> LogIn(string usernameOrEmail, string password)

0 commit comments

Comments
 (0)