Fix unit test compile errors.

Author: grokys

test/UnitTests/GitHub.Api/LoginManagerTests.cs

@@ -22,7 +22,7 @@ public async Task LoginTokenIsSavedToCache()
                 .Returns(new ApplicationAuthorization("123abc"));
 
             var keychain = Substitute.For<IKeychain>();
-            var tfa = Substitute.For<ITwoFactorChallengeHandler>();
+           var tfa = new Lazy<ITwoFactorChallengeHandler>(() => Substitute.For<ITwoFactorChallengeHandler>());
 
             var target = new LoginManager(keychain, tfa, "id", "secret");
             await target.Login(host, client, "foo", "bar");
@@ -40,7 +40,7 @@ public async Task LoggedInUserIsReturned()
             client.User.Current().Returns(user);
 
             var keychain = Substitute.For<IKeychain>();
-            var tfa = Substitute.For<ITwoFactorChallengeHandler>();
+            var tfa = new Lazy<ITwoFactorChallengeHandler>(() => Substitute.For<ITwoFactorChallengeHandler>());
 
             var target = new LoginManager(keychain, tfa, "id", "secret");
             var result = await target.Login(host, client, "foo", "bar");
@@ -63,7 +63,7 @@ public async Task DeletesExistingAuthenticationIfNullTokenReturned()
             client.User.Current().Returns(user);
 
             var keychain = Substitute.For<IKeychain>();
-            var tfa = Substitute.For<ITwoFactorChallengeHandler>();
+            var tfa = new Lazy<ITwoFactorChallengeHandler>(() => Substitute.For<ITwoFactorChallengeHandler>());
 
             var target = new LoginManager(keychain, tfa, "id", "secret");
             var result = await target.Login(host, client, "foo", "bar");
@@ -85,8 +85,8 @@ public async Task TwoFactorExceptionIsPassedToHandler()
                 .Returns(new ApplicationAuthorization("123abc"));
 
             var keychain = Substitute.For<IKeychain>();
-            var tfa = Substitute.For<ITwoFactorChallengeHandler>();
-            tfa.HandleTwoFactorException(exception).Returns(new TwoFactorChallengeResult("123456"));
+            var tfa = new Lazy<ITwoFactorChallengeHandler>(() => Substitute.For<ITwoFactorChallengeHandler>());
+            tfa.Value.HandleTwoFactorException(exception).Returns(new TwoFactorChallengeResult("123456"));
 
             var target = new LoginManager(keychain, tfa, "id", "secret");
             await target.Login(host, client, "foo", "bar");
@@ -112,8 +112,8 @@ public async Task Failed2FACodeResultsInRetry()
                 .Returns(new ApplicationAuthorization("123abc"));
 
             var keychain = Substitute.For<IKeychain>();
-            var tfa = Substitute.For<ITwoFactorChallengeHandler>();
-            tfa.HandleTwoFactorException(exception).Returns(
+            var tfa = new Lazy<ITwoFactorChallengeHandler>(() => Substitute.For<ITwoFactorChallengeHandler>());
+            tfa.Value.HandleTwoFactorException(exception).Returns(
                 new TwoFactorChallengeResult("111111"),
                 new TwoFactorChallengeResult("123456"));
 
@@ -147,8 +147,8 @@ public async Task HandlerNotifiedOfExceptionIn2FAChallengeResponse()
                 .Returns<ApplicationAuthorization>(_ => { throw loginAttemptsException; });
 
             var keychain = Substitute.For<IKeychain>();
-            var tfa = Substitute.For<ITwoFactorChallengeHandler>();
-            tfa.HandleTwoFactorException(twoFaException).Returns(
+            var tfa = new Lazy<ITwoFactorChallengeHandler>(() => Substitute.For<ITwoFactorChallengeHandler>());
+            tfa.Value.HandleTwoFactorException(twoFaException).Returns(
                 new TwoFactorChallengeResult("111111"),
                 new TwoFactorChallengeResult("123456"));
 
@@ -160,7 +160,7 @@ await client.Authorization.Received(1).GetOrCreateApplicationAuthentication(
                 "secret",
                 Arg.Any<NewAuthorization>(),
                 "111111");
-            tfa.Received(1).ChallengeFailed(loginAttemptsException);
+            tfa.Value.Received(1).ChallengeFailed(loginAttemptsException);
         }
 
         [Fact]
@@ -177,8 +177,8 @@ public async Task RequestResendCodeResultsInRetryingLogin()
             client.User.Current().Returns(user);
 
             var keychain = Substitute.For<IKeychain>();
-            var tfa = Substitute.For<ITwoFactorChallengeHandler>();
-            tfa.HandleTwoFactorException(exception).Returns(
+            var tfa = new Lazy<ITwoFactorChallengeHandler>(() => Substitute.For<ITwoFactorChallengeHandler>());
+            tfa.Value.HandleTwoFactorException(exception).Returns(
                 TwoFactorChallengeResult.RequestResendCode,
                 new TwoFactorChallengeResult("123456"));
 
@@ -202,7 +202,7 @@ public async Task UsesUsernameAndPasswordInsteadOfAuthorizationTokenWhenEnterpri
             client.User.Current().Returns(user);
 
             var keychain = Substitute.For<IKeychain>();
-            var tfa = Substitute.For<ITwoFactorChallengeHandler>();
+            var tfa = new Lazy<ITwoFactorChallengeHandler>(() => Substitute.For<ITwoFactorChallengeHandler>());
 
             var target = new LoginManager(keychain, tfa, "id", "secret");
             await target.Login(enterprise, client, "foo", "bar");
@@ -220,7 +220,7 @@ public async Task ErasesLoginWhenUnauthorized()
                 .Returns<ApplicationAuthorization>(_ => { throw new AuthorizationException(); });
 
             var keychain = Substitute.For<IKeychain>();
-            var tfa = Substitute.For<ITwoFactorChallengeHandler>();
+            var tfa = new Lazy<ITwoFactorChallengeHandler>(() => Substitute.For<ITwoFactorChallengeHandler>());
 
             var target = new LoginManager(keychain, tfa, "id", "secret");
             await Assert.ThrowsAsync<AuthorizationException>(async () => await target.Login(enterprise, client, "foo", "bar"));
@@ -238,7 +238,7 @@ public async Task ErasesLoginWhenNonOctokitExceptionThrown()
                 .Returns<ApplicationAuthorization>(_ => { throw new InvalidOperationException(); });
 
             var keychain = Substitute.For<IKeychain>();
-            var tfa = Substitute.For<ITwoFactorChallengeHandler>();
+            var tfa = new Lazy<ITwoFactorChallengeHandler>(() => Substitute.For<ITwoFactorChallengeHandler>());
 
             var target = new LoginManager(keychain, tfa, "id", "secret");
             await Assert.ThrowsAsync<InvalidOperationException>(async () => await target.Login(host, client, "foo", "bar"));
@@ -260,8 +260,8 @@ public async Task ErasesLoginWhenNonOctokitExceptionThrownIn2FA()
             client.User.Current().Returns(user);
 
             var keychain = Substitute.For<IKeychain>();
-            var tfa = Substitute.For<ITwoFactorChallengeHandler>();
-            tfa.HandleTwoFactorException(exception).Returns(new TwoFactorChallengeResult("123456"));
+            var tfa = new Lazy<ITwoFactorChallengeHandler>(() => Substitute.For<ITwoFactorChallengeHandler>());
+            tfa.Value.HandleTwoFactorException(exception).Returns(new TwoFactorChallengeResult("123456"));
 
             var target = new LoginManager(keychain, tfa, "id", "secret");
             await Assert.ThrowsAsync<InvalidOperationException>(async () => await target.Login(host, client, "foo", "bar"));