Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit fc7a955

Browse files
committed
An attempt at keeping the width of each row consistent
1 parent a762e9a commit fc7a955

File tree

1 file changed

+17
-16
lines changed

1 file changed

+17
-16
lines changed

src/GitHub.VisualStudio.UI/Views/GitHubPane/PullRequestCheckView.xaml

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,9 @@
2424

2525
<Grid>
2626
<Grid.ColumnDefinitions>
27-
<ColumnDefinition Width="Auto" SharedSizeGroup="ColumnZero" />
28-
<!-- <ColumnDefinition Width="*" SharedSizeGroup="ColumnOne" /> -->
29-
<ColumnDefinition Width="Auto" SharedSizeGroup="ColumnTwo" />
30-
<ColumnDefinition Width="*"/>
31-
<ColumnDefinition Width="Auto" SharedSizeGroup="ColumnFour" />
32-
<ColumnDefinition MinWidth="50" Width="Auto" SharedSizeGroup="ColumnFive" />
27+
<ColumnDefinition Width="Auto" SharedSizeGroup="Icon" />
28+
<ColumnDefinition Width="*" SharedSizeGroup="Title" />
29+
<ColumnDefinition Width="Auto" SharedSizeGroup="Links" />
3330
</Grid.ColumnDefinitions>
3431

3532
<Grid.RowDefinitions>
@@ -42,19 +39,23 @@
4239
<!--
4340
<Image Grid.Column="1" Source="{Binding Avatar}" Height="16" Width="16" />
4441
-->
45-
<Label Grid.Column="1" Foreground="{DynamicResource VsBrush.WindowText}" Content="{Binding Title}"/>
42+
<Label Grid.Column="1" Foreground="{DynamicResource VsBrush.WindowText}">
43+
<TextBlock TextTrimming="CharacterEllipsis" Text="{Binding Title}" />
44+
</Label>
4645
<!--
4746
<Label Grid.Column="3" HorizontalAlignment="Right" Content="{Binding Description}" ToolTip="{Binding Description}" />
4847
-->
49-
<Label Grid.Column="3" HorizontalAlignment="Right" Visibility="{Binding HasAnnotations, Converter={ghfvs:BooleanToVisibilityConverter}}">
50-
<Hyperlink ToolTip="View checks" Command="{Binding Path=DataContext.ShowAnnotations, RelativeSource={RelativeSource Mode=FindAncestor,AncestorType={x:Type local:PullRequestDetailView}}}">
51-
Checks
52-
</Hyperlink>
53-
</Label>
54-
<Label Grid.Column="4" HorizontalAlignment="Right"
55-
Visibility="{Binding DetailsUrl, Converter={ghfvs:NullToVisibilityConverter}}">
56-
<Hyperlink ToolTip="{Binding DetailsUrl}" Command="{Binding OpenDetailsUrl}">Details</Hyperlink>
57-
</Label>
48+
<StackPanel Orientation="Horizontal" HorizontalAlignment="Right" Grid.Column="2">
49+
<Label Visibility="{Binding HasAnnotations, Converter={ghfvs:BooleanToVisibilityConverter}}">
50+
<Hyperlink ToolTip="View checks" Command="{Binding Path=DataContext.ShowAnnotations, RelativeSource={RelativeSource Mode=FindAncestor,AncestorType={x:Type local:PullRequestDetailView}}}">
51+
Checks
52+
</Hyperlink>
53+
</Label>
54+
55+
<Label Visibility="{Binding DetailsUrl, Converter={ghfvs:NullToVisibilityConverter}}">
56+
<Hyperlink ToolTip="{Binding DetailsUrl}" Command="{Binding OpenDetailsUrl}">Details</Hyperlink>
57+
</Label>
58+
</StackPanel>
5859
</Grid>
5960
</local:GenericPullRequestCheckView>
6061

0 commit comments

Comments
 (0)