Merge pull request #1174 from github/fixes/1161-open-file-in-solution-non-temp-tab

Don't open file in solution in provisional tab.

Author: jcansdale

src/GitHub.VisualStudio/UI/Views/PullRequestDetailView.xaml.cs

@@ -87,7 +87,7 @@ async Task DoOpenFile(IPullRequestFileNode file, bool workingDirectory)
                 var fullPath = ViewModel.GetLocalFilePath(file);
                 var fileName = workingDirectory ? fullPath : await ViewModel.ExtractFile(file, true);
 
-                using (new NewDocumentStateScope(__VSNEWDOCUMENTSTATE.NDS_Provisional, VSConstants.NewDocumentStateReason.SolutionExplorer))
+                using (workingDirectory ? null : OpenInProvisionalTab())
                 {
                     var window = Services.Dte.ItemOperations.OpenFile(fileName);
                     window.Document.ReadOnly = !workingDirectory;
@@ -127,7 +127,7 @@ async Task DoDiffFile(IPullRequestFileNode file, bool workingDirectory)
                 }
 
                 IVsWindowFrame frame;
-                using (new NewDocumentStateScope(__VSNEWDOCUMENTSTATE.NDS_Provisional, VSConstants.NewDocumentStateReason.SolutionExplorer))
+                using (OpenInProvisionalTab())
                 {
                     var tooltip = $"{leftLabel}\nvs.\n{rightLabel}";
 
@@ -315,5 +315,12 @@ void OpenHyperlink(object sender, ExecutedRoutedEventArgs e)
                 VisualStudioBrowser.OpenUrl(uri);
             }
         }
+
+        static IDisposable OpenInProvisionalTab()
+        {
+            return new NewDocumentStateScope
+                (__VSNEWDOCUMENTSTATE.NDS_Provisional,
+                VSConstants.NewDocumentStateReason.SolutionExplorer);
+        }
     }
 }