Address PR feedback: move branch extraction after PR close, use env variable for testing repo

Co-authored-by: smockle <[email protected]>

Author: Copilot

.github/workflows/test.yml

@@ -17,6 +17,9 @@ concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: false # Allow previous workflows’ clean-up steps to complete
 
+env:
+  TESTING_REPOSITORY: github/accessibility-scanner-testing
+
 jobs:
   test:
     name: Test
@@ -74,7 +77,7 @@ jobs:
           login_url: http://127.0.0.1:4000/
           username: ${{ secrets.TEST_USERNAME }}
           password: ${{ secrets.TEST_PASSWORD }}
-          repository: github/accessibility-scanner-testing
+          repository: ${{ env.TESTING_REPOSITORY }}
           token: ${{ secrets.GH_TOKEN }}
           cache_key: ${{ steps.cache_key.outputs.cache_key }}
 
@@ -109,11 +112,11 @@ jobs:
             | while read -r URL; do
                 if [[ "$URL" == *"/pull/"* ]]; then
                   echo "Closing pull request: $URL"
-                  branch="$(gh pr view "$URL" --json headRefName -q .headRefName)" || true
                   gh pr close "$URL" || echo "Failed to close pull request: $URL"
+                  branch="$(gh pr view "$URL" --json headRefName -q .headRefName || true)"
                   if [[ -n "$branch" ]]; then
                     echo "Deleting branch: $branch"
-                    git push https://github.com/github/accessibility-scanner-testing --delete "$branch" || echo "Failed to delete branch: $branch"
+                    git push "https://github.com/${{ env.TESTING_REPOSITORY }}" --delete "$branch" || echo "Failed to delete branch: $branch"
                   fi
                 elif [[ "$URL" == *"/issues/"* ]]; then
                   echo "Closing issue: $URL"