fix: Clean-up Issue class: Reposition 'constructor', rename 'parseIssue', cache its result, and update the cache if 'url' changes

Author: smockle

.github/actions/file/src/Issue.ts

@@ -1,50 +1,63 @@
 import type { Issue as IssueInput } from "./types.d.js";
 
 export class Issue implements IssueInput {
-  /**
-   * Extracts owner, repository, and issue number from a GitHub issue URL.
-   * @param issueUrl A GitHub issue URL (e.g. `https://github.com/owner/repo/issues/42`).
-   * @returns An object with `owner`, `repository`, and `issueNumber` keys.
-   * @throws The provided URL is unparseable due to its unexpected format.
-   */
-  static parseIssueUrl(issueUrl: string): {
+  #url!: string;
+  #parsedUrl!: {
     owner: string;
     repository: string;
     issueNumber: number;
-  } {
-    const { owner, repository, issueNumber } =
-      /\/(?<owner>[^/]+)\/(?<repository>[^/]+)\/issues\/(?<issueNumber>\d+)(?:[/?#]|$)/.exec(
-        issueUrl
-      )?.groups || {};
-    if (!owner || !repository || !issueNumber) {
-      throw new Error(`Could not parse issue URL: ${issueUrl}`);
-    }
-    return { owner, repository, issueNumber: Number(issueNumber) };
-  }
-
-  url: string;
+  };
   nodeId: string;
   id: number;
   title: string;
   state?: "open" | "reopened" | "closed";
 
+  constructor({ url, nodeId, id, title, state }: IssueInput) {
+    this.url = url;
+    this.nodeId = nodeId;
+    this.id = id;
+    this.title = title;
+    this.state = state;
+  }
+
+  set url(newUrl: string) {
+    this.#url = newUrl;
+    this.#parsedUrl = this.#parseUrl();
+  }
+
+  get url(): string {
+    return this.#url;
+  }
+
   get owner(): string {
-    return Issue.parseIssueUrl(this.url).owner;
+    return this.#parsedUrl.owner;
   }
 
   get repository(): string {
-    return Issue.parseIssueUrl(this.url).repository;
+    return this.#parsedUrl.repository;
   }
 
   get issueNumber(): number {
-    return Issue.parseIssueUrl(this.url).issueNumber;
+    return this.#parsedUrl.issueNumber;
   }
 
-  constructor({ url, nodeId, id, title, state }: IssueInput) {
-    this.url = url;
-    this.nodeId = nodeId;
-    this.id = id;
-    this.title = title;
-    this.state = state;
+  /**
+   * Extracts owner, repository, and issue number from the Issue instance’s GitHub issue URL.
+   * @returns An object with `owner`, `repository`, and `issueNumber` keys.
+   * @throws The provided URL is unparseable due to its unexpected format.
+   */
+  #parseUrl(): {
+    owner: string;
+    repository: string;
+    issueNumber: number;
+  } {
+    const { owner, repository, issueNumber } =
+      /\/(?<owner>[^/]+)\/(?<repository>[^/]+)\/issues\/(?<issueNumber>\d+)(?:[/?#]|$)/.exec(
+        this.#url
+      )?.groups || {};
+    if (!owner || !repository || !issueNumber) {
+      throw new Error(`Could not parse issue URL: ${this.#url}`);
+    }
+    return { owner, repository, issueNumber: Number(issueNumber) };
   }
 }