BREAKING CHANGE(Fix): Remove deprecated input (#1785)

Fixes
github/continuous-ai-for-accessibility#46
(Hubber access only)

Follow-up to
github-community-projects/continuous-ai-for-accessibility-scanner#906

This PR:
- Removes Fix’s deprecated `issue_urls` input.
- Makes Fix’s `issues` input required.

Author: smockle

.github/actions/fix/README.md

@@ -8,11 +8,7 @@ Attempts to fix issues with Copilot.
 
 #### `issues`
 
-**NOTE: This input will be unconditionally required in `v2`.** **Required if `issue_urls` is not provided** List of issues to attempt to fix—including, at a minimum, their `url`s—as stringified JSON. For example: `'[{"url":"https://github.com/github/docs/issues/123"},{"nodeId":"SXNzdWU6Mg==","url":"https://github.com/github/docs/issues/124"},{"id":4,"nodeId":"SXNzdWU6NA==","url":"https://github.com/github/docs/issues/126","title":"Accessibility issue: 4"}]'`.
-
-#### `issue_urls`
-
-**DEPRECATED: This input will be removed in `v2`.** **Required if `issues` is not provided** List of issue URLs to attempt to fix, as stringified JSON. For example: `'["https://github.com/github/docs/issues/123","https://github.com/github/docs/issues/124","https://github.com/github/docs/issues/126","https://github.com/github/docs/issues/127"]'`. If both `issues` and `issue_urls` are provided, `issue_urls` will be ignored.
+**Required** List of issues to attempt to fix—including, at a minimum, their `url`s—as stringified JSON. For example: `'[{"url":"https://github.com/github/docs/issues/123"},{"nodeId":"SXNzdWU6Mg==","url":"https://github.com/github/docs/issues/124"},{"id":4,"nodeId":"SXNzdWU6NA==","url":"https://github.com/github/docs/issues/126","title":"Accessibility issue: 4"}]'`.
 
 #### `repository`
 

.github/actions/fix/action.yml

@@ -4,10 +4,7 @@ description: "Attempts to fix issues with Copilot."
 inputs:
   issues:
     description: "List of issues to attempt to fix, as stringified JSON"
-    required: false
-  issue_urls:
-    description: "List of issue URLs to attempt to fix, as stringified JSON"
-    required: false
+    required: true
   repository:
     description: "Repository (with owner) containing issues"
     required: true

.github/actions/fix/src/index.ts

@@ -9,23 +9,12 @@ const OctokitWithThrottling = Octokit.plugin(throttling);
 
 export default async function () {
   core.info("Started 'fix' action");
-  /** @deprecated Use `issues` instead. */
-  const issueUrls: string[] | null = JSON.parse(
-    core.getInput("issue_urls", { required: false }) || "null"
+  const issues: IssueInput[] = JSON.parse(
+    core.getInput("issues", { required: true }) || "[]"
   );
-  const issues: IssueInput[] | null = JSON.parse(
-    core.getInput("issues", { required: false }) || "null"
-  );
-  if (issueUrls === null && issues === null) {
-    core.setFailed(
-      "Neither 'issues' nor 'issue_urls' was provided, but one is required."
-    );
-    process.exit(1);
-  }
   const repoWithOwner = core.getInput("repository", { required: true });
   const token = core.getInput("token", { required: true });
   core.debug(`Input: 'issues: ${JSON.stringify(issues)}'`);
-  core.debug(`Input: 'issue_urls: ${JSON.stringify(issueUrls)}'`);
   core.debug(`Input: 'repository: ${repoWithOwner}'`);
 
   const octokit = new OctokitWithThrottling({
@@ -51,9 +40,7 @@ export default async function () {
       },
     },
   });
-  const issueInputs: IssueInput[] =
-    issues ?? issueUrls?.map((url) => ({ url })) ?? [];
-  for (const issueInput of issueInputs) {
+  for (const issueInput of issues) {
     try {
       const issue = new Issue(issueInput);
       await fixIssue(octokit, issue);