Skip to content

Commit 9eb64b6

Browse files
authored
Merge pull request #88 from github/theinterned/codespace-docker-chrome
Install chrome in codespaces via Dockerfile raster than use node-chromium package
2 parents 83cf377 + ec544c0 commit 9eb64b6

File tree

4 files changed

+4
-964
lines changed

4 files changed

+4
-964
lines changed

.devcontainer/Dockerfile

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,3 +14,7 @@ FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:0-${VARIANT}
1414

1515
# [Optional] Uncomment if you want to install more global node modules
1616
# RUN su node -c "npm install -g <your-package-list-here>"
17+
18+
RUN wget -q -O - https://dl-ssl.google.com/linux/linux_signing_key.pub | apt-key add - \
19+
&& echo "deb http://dl.google.com/linux/chrome/deb/ stable main" >> /etc/apt/sources.list.d/google.list
20+
RUN apt-get update && apt-get -y install google-chrome-stable

karma.config.cjs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
/* eslint-disable filenames/match-regex */
22

3-
// eslint-disable-next-line import/no-commonjs, no-undef, @typescript-eslint/no-var-requires
4-
process.env.CHROME_BIN = require('chromium').path
5-
63
function completer(request, response, next) {
74
if (request.method === 'GET' && request.url.startsWith('/search?q=hub')) {
85
response.writeHead(200)

0 commit comments

Comments
 (0)