Fix YAML parsing logic bug: replace impossible condition with proper indentation check

Copilot · aaronpowell · Copilot · commit 22e4bb21f01a · 2025-09-15T00:27:20.000Z
Co-authored-by: aaronpowell &lt;434140+aaronpowell@users.noreply.github.com&gt;
diff --git a/update-readme.js b/update-readme.js
@@ -167,7 +167,7 @@ function parseCollectionYaml(filePath) {
           } else if (currentObject && leadingSpaces > 0) {
             // Property of current object (e.g., display properties)
             currentObject[key] = value === "true" ? true : value === "false" ? false : value;
-          } else if (currentArray && currentObject && leadingSpaces > leadingSpaces) {
+          } else if (currentArray && currentObject && leadingSpaces > 2) {
             // Property of array item object
             currentObject[key] = value;
           }
diff --git a/validate-collections.js b/validate-collections.js
@@ -99,7 +99,7 @@ function parseCollectionYaml(filePath) {
           } else if (currentObject && leadingSpaces > 0) {
             // Property of current object (e.g., display properties)
             currentObject[key] = value === "true" ? true : value === "false" ? false : value;
-          } else if (currentArray && currentObject && leadingSpaces > leadingSpaces) {
+          } else if (currentArray && currentObject && leadingSpaces > 2) {
             // Property of array item object
             currentObject[key] = value;
           }

Original file line number	Diff line number	Diff line change
`@@ -167,7 +167,7 @@ function parseCollectionYaml(filePath) {`
`167`	`167`	`} else if (currentObject && leadingSpaces > 0) {`
`168`	`168`	`// Property of current object (e.g., display properties)`
`169`	`169`	`currentObject[key] = value === "true" ? true : value === "false" ? false : value;`
`170`		`- } else if (currentArray && currentObject && leadingSpaces > leadingSpaces) {`
	`170`	`+ } else if (currentArray && currentObject && leadingSpaces > 2) {`
`171`	`171`	`// Property of array item object`
`172`	`172`	`currentObject[key] = value;`
`173`	`173`	`}`
Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ function parseCollectionYaml(filePath) {`
`99`	`99`	`} else if (currentObject && leadingSpaces > 0) {`
`100`	`100`	`// Property of current object (e.g., display properties)`
`101`	`101`	`currentObject[key] = value === "true" ? true : value === "false" ? false : value;`
`102`		`- } else if (currentArray && currentObject && leadingSpaces > leadingSpaces) {`
	`102`	`+ } else if (currentArray && currentObject && leadingSpaces > 2) {`
`103`	`103`	`// Property of array item object`
`104`	`104`	`currentObject[key] = value;`
`105`	`105`	`}`