Skip to content

Commit 00cf7eb

Browse files
authored
Merge branch 'master' into lildude/reset-connect-job-run-time
2 parents feea728 + d29bc68 commit 00cf7eb

File tree

8 files changed

+21
-5
lines changed

8 files changed

+21
-5
lines changed

bin/ghe-host-check

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ fi
131131

132132
# backup-utils 2.13 onwards limits support to the current and previous two releases
133133
# of GitHub Enterprise Server.
134-
supported_minimum_version="3.1.0"
134+
supported_minimum_version="3.2.0"
135135

136136
if [ "$(version $version)" -ge "$(version $supported_minimum_version)" ]; then
137137
supported=1

debian/changelog

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
github-backup-utils (3.4.0) UNRELEASED; urgency=medium
2+
3+
* Add anchor to usage doc for settings restore #865
4+
5+
-- Steve Culver <[email protected]> Tue, 15 Feb 2022 19:25:09 +0000
6+
17
github-backup-utils (3.3.1) UNRELEASED; urgency=medium
28

39
* Fix compat issue with ghe-actions-start during maintenance mode #836

docs/faq.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,11 @@ snapshots of all major datastores. These snapshots are used to restore an instan
1919
to a prior state or set up a new instance without having another always-on GitHub
2020
Enterprise instance (like the High Availability replica).
2121

22+
### Does taking or restoring a backup impact the GitHub Enterprise Server's performance or operation?
23+
24+
Git background maintenance and garbage collection jobs become paused during the repositories stage of a backup and restore, and the storage stage of a backup. This may result in a backlog of queued maintenance or storage jobs observable in the GitHub Enterprise Server metrics for the duration of those steps. We suggest allowing any backlog to process and drain to 0 before starting another backup run. Repositories that are frequently pushed to may experience performance degradation over time if queued maintenance jobs are not processed.
25+
26+
Backup processes triggered by `backup-utils` running on the GitHub Enterprise Server instance run at a low CPU and IO priority to reduce any user facing impact. You may observe elevated levels of CPU usage, disk IO, and network IO for the duration of a backup run.
27+
28+
2229
[1]: https://help.github.com/enterprise/admin/guides/installation/high-availability-cluster-configuration/

docs/usage.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,8 @@ The `ghe-backup` and `ghe-restore` commands also have a verbose output mode
8080
(`-v`) that lists files as they're being transferred. It's often useful to
8181
enable when output is logged to a file.
8282

83+
### Restoring settings, TLS certificate, and license
84+
8385
When restoring to a new GitHub Enterprise Server instance, settings, certificate, and
8486
license data *are* restored. These settings must be reviewed and saved before
8587
using the GitHub Enterprise Server to ensure all migrations take place and all required

script/package-deb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,6 @@ git checkout -q "$PKG_HEAD"
2626

2727
debuild -uc -us 1>&2
2828
cd ..
29-
files=$(ls -1 *.deb *.tar.gz *.dsc *.changes)
29+
files=$(ls -1 *.deb *.tar.xz *.dsc *.changes)
3030
mv $files ../
3131
for f in $files; do echo "dist/$f"; done

share/github-backup-utils/version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3.3.1
1+
3.4.0

test/test-ghe-host-check.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,8 @@ begin_test "ghe-host-check detects unsupported GitHub Enterprise Server versions
6161
! GHE_TEST_REMOTE_VERSION=2.21.0 ghe-host-check
6262
! GHE_TEST_REMOTE_VERSION=2.22.0 ghe-host-check
6363
! GHE_TEST_REMOTE_VERSION=3.0.0 ghe-host-check
64-
GHE_TEST_REMOTE_VERSION=3.1.0 ghe-host-check
64+
! GHE_TEST_REMOTE_VERSION=3.1.0 ghe-host-check
65+
GHE_TEST_REMOTE_VERSION=3.2.0 ghe-host-check
6566
GHE_TEST_REMOTE_VERSION=$BACKUP_UTILS_VERSION ghe-host-check
6667
GHE_TEST_REMOTE_VERSION=$BACKUP_UTILS_VERSION ghe-host-check
6768
GHE_TEST_REMOTE_VERSION=$bu_version_major.$bu_version_minor.999 ghe-host-check

test/testlib.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export GHE_BACKUP_CONFIG GHE_DATA_DIR GHE_REMOTE_DATA_DIR GHE_REMOTE_ROOT_DIR
4242

4343
# The default remote appliance version. This may be set in the environment prior
4444
# to invoking tests to emulate a different remote vm version.
45-
: ${GHE_TEST_REMOTE_VERSION:=3.3.0.rc1}
45+
: ${GHE_TEST_REMOTE_VERSION:=3.4.0.rc1}
4646
export GHE_TEST_REMOTE_VERSION
4747

4848
# Source in the backup config and set GHE_REMOTE_XXX variables based on the

0 commit comments

Comments
 (0)