Merge pull request #420 from github/lildude/prevent-restore-to-older

Prevent restoring snapshots to older releases

Author: lildude

bin/ghe-host-check

@@ -91,6 +91,17 @@ if [ -z "$version" ]; then
   exit 2
 fi
 
+# Block restoring snapshots to older releases of GitHub Enterprise
+if [ -n "$GHE_RESTORE_SNAPSHOT_PATH" ]; then
+  snapshot_version=$(cat $GHE_RESTORE_SNAPSHOT_PATH/version)
+  # shellcheck disable=SC2046 # Word splitting is required to populate the variables
+  read -r snapshot_version_major snapshot_version_minor _ <<<$(ghe_parse_version $snapshot_version)
+  if [ "$(version $GHE_REMOTE_VERSION)" -lt "$(version $snapshot_version_major.$snapshot_version_minor.0)" ]; then
+    echo "Error: Snapshot can not be restored to an older release of GitHub Enterprise." >&2
+    exit 1
+  fi
+fi
+
 if [ -z "$GHE_ALLOW_REPLICA_BACKUP" ]; then
   if [ "$(ghe-ssh $host -- cat $GHE_REMOTE_ROOT_DIR/etc/github/repl-state 2>/dev/null || true)" = "replica" ]; then
     echo "Error: high availability replica detected." 1>&2

test/test-ghe-host-check.sh

@@ -78,3 +78,16 @@ begin_test "ghe-host-check detects high availability replica"
   GHE_ALLOW_REPLICA_BACKUP=yes ghe-host-check
 )
 end_test
+
+begin_test "ghe-host-check blocks restore to old release"
+(
+  set -e
+  
+  mkdir -p "$GHE_DATA_DIR/current/"
+  echo "$GHE_TEST_REMOTE_VERSION" > "$GHE_DATA_DIR/current/version"
+
+  # shellcheck disable=SC2046 # Word splitting is required to populate the variables
+  read -r bu_version_major bu_version_minor bu_version_patch <<<$(ghe_parse_version $GHE_TEST_REMOTE_VERSION)
+  ! GHE_TEST_REMOTE_VERSION=$bu_version_major.$((bu_version_minor-1)).$bu_version_patch ghe-restore -v
+)
+end_test

test/test-ghe-restore.sh

@@ -341,7 +341,7 @@ begin_test "ghe-restore fails when restore 2.9/2.10 snapshot without audit log m
   set -e
 
   # noop if not testing against 2.11
-  if [ "$GHE_VERSION_MAJOR" -ne 2 ] && [ "$GHE_VERSION_MINOR" -ne 11 ]; then
+  if [ "$(version $GHE_REMOTE_VERSION)" -ne "$(version 2.11.0)" ]; then
     skip_test
   fi
 
@@ -368,7 +368,7 @@ begin_test "ghe-restore force restore of 2.9/2.10 snapshot without audit log mig
   set -e
 
   # noop if not testing against 2.11
-  if [ "$GHE_VERSION_MAJOR" -ne 2 ] && [ "$GHE_VERSION_MINOR" -ne 11 ]; then
+  if [ "$(version $GHE_REMOTE_VERSION)" -ne "$(version 2.11.0)" ]; then
     skip_test
   fi