Fix redirection bug (SC2259) in test/testlib.sh

h-yamane-sti · h-yamane-sti · commit 2bc31a99174a · 2021-05-18T00:00:36.000+09:00
ShellCheck 0.7.2 says > In test/testlib.sh line 149: > grep -a -v -e '^\+ end_test' -e '^+ set +x' <"$TRASHDIR/out" | > ^-- SC2259: This redirection overrides piped input. To use both, merge or pass filenames. > >For more information: > https://www.shellcheck.net/wiki/SC2259 -- This redirection overrides piped ...
diff --git a/test/testlib.sh b/test/testlib.sh
@@ -146,7 +146,7 @@ report_failure () {
   printf "test: %-73s $msg\\n" "$desc ..."
   (
     sed 's/^/    /' <"$TRASHDIR/out" |
-    grep -a -v -e '^\+ end_test' -e '^+ set +x' <"$TRASHDIR/out" |
+    grep -a -v -e '^\+ end_test' -e '^+ set +x' - "$TRASHDIR/out" |
     sed 's/[+] test_status=/test failed. last command exited with /' |
     sed 's/^/    /'
   ) 1>&2

Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,7 @@ report_failure () {`
`146`	`146`	`printf "test: %-73s $msg\\n" "$desc ..."`
`147`	`147`	`(`
`148`	`148`	`sed 's/^/ /' <"$TRASHDIR/out" \|`
`149`		`- grep -a -v -e '^\+ end_test' -e '^+ set +x' <"$TRASHDIR/out" \|`
	`149`	`+ grep -a -v -e '^\+ end_test' -e '^+ set +x' - "$TRASHDIR/out" \|`
`150`	`150`	`sed 's/[+] test_status=/test failed. last command exited with /' \|`
`151`	`151`	`sed 's/^/ /'`
`152`	`152`	`) 1>&2`