Skip to content

Commit 7bdd77b

Browse files
committed
break up tests to try to appease shellcheck
1 parent b427a32 commit 7bdd77b

File tree

2 files changed

+36
-2
lines changed

2 files changed

+36
-2
lines changed

test/test-ghe-backup.sh

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -618,7 +618,8 @@ begin_test "ghe-backup does not take backup of encrypted column current encrypti
618618
)
619619
end_test
620620

621-
begin_test "ghe-backup takes backup of encrypted column current encryption key for versions 3.8.0+"
621+
# encrypted column current encryption key needs to be backed up for versions 3.8.0+
622+
begin_test "ghe-backup takes backup of encrypted column current encryption key for versions 3.8.0"
622623
(
623624
set -e
624625

@@ -642,6 +643,21 @@ begin_test "ghe-backup takes backup of encrypted column current encryption key f
642643
for file in "${required_files[@]}"; do
643644
[ "$(cat "$GHE_DATA_DIR/current/$file")" = "foo" ]
644645
done
646+
)
647+
end_test
648+
649+
# encrypted column current encryption key needs to be backed up for versions 3.8.0+
650+
begin_test "ghe-backup takes backup of encrypted column current encryption key for versions 3.9.0"
651+
(
652+
set -e
653+
654+
required_secrets=(
655+
"secrets.github.encrypted-column-current-encryption-key"
656+
)
657+
658+
for secret in "${required_secrets[@]}"; do
659+
ghe-ssh "$GHE_HOSTNAME" -- ghe-config "$secret" "foo"
660+
done
645661

646662
# GHES version 3.9.0
647663
GHE_REMOTE_VERSION=3.9.0

test/test-ghe-restore.sh

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,9 @@ begin_test "ghe-restore does not encrypted column current encryption key for ver
344344
)
345345
end_test
346346

347-
begin_test "ghe-restore with encrypted column current encryption key for versions 3.8.0+"
347+
348+
# encrypted column current encryption key needs to be restored for versions 3.8.0+
349+
begin_test "ghe-restore with encrypted column current encryption key for versions 3.8.0"
348350
(
349351
set -e
350352
rm -rf "$GHE_REMOTE_ROOT_DIR"
@@ -369,7 +371,23 @@ begin_test "ghe-restore with encrypted column current encryption key for version
369371
for secret in "${required_secrets[@]}"; do
370372
[ "$(ghe-ssh "$GHE_HOSTNAME" -- ghe-config "$secret")" = "foo" ]
371373
done
374+
)
375+
end_test
376+
377+
# encrypted column current encryption key needs to be restored for versions 3.8.0+
378+
begin_test "ghe-restore with encrypted column current encryption key for versions 3.9.0"
379+
(
380+
set -e
381+
rm -rf "$GHE_REMOTE_ROOT_DIR"
382+
setup_remote_metadata
372383

384+
required_files=(
385+
"encrypted-column-current-encryption-key"
386+
)
387+
388+
for file in "${required_files[@]}"; do
389+
echo "foo" > "$GHE_DATA_DIR/current/$file"
390+
done
373391

374392
# GHES version 3.9.0
375393
GHE_REMOTE_VERSION=3.9.0

0 commit comments

Comments
 (0)