Skip to content

Commit 81508c7

Browse files
authored
Merge pull request #256 from github/atirikt/for_varz
Add backup-restore for varz
2 parents 00e57b0 + 9a606f4 commit 81508c7

File tree

4 files changed

+55
-0
lines changed

4 files changed

+55
-0
lines changed

share/github-backup-utils/ghe-backup-settings

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ backup-secret "management console password" "manage-password" "secrets.manage"
7878
backup-secret "management console argon2 secret" "manage-argon-secret" "secrets.manage-auth.argon-secret"
7979
backup-secret "password pepper" "password-pepper" "secrets.github.user-password-secrets"
8080
backup-secret "kredz.credz HMAC key" "kredz-credz-hmac" "secrets.kredz.credz-hmac-secret"
81+
backup-secret "kredz.varz HMAC key" "kredz-varz-hmac" "secrets.kredz.varz-hmac-secret"
8182

8283
# Backup external MySQL password if running external MySQL DB.
8384
if is_service_external 'mysql'; then

share/github-backup-utils/ghe-restore-settings

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,9 @@ restore-secret "management console argon2 secret" "manage-argon-secret" "secrets
5050
# Restore kredz.credz HMAC key if present.
5151
restore-secret "kredz.credz HMAC key" "kredz-credz-hmac" "secrets.kredz.credz-hmac-secret"
5252

53+
# Restore kredz.varz HMAC key if present.
54+
restore-secret "kredz.varz HMAC key" "kredz-varz-hmac" "secrets.kredz.varz-hmac-secret"
55+
5356
# Restore SAML keys if present.
5457
if [ -f "$GHE_RESTORE_SNAPSHOT_PATH/saml-keys.tar" ]; then
5558
echo "Restoring SAML keys ..."

test/test-ghe-backup.sh

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -506,6 +506,31 @@ begin_test "ghe-backup takes backup of Kredz settings"
506506
)
507507
end_test
508508

509+
begin_test "ghe-backup takes backup of kredz-varz settings"
510+
(
511+
set -e
512+
513+
required_secrets=(
514+
"secrets.kredz.varz-hmac-secret"
515+
)
516+
517+
for secret in "${required_secrets[@]}"; do
518+
ghe-ssh "$GHE_HOSTNAME" -- ghe-config "$secret" "foo"
519+
done
520+
521+
ghe-backup
522+
523+
required_files=(
524+
"kredz-varz-hmac"
525+
)
526+
527+
for file in "${required_files[@]}"; do
528+
[ "$(cat "$GHE_DATA_DIR/current/$file")" = "foo" ]
529+
done
530+
531+
)
532+
end_test
533+
509534
begin_test "ghe-backup takes backup of Actions settings"
510535
(
511536
set -e

test/test-ghe-restore.sh

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -336,6 +336,32 @@ begin_test "ghe-restore with Kredz settings"
336336
)
337337
end_test
338338

339+
begin_test "ghe-restore with kredz-varz settings"
340+
(
341+
set -e
342+
rm -rf "$GHE_REMOTE_ROOT_DIR"
343+
setup_remote_metadata
344+
enable_actions
345+
346+
required_files=(
347+
"kredz-varz-hmac"
348+
)
349+
350+
for file in "${required_files[@]}"; do
351+
echo "foo" > "$GHE_DATA_DIR/current/$file"
352+
done
353+
354+
ghe-restore -v -f localhost
355+
required_secrets=(
356+
"secrets.kredz.varz-hmac-secret"
357+
)
358+
359+
for secret in "${required_secrets[@]}"; do
360+
[ "$(ghe-ssh "$GHE_HOSTNAME" -- ghe-config "$secret")" = "foo" ]
361+
done
362+
)
363+
end_test
364+
339365
begin_test "ghe-restore with Actions settings"
340366
(
341367
set -e

0 commit comments

Comments
 (0)