Merge pull request #327 from github/fix-cleanup-cluster-nodes

Fix cleanup_cluster_nodes function in ghe-restore

Author: gamefiend

bin/ghe-restore

@@ -135,6 +135,7 @@ cleanup () {
 }
 
 # This function's type definition is being passed to a remote host via `ghe-ssh` but is not used locally.
+# because it doesn't run locally does not redirect output to fd 3 or use log_info/log_warn/log_error.
 # shellcheck disable=SC2034
 cleanup_cluster_nodes() {
   uuid="$1"
@@ -143,18 +144,18 @@ cleanup_cluster_nodes() {
     exit 2
   fi
 
-  log_info "Cleaning up spokes" 1>&3
+  echo "Cleaning up spokes"
   ghe-spokes server evacuate "git-server-$uuid" 'Removing replica'
   ghe-spokes server destroy "git-server-$uuid"
 
-  log_info "Cleaning up storage" 1>&3
+  echo "Cleaning up storage"
   ghe-storage destroy-host "storage-server-$uuid" --force
 
-  log_info "Cleaning up dpages" 1>&3
+  echo "Cleaning up dpages"
   ghe-dpages offline "pages-server-$uuid"
   ghe-dpages remove "pages-server-$uuid"
 
-  log_info "Cleaning up redis" 1>&3
+  echo "Cleaning up redis"
   ghe-redis-cli del "resque:queue:maint_git-server-$uuid"
   ghe-redis-cli srem resque:queues "maint_git-server-$uuid"
 }